IETF Logo Mail Archive

Re: [Sframe] Feedback on draft-ietf-sframe-enc-04

Richard Barnes <rlb@ipv.sx> Thu, 16 November 2023 17:30 UTC

Return-Path: <rlb@ipv.sx>
X-Original-To: sframe@ietfa.amsl.com
Delivered-To: sframe@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E321C14CF17 for <sframe@ietfa.amsl.com>; Thu, 16 Nov 2023 09:30:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.904
X-Spam-Level:
X-Spam-Status: No, score=-1.904 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ipv-sx.20230601.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yT5DE3slsGwW for <sframe@ietfa.amsl.com>; Thu, 16 Nov 2023 09:30:07 -0800 (PST)
Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F09AC14F73E for <sframe@ietf.org>; Thu, 16 Nov 2023 09:30:07 -0800 (PST)
Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9c773ac9b15so155398366b.2 for <sframe@ietf.org>; Thu, 16 Nov 2023 09:30:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipv-sx.20230601.gappssmtp.com; s=20230601; t=1700155804; x=1700760604; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZG90YHt9StMsTFj79l+ouhGRFzpXjgZuBSrxhY8+y0c=; b=V3Puu804TQ8Og27J8zqk/U7naUn+EbBBducGbb14mg5RAnRHdc3sj1gGNvEj2Ly6rc Lkk3FXMHUftBIqfuJnnRECZ2VqxNlMJbftpmr2pPS6u2GVrV2YoTEy64JZ3609iu0QRh pHU3/I7nyCm3t9ILFNQi1kETFLx7DLt8GxX3B0zZTc66PgdTmQit0P7kl398GWVlQTm9 yje8uU/tkr1wAIz6LhUg0a1AizRNWuQZhxiis5ytLgvBEtHaaRo8kBZbI5zSEOcb7f/X T87FRnMy3bQG6aS6KHaVfwkRLlBDTvJvJpsVQBpSRPvilOr1/164tc+1UkiQqHmuUF+9 d8Wg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700155804; x=1700760604; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZG90YHt9StMsTFj79l+ouhGRFzpXjgZuBSrxhY8+y0c=; b=RTjdxLMtFchuXY5CeziTZ7wd1MoR+gjb2U/nBFkMXqJCq8FDsLwey7pYAdthclREwx Gsjl0Z+ZqckRlkvucUsanK/P/vFuZiL6kGLgJUk7gBWksHxDU9gzf1cH66nbADwDjirY /GcX/AwyIfh00/ill/OJEeAqlKQUVPFp3XKTiGLa+WdWEptiAR/fIE8AOrhP3MqJQDjt zGAE+Iha82hxRPRj693JCZwmJfRV3AplFqHhXFlSCysOVW/eTLtxEEKjLF6TGW0tBOM3 Iw/GEJgn60/za+GzdxnGy1csTEgwIBD6fCH7EhDaWTM5Rj/2rEr0EVJDLd71imfEk2e4 puzg==
X-Gm-Message-State: AOJu0YxhpA82b0XPaDeazqEI4CKsTV+hR7aOTsmAt2kcP0ciYaErlbUz Dx1TqIqHJLB+/1rySUAAUh6VQyQDhw8sXam2cZEw0t+Yl9+46khtZ08=
X-Google-Smtp-Source: AGHT+IGUcd56AqhpIJcgusPSrXvx3r2BekgTHXzqndajCaBI3LRYtOiHRezGM6iLW3+GxvWg02VtQomAprc+4nf2Ls0=
X-Received: by 2002:a17:907:111a:b0:9bf:2673:7371 with SMTP id qu26-20020a170907111a00b009bf26737371mr14986804ejb.13.1700155804300; Thu, 16 Nov 2023 09:30:04 -0800 (PST)
MIME-Version: 1.0
References: <0703284B-8829-45E3-B39B-67D2BBD86DB5@heapingbits.net>
In-Reply-To: <0703284B-8829-45E3-B39B-67D2BBD86DB5@heapingbits.net>
From: Richard Barnes <rlb@ipv.sx>
Date: Thu, 16 Nov 2023 12:29:53 -0500
Message-ID: <CAL02cgRrKPV+XC9LPXxwL7iKqZ8J_d42ubu5BjYM+c4yGPfpkA@mail.gmail.com>
To: Christopher Wood <caw@heapingbits.net>
Cc: sframe@ietf.org
Content-Type: multipart/alternative; boundary="000000000000c74a75060a485ed2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/sframe/_ZAJ1c5H6hyCblhA8OaXFUcG_ec>
Subject: Re: [Sframe] Feedback on draft-ietf-sframe-enc-04
X-BeenThere: sframe@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Secure Media Frames <sframe.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sframe>, <mailto:sframe-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sframe/>
List-Post: <mailto:sframe@ietf.org>
List-Help: <mailto:sframe-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sframe>, <mailto:sframe-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Nov 2023 17:30:08 -0000

Hi Chris,

Thanks for the detailed review.  I responded to the issues on GitHub.  It
looks like the fixes should be fairly minor.  I will leave it to the chairs
whether we need any further process around things like changing SHOULD NOT
to MUST NOT.

Re implementations: I made a PR with a few pointers:
https://github.com/sframe-wg/sframe/pull/159

--Richard

On Thu, Nov 16, 2023 at 9:41 AM Christopher Wood <caw@heapingbits.net>
wrote:

> Hi folks,
>
> I reviewed draft-ietf-sframe-enc-04 for the WGLC. Overall, I found the
> specification very well written. I submitted a couple of issues I think
> ought to be addressed [1], as well as an editorial PR that I think helps
> tidy up some things [2]. I think the document is ready to proceed when
> these issues are resolved.
>
> I’d like to call out issues #158 [3] and #154 [4] specifically. Issue #158
> seems like it can be resolved with a normative change or, alternatively,
> some motivating text. (I suppose another way would be to remove metadata,
> but I think SFrame should keep the metadata concept — it’s quite cheap and
> can help future extensibility). Issue #154 may also require a normative
> change to specify decryption failure behavior.
>
> As an aside, out of curiosity, how many implementations of SFrame exist?
> Are they tracked anywhere?
>
> Best,
> Chris
>
> [1] https://github.com/sframe-wg/sframe/issues/created_by/chris-wood
> [2] https://github.com/sframe-wg/sframe/pull/153
> [3] https://github.com/sframe-wg/sframe/issues/158
> [4] https://github.com/sframe-wg/sframe/issues/154
> --
> Sframe mailing list
> Sframe@ietf.org
> https://www.ietf.org/mailman/listinfo/sframe
>

v2.23.0 | Report a Bug | By Email