Re: [Sidrops] Format of ASPA RTR PDU

Maria Matejka <maria.matejka@nic.cz> Tue, 28 November 2023 19:02 UTC

Return-Path: <maria.matejka@nic.cz>
X-Original-To: sidrops@ietfa.amsl.com
Delivered-To: sidrops@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 95973C15154A for <sidrops@ietfa.amsl.com>; Tue, 28 Nov 2023 11:02:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nic.cz
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GHVhzaVlUhdB for <sidrops@ietfa.amsl.com>; Tue, 28 Nov 2023 11:02:52 -0800 (PST)
Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 14D72C14CE4D for <sidrops@ietf.org>; Tue, 28 Nov 2023 11:02:51 -0800 (PST)
Received: from [IPV6:2001:1488:fffe:6:ffff:ffff:fffe:4] (unknown [IPv6:2001:1488:fffe:6:ffff:ffff:fffe:4]) by mail.nic.cz (Postfix) with ESMTPSA id 8FDB11C1481; Tue, 28 Nov 2023 20:02:47 +0100 (CET)
Authentication-Results: mail.nic.cz; auth=pass smtp.auth=maria.matejka@nic.cz smtp.mailfrom=maria.matejka@nic.cz
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1701198168; bh=iQNOZLKp4wV4PvTQsMP55WVOL2SsokKG56FeTAG3x+w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Reply-To: Subject:To:Cc; b=vlumiwRoGQAQC01dgBgmQaH84LKRBq9BHJvTFfK1v60E3q2UCR+zESSKtp7QJNo6J lcug5t8M/U038EdnD/4nltim3HOZjDDwtl5NLypiUVClm7IqUiTJLRqqPU4UEE/SYL UdmUBuPP/U8NNMtMBwEBWbPiug3Qma6dylAH8GtU=
Content-Type: multipart/alternative; boundary="------------0uK9sQJ4Rx4C0n230r9toj6E"
Message-ID: <63ecbc8e-afe9-468a-9f84-91ed436ac4ce@nic.cz>
Date: Tue, 28 Nov 2023 20:02:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US, cs
To: Claudio Jeker <cjeker@diehard.n-r-g.com>, Martin Hoffmann <martin@nlnetlabs.nl>
Cc: sidrops <sidrops@ietf.org>, Kateřina Kubecová <katerina.kubecova@nic.cz>, Ondrej Zajicek <santiago@crfreenet.org>
References: <0d8fcb69-54e1-4ba3-b5c9-29f93b3271eb@nic.cz> <ZUpWsu5xtPSJwUN2@diehard.n-r-g.com> <20231108103704.45af35c2@glaurung.nlnetlabs.nl> <ZUtYi01nYNExFAOY@diehard.n-r-g.com>
From: Maria Matejka <maria.matejka@nic.cz>
In-Reply-To: <ZUtYi01nYNExFAOY@diehard.n-r-g.com>
X-Virus-Scanned: clamav-milter 0.103.7 at mail
X-Virus-Status: Clean
X-Rspamd-Action: no action
X-Rspamd-Pre-Result: action=no action; module=multimap; Matched map: WHITELISTED_IP
X-Rspamd-Server: mail
X-Spamd-Bar: /
X-Rspamd-Queue-Id: 8FDB11C1481
X-Spamd-Result: default: False [-0.10 / 20.00]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FUZZY_BLOCKED(0.00)[rspamd.com]; WHITELISTED_IP(0.00)[2001:1488:fffe:6:ffff:ffff:fffe:4]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:25192, ipnet:2001:1488::/32, country:CZ]
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidrops/3mzj-fRIQZZDVzHmaQ9KNirdhW0>
Subject: Re: [Sidrops] Format of ASPA RTR PDU
X-BeenThere: sidrops@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: A list for the SIDR Operations WG <sidrops.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidrops>, <mailto:sidrops-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidrops/>
List-Post: <mailto:sidrops@ietf.org>
List-Help: <mailto:sidrops-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidrops>, <mailto:sidrops-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Nov 2023 19:02:56 -0000

Dear WG,

>>> On Tue, Nov 07, 2023 at 04:00:49PM +0100, Maria Matejka wrote:
>>>> While trying to implement ASPA in RTR, we got confused by § 5.12,
>>>> ASPA PDU, as of draft-ietf-sidrops-8210bis-11. Bytes 2 and 3 are
>>>> set to zero and bytes 10 and 11 are encoding Provider AS Count
>>>> which can be inferred from the overall PDU length easily. Is there
>>>> any good reason to have this redundant information inside the PDU?
>>>> We are suggesting to move the Flags and AFI Flags to bytes 2 and 3
>>>> and to drop Provider AS Count completely. The Customer ASN would
>>>> then start at byte 8 and Provider ASNs would start at byte 12.

returning to the ASPA RTR PDU format, I'm wishing to update the 5.12 
section as follows → we shall drop the AFI Flags (making them zero) and 
Provider AS Count (can be inferred from Length easily) and move the 
Flags to the byte 2.

Regarding all other parts of ASPA implementation in BIRD, it is 
basically prepared for merge and release, so we'd like to resolve this 
issue rather sooner than later, to avoid releasing breaking code changes.

Please see the updated parts below.

>
>       5.12.
>       <https://datatracker.ietf.org/doc/html/draft-ietf-sidrops-8210bis-11#section-5.12>ASPA
>       PDU
>       <https://datatracker.ietf.org/doc/html/draft-ietf-sidrops-8210bis-11#name-aspa-pdu>
>
>
> 0          8          16         24        31
> .-------------------------------------------.
> | Protocol |   PDU    |          |          |
> | Version  |   Type   |   Flags  |   zero   |
> |    2     |    11    |          |          |
> +-------------------------------------------+
> |                                           |
> |                 Length                    |
> |                                           |
> +-------------------------------------------+
> |                                           |
> |    Customer Autonomous System Number      |
> |                                           |
> +-------------------------------------------+
> |                                           |
> ~    Provider Autonomous System Numbers     ~
> |                                           |
> ~-------------------------------------------~
>
> (… 4 paragraphs skipped …)
>
> If the announce/withdraw flag is set to 0, it indicates removal of the 
> entire ASPA record for that Customer AS. Here, the customer AS of the 
> ASPA record MUST be provided. The Provider AS Numbers list MUST be 
> null and ignored by the router.
>
> The Customer Autonomous System Number is the 32-bit Autonomous System 
> Number of the customer which authenticated the ASPA RPKI data. There 
> MUST be one and only one ASPA for a Customer Autonomous System Number 
> active in the router at any time. There are zero or more 32-bit 
> Provider Autonomous System Number fields as indicated by the PDU 
> Length; see [I-D.ietf-sidrops-aspa-profile 
> <https://datatracker.ietf.org/doc/html/draft-ietf-sidrops-aspa-profile-16>].
>
Thank you for processing this.

-- 
Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o.