Re: [Sidrops] I-D Action: draft-ietf-sidrops-aspa-profile-15.txt

Job Snijders <job@fastly.com> Wed, 28 June 2023 15:53 UTC

Return-Path: <job@fastly.com>
X-Original-To: sidrops@ietfa.amsl.com
Delivered-To: sidrops@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AE4CC151065 for <sidrops@ietfa.amsl.com>; Wed, 28 Jun 2023 08:53:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.094
X-Spam-Level:
X-Spam-Status: No, score=-7.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fastly.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RcUocEDTsn5s for <sidrops@ietfa.amsl.com>; Wed, 28 Jun 2023 08:53:55 -0700 (PDT)
Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B095C14EB17 for <sidrops@ietf.org>; Wed, 28 Jun 2023 08:53:55 -0700 (PDT)
Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-51d9695ec29so4096609a12.1 for <sidrops@ietf.org>; Wed, 28 Jun 2023 08:53:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1687967633; x=1690559633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rgr2XhXt37wo7AQkYrdUQ0lXWAQPuARwonW63x/Kx6k=; b=k9BkGnfjMrydEWp7DT4tllEub4RdiOdg9F4OM0uT3tkKhCLREC49pysT5pvOkXwTCQ d7MBaN0if2k8kbQ7C0+QFlf915Yco84dgpmiGBrJAjIHWBwj/KFa/2L1WGmSvQ/iBh9m 8SPv3L623qtpAPYPhCT8KDf/qVCI0YqeXzNvM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687967633; x=1690559633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rgr2XhXt37wo7AQkYrdUQ0lXWAQPuARwonW63x/Kx6k=; b=L/2X1LMNgXh9KcH0Lstk4AwQtLZFI5ff/ltomJzxkO7Qpp0X0n42VhwozRVnv2lvZ7 2jgBtvU5hZSZShW/16Ma/DE3czf9oleqRlC6ZZcBb1u0xRjzSTCKwTBpw2dUCJi3D0ae OqDEuhgFDsm5FjulgwSV5DqgvDrL6B2u68Q8h7lNR9+bM5lqgCG2rscK+zEBVzVJNptE H1824Vy1zvk9mMscMEEUxULwuAbyaKAluN70soZiqvl48NNUrhzhuYQfQ15BXo9UCbIN aJqjdYnzqHZz2NHnXtF5oZqIi5t/17u1QupMPqC/pPCHATS/HrpZBWyj/KmmiRwNxSL9 LENw==
X-Gm-Message-State: AC+VfDxSqVesNEIRF28Fz/BDpQdNoTu3ZKVq54YubumqzOcqJNxdfFEP 7vzK5fV8V3zhlz2he7GBzVQvB9tR5o1bPPzx1OY=
X-Google-Smtp-Source: ACHHUZ7FElTIFk8BZJ/TxWePiYJlZz2HvI/HnuWmdqki8o5qzhBcqDI66Odcvj2fxlYpcrRgEtTRmg==
X-Received: by 2002:a17:906:8a4a:b0:991:c842:2ca2 with SMTP id gx10-20020a1709068a4a00b00991c8422ca2mr6138068ejc.15.1687967632856; Wed, 28 Jun 2023 08:53:52 -0700 (PDT)
Received: from snel ([2a10:3781:276:1:16f6:d8ff:fe47:2eb7]) by smtp.gmail.com with ESMTPSA id t14-20020a1709063e4e00b0098d25cbb899sm5781218eji.41.2023.06.28.08.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 08:53:52 -0700 (PDT)
Date: Wed, 28 Jun 2023 17:53:50 +0200
From: Job Snijders <job@fastly.com>
To: Martin Hoffmann <martin@nlnetlabs.nl>
Cc: sidrops@ietf.org
Message-ID: <ZJxXjg1NNdgVRP50@snel>
References: <168621843689.33017.6897451444105786551@ietfa.amsl.com> <ZIGogKIH4Srb8Nxt@snel> <20230628173307.29fefec2@glaurung.nlnetlabs.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230628173307.29fefec2@glaurung.nlnetlabs.nl>
X-Clacks-Overhead: GNU Terry Pratchett
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidrops/cixq7k0TDIOyg_h03sTtQy6FkGk>
Subject: Re: [Sidrops] I-D Action: draft-ietf-sidrops-aspa-profile-15.txt
X-BeenThere: sidrops@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: A list for the SIDR Operations WG <sidrops.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidrops>, <mailto:sidrops-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidrops/>
List-Post: <mailto:sidrops@ietf.org>
List-Help: <mailto:sidrops-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidrops>, <mailto:sidrops-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jun 2023 15:53:59 -0000

Dear Martin,

On Wed, Jun 28, 2023 at 05:33:07PM +0200, Martin Hoffmann wrote:
> Job Snijders wrote:
> > The internet-draft changes is best viewed by comparing -13 and -15:
> > https://author-tools.ietf.org/iddiff?url1=draft-ietf-sidrops-aspa-profile-13&url2=draft-ietf-sidrops-aspa-profile-15
> > 
> > An example object is available here:
> > rsync://chloe.sobornost.net/rpki/RIPE-nljobsnijders/5m80fwYws_3FiFD7JiQjAqZ1RYQ.asa
> 
> I think that object as well as the example object in the draft are not
> actually correct according to the ASN.1 module definition in the draft.
> 
> The module is opened with
> 
> | DEFINITIONS IMPLICIT TAGS ::=
> 
> and the version field is defined as
> 
> | version [0]   INTEGER DEFAULT 0,
> 
> This means the version should use an implicit tag whereas the objects
> use an explicit tag:
> 
> |    [0] (1 elem)
> |       INTEGER 1
> 
> (and implicit tag would be:
> 
> |    [0] (1 byte) 01
> 
> I _think_ this is an error in the module definitions. All X.509 and
> CMS modules seem to use explicit tags for their version fields.

I think you are right. Thank you for pointing this out!

This error has been with us since aspa-profile-08 (July 2022)

I fixed it: https://github.com/QratorLabs/ASPA/commit/8975d62a3d1809ae160503dd8d5cd1e8d225b5ca

> While we are at it, I would like to again raise the suggestion to not
> use a version 1 here but rather stick to 0 and use a different content
> type OID. The older and newer definitions are not compatible, so a new
> OID feels more appropriate than a version change.

I can see your argument, but I'm not sure there is clear consensus to
request a fresh content-type OID, and there are counter-arguments too.

In the past the ASPA profile definition has been updated without
cranking the version or content-type OID. Some argue we are in a phase
of 'experimentation' (since the internet-draft isn't published as RFC),
where some incompatibility with older revisions of the draft is to be
expected and of no concern.

I personally expect all the 'v0 ASPA' objects to disappear before the
end of the year, and this internet-draft is probably heading into RFC
editor in 2024.

I'd appreciate more feedback from the working group on this matter.

Kind regards,

Job