Re: [sipcore] Eric Rescorla's Discuss on draft-ietf-sipcore-sip-push-21: (with DISCUSS and COMMENT) - the COMMENT issues

Ben Campbell <ben@nostrum.com> Tue, 08 January 2019 21:19 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF13E12D84C for <sipcore@ietfa.amsl.com>; Tue, 8 Jan 2019 13:19:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.678
X-Spam-Level:
X-Spam-Status: No, score=-1.678 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N0kU4i-gD1-Q for <sipcore@ietfa.amsl.com>; Tue, 8 Jan 2019 13:19:10 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F1A55124D68 for <sipcore@ietf.org>; Tue, 8 Jan 2019 13:19:09 -0800 (PST)
Received: from [10.0.1.45] (cpe-70-122-203-106.tx.res.rr.com [70.122.203.106]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id x08LJ5WI039156 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 8 Jan 2019 15:19:06 -0600 (CST) (envelope-from ben@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1546982348; bh=/xwNSRYebuBcsZi9BjAl4ouTbXuy1JYJJmYP8hJBKZ0=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=D8hEcqEv9o9L54CSYoKJt+/4p+JCBq8z4AvtH78XMLZ2QtyR5l/Dn8nNnTyzxDtUH uMz/FpOET7H3KmdiZhvcKocBjPO8oODW9s5i2Huvt4/jOdHTYAcpurT8NRNlGyenqd v7fi3nmH7TTCQt8jmXSHj5nRTw4ybBSt+aJtdNhc=
X-Authentication-Warning: raven.nostrum.com: Host cpe-70-122-203-106.tx.res.rr.com [70.122.203.106] claimed to be [10.0.1.45]
From: Ben Campbell <ben@nostrum.com>
Message-Id: <2F7C1069-7647-41BA-9E4C-5448CCC8DA83@nostrum.com>
Content-Type: multipart/signed; boundary="Apple-Mail=_AF7FDA09-8176-4D1A-AABC-A9A6912EC64C"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Date: Tue, 08 Jan 2019 15:19:04 -0600
In-Reply-To: <CABcZeBPQTxcMxSmAdtd6JdGyfq8zGWuK9ZZO22SwdKX7RzSJdA@mail.gmail.com>
Cc: "sipcore-chairs@ietf.org" <sipcore-chairs@ietf.org>, "sipcore@ietf.org" <sipcore@ietf.org>, "draft-ietf-sipcore-sip-push@ietf.org" <draft-ietf-sipcore-sip-push@ietf.org>, The IESG <iesg@ietf.org>, "br@brianrosen.net" <br@brianrosen.net>
To: Eric Rescorla <ekr@rtfm.com>, Christer Holmberg <christer.holmberg@ericsson.com>
References: <154681733718.17024.3190954246737206843.idtracker@ietfa.amsl.com> <HE1PR07MB31611EECBA89EF1FC46D756C93890@HE1PR07MB3161.eurprd07.prod.outlook.com> <CABcZeBPQTxcMxSmAdtd6JdGyfq8zGWuK9ZZO22SwdKX7RzSJdA@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.102.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/PieJf0_FxFJBg8JWA6F-C1Dg7zc>
Subject: Re: [sipcore] Eric Rescorla's Discuss on draft-ietf-sipcore-sip-push-21: (with DISCUSS and COMMENT) - the COMMENT issues
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 21:19:12 -0000


> On Jan 7, 2019, at 8:08 AM, Eric Rescorla <ekr@rtfm.com> wrote:
> 
> In this reply I will address the COMMENT issues:
> 
> >This document is very badly in need of editorial work for readability.
> >I would urge the responsible AD to make one.
> 
> I have done quite a bit of editorial work based on WGLC/AD comments etc. I am happy to improve it even further, but someone needs to guide me what to do.
> 
> Ben?
> 

For the record, this has already undergone a number of revisions due to editorial review in the WG and during AD evaluation. I agree it’s not ideal, but I think most of it can be understood. I fear we’ve already reached the point of diminishing returns regarding to stylistic issues.

That being said, there are some areas that would still be worthwhile to improve before this goes to the RFC editor.  I think the places where Ekr pointed out readability issues mostly deal with nested conditional statements in prose. Those should generally be avoided whenever possible;. They take a lot of effort for humans to read and comprehend.

This is especially true for center-imbedded conditions, e.g. “When you receive a  FOO request, if the request contains BAR, do BAZ.”  That would be more readable constructed as  “When you receive a FOO request that contains BAR, do BAZ.”  It often helps to break more complex procedures into steps.

Long sentences with multiple commas are often clues for this sort of issue.

Thanks,

Ben.