Re: [Softwires] Gen-ART review of draft-ietf-softwire-hs-framework-l2tpv2-10

Carlos Pignataro <cpignata@cisco.com> Wed, 10 December 2008 19:15 UTC

Return-Path: <softwires-bounces@ietf.org>
X-Original-To: softwires-archive@megatron.ietf.org
Delivered-To: ietfarch-softwires-archive@core3.amsl.com
Received: from [127.0.0.1] (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 77E023A69EF; Wed, 10 Dec 2008 11:15:03 -0800 (PST)
X-Original-To: softwires@core3.amsl.com
Delivered-To: softwires@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 86D7628C0E0; Wed, 10 Dec 2008 11:04:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.199
X-Spam-Level:
X-Spam-Status: No, score=-6.199 tagged_above=-999 required=5 tests=[AWL=0.400, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w5YKmC22FcZX; Wed, 10 Dec 2008 11:04:25 -0800 (PST)
Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198]) by core3.amsl.com (Postfix) with ESMTP id 7D76128C0DF; Wed, 10 Dec 2008 11:04:25 -0800 (PST)
X-TACSUNS: Virus Scanned
Received: from rooster.cisco.com (localhost.cisco.com [127.0.0.1]) by av-tac-rtp.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id mBAJ4Bk3022049; Wed, 10 Dec 2008 14:04:11 -0500 (EST)
Received: from [64.102.201.16] (dhcp-64-102-201-16.cisco.com [64.102.201.16]) by rooster.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id mBAJ3r1d006557; Wed, 10 Dec 2008 14:03:53 -0500 (EST)
Message-ID: <49401299.4010203@cisco.com>
Date: Wed, 10 Dec 2008 14:03:53 -0500
From: Carlos Pignataro <cpignata@cisco.com>
Organization: cisco Systems, Inc.
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18) Gecko/20081105 Thunderbird/2.0.0.18 Mnenhy/0.7.5.0
MIME-Version: 1.0
To: Black_David@emc.com
References: <9FA859626025B64FBC2AF149D97C944A01074B3E@CORPUSMX80A.corp.emc.com>
In-Reply-To: <9FA859626025B64FBC2AF149D97C944A01074B3E@CORPUSMX80A.corp.emc.com>
X-Enigmail-Version: 0.95.7
X-Face: *3w8NvnQ|kS~V{&{U}$?G9U9EJQ8p9)O[1[1F'1i>XIc$5FR!hdAIf5}'Xu-3`^Z']h0J* ccB'fl/XJYR[+,Z+jj`4%06nd'y9[ln&ScJT5S+O18e^
X-Mailman-Approved-At: Wed, 10 Dec 2008 11:15:01 -0800
Cc: gen-art@ietf.org, bruno.stevant@telecom-bretagne.eu, softwires@ietf.org
Subject: Re: [Softwires] Gen-ART review of draft-ietf-softwire-hs-framework-l2tpv2-10
X-BeenThere: softwires@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: softwires wg discussion list <softwires.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/pipermail/softwires>
List-Post: <mailto:softwires@ietf.org>
List-Help: <mailto:softwires-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/softwires>, <mailto:softwires-request@ietf.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: softwires-bounces@ietf.org
Errors-To: softwires-bounces@ietf.org

David,

Thanks much for taking the time to read the draft and for providing this
feedback! This is an Ack, we'll reply later, with answers/text to
address these open issues.

Thanks,

--Carlos.

On 12/10/2008 11:47 AM, Black_David@emc.com said the following:
> I have been selected as the General Area Review Team (Gen-ART) 
> reviewer for this draft (for background on Gen-ART, please see 
> http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).
> Please resolve these comments along with any other Last Call
> comments  you may receive.
> 
> Document: draft-ietf-softwire-hs-framework-l2tpv2-10
> Reviewer: David L. Black
> Review Date: December 10, 2008
> IETF LC End Date: December 15, 2008
> 
> Summary:
> This draft is on the right track, but has open issues, described
> in the review.
> 
> Comments:
> 
> The draft is well-written, with a lot of details that will be
> valuable to implementers.  I have two open issues:
> 
> (1) Section 5.1 of this draft is clearly defining a softwire
> profile of L2TPv2 in that it states extensive requirements
> on AVP usage (and AVP contents in some cases) for softwires.
> Use of this profile is not explicitly signaled - the
> expectation is that both the SI and SC will be implemented
> in accordance with this draft, and won't try to communicate
> with L2TPv2 implementations that aren't using this profile.
> As the requirements of this softwire profile appear to differ
> from RFC 2661, defining an AVP to signal use of this profile
> seems like a good idea (its use should be required).
> 
> (2) This is more of a minor annoyance than an open issue, but
> it does need attention.  This draft uses UDP as part of an
> IP-in-IP tunnel, so the UDP guidelines in RFC 5405 apply.
> Note that Section 3.1.3 of RFC 5405 indicates that no
> additional congestion control is required for this scenario
> beyond what is already done for the IP traffic carried through
> the tunnel.  That should be noted in this draft, and RFC 5405
> should be scanned for any other considerations that may apply
> to this draft.
> 
> Everything else I found is relatively minor:
> - Please add CPE and LNS to the abbreviations section.
> - Most of the text after the figure in each of Sections 3.1.1
> 	through 3.1.4 is common.  Consider factoring it out into
> 	one location.  Ditto for 3.2.1 to 3.2.4.  It's fine to
> 	not do this if the result would be difficult to follow.
> - In Section 5.1.1.3, please clarify that the "SHOULD NOT send"
> 	requirement applies only to AVPs not covered in sections
> 	5.1.1, 5.1.1.1 and 5.1.1.2 .
> - I found a number of lower case instances of "must", "should"
> 	and "may" that are candidates for upper case (i.e.,
>  	RFC 2119 usage).  Please check all of these and upper case
> 	as appropriate.
> - Please expand the ULA acronym on its first use in Section
> 	6.1.1 .
> 
> Thanks,
> --David
> ----------------------------------------------------
> David L. Black, Distinguished Engineer
> EMC Corporation, 176 South St., Hopkinton, MA  01748
> +1 (508) 293-7953             FAX: +1 (508) 293-7786
> black_david@emc.com        Mobile: +1 (978) 394-7754
> ----------------------------------------------------
> 

-- 
--Carlos Pignataro.
Escalation RTP - cisco Systems
_______________________________________________
Softwires mailing list
Softwires@ietf.org
https://www.ietf.org/mailman/listinfo/softwires