Re: [straw] AD review of draft-ietf-straw-b2bua-loop-detection-04

Hadriel Kaplan <hadriel.kaplan@oracle.com> Fri, 11 April 2014 18:08 UTC

Return-Path: <hadriel.kaplan@oracle.com>
X-Original-To: straw@ietfa.amsl.com
Delivered-To: straw@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AAF5F1A073B for <straw@ietfa.amsl.com>; Fri, 11 Apr 2014 11:08:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.473
X-Spam-Level:
X-Spam-Status: No, score=-4.473 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.272, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hMnwJJtvH89U for <straw@ietfa.amsl.com>; Fri, 11 Apr 2014 11:08:07 -0700 (PDT)
Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by ietfa.amsl.com (Postfix) with ESMTP id 3F7591A072E for <straw@ietf.org>; Fri, 11 Apr 2014 11:08:04 -0700 (PDT)
Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s3BI82uS023037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 Apr 2014 18:08:02 GMT
Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s3BI81Xx014493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 11 Apr 2014 18:08:02 GMT
Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s3BI81Fj006064; Fri, 11 Apr 2014 18:08:01 GMT
Received: from [10.0.1.10] (/66.31.4.61) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 11 Apr 2014 11:08:01 -0700
Content-Type: text/plain; charset="iso-8859-1"
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
From: Hadriel Kaplan <hadriel.kaplan@oracle.com>
In-Reply-To: <CAL02cgRsQ_fnN5pHqPRoUBJybcVZKPrSj9J32DUd_QAndkA+pg@mail.gmail.com>
Date: Fri, 11 Apr 2014 14:08:00 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <275BE153-D79E-475D-9653-19B2FFE81154@oracle.com>
References: <CAL02cgRsQ_fnN5pHqPRoUBJybcVZKPrSj9J32DUd_QAndkA+pg@mail.gmail.com>
To: Richard Barnes <rlb@ipv.sx>
X-Mailer: Apple Mail (2.1874)
X-Source-IP: ucsinet22.oracle.com [156.151.31.94]
Archived-At: http://mailarchive.ietf.org/arch/msg/straw/wdPNDkX4u7gJrNATzZBV-56fCQU
Cc: draft-ietf-straw-b2bua-loop-detection@tools.ietf.org, straw@ietf.org
Subject: Re: [straw] AD review of draft-ietf-straw-b2bua-loop-detection-04
X-BeenThere: straw@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Sip Traversal Required for Applications to Work \(STRAW\) working group discussion list" <straw.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/straw>, <mailto:straw-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/straw/>
List-Post: <mailto:straw@ietf.org>
List-Help: <mailto:straw-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/straw>, <mailto:straw-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Apr 2014 18:08:09 -0000

On Apr 11, 2014, at 1:40 PM, Richard Barnes <rlb@ipv.sx> wrote:

> I have reviewed this document in preparation for IETF LC.  Overall, it looks good to me; I have requested LC.  One editorial nit and one comment below. 
> 
> Thanks,
> --Richard
> 
> In Section 5, the antecedent of "which SHOULD be 70" appears to be the generated Max-Forwards header, so this doesn't really parse.  "The value for this header field SHOULD be 70..." 

You're right: that is an nit. :)
I think it's understandable, though a bit odd yes.

Can the RFC Editor change it?


> In the security considerations, you mention resetting the Max-* headers. Is there a way this could be done that is compatible with the goals of this doc?  E.g., setting any random value for Max-Forwards, as long as it's lower than what came in?  Allowing something like this could bring more proxies into conformance with the overall objective of this document. 

I'd rather ask that up for WG consensus I think.

Personally I'd rather not advocate any form of randomized modification.  My employer's products can do it if configured to (most other SBCs can too I assume), but it's a good way to get failed calls. You have to pick a random decrement number in some range, and the range can't be too small or it's worthless to do... but if the range is big, then crossing multiple SBCs and B2BUAs will quickly get it to 0 before it reaches the target.

In some real-world call flows the SIP request crosses a surprising number of SIP hops. Even just decrementing by 1 people have reached the hop limit (though that was with a starting Max-Forwards of 40 if I recall correctly, but still...).

And that's not to mention how hard it is to troubleshoot if some hop in the middle decrements by random values. And it would make the trace route mechanism have inconsistent behavior to the user.

So personally I'd vote no - either the SIP device follows this RFC and decrements by 1, or they don't comply with the RFC.  Nice and binary. :)

-hadriel