[straw] AD review of draft-ietf-straw-b2bua-loop-detection-04

Richard Barnes <rlb@ipv.sx> Fri, 11 April 2014 17:40 UTC

Return-Path: <rlb@ipv.sx>
X-Original-To: straw@ietfa.amsl.com
Delivered-To: straw@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53A2C1A0724 for <straw@ietfa.amsl.com>; Fri, 11 Apr 2014 10:40:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.977
X-Spam-Level:
X-Spam-Status: No, score=-1.977 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jFXRkVjGhqYY for <straw@ietfa.amsl.com>; Fri, 11 Apr 2014 10:40:54 -0700 (PDT)
Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by ietfa.amsl.com (Postfix) with ESMTP id 66BBB1A0728 for <straw@ietf.org>; Fri, 11 Apr 2014 10:40:54 -0700 (PDT)
Received: by mail-ob0-f173.google.com with SMTP id gq1so6381788obb.4 for <straw@ietf.org>; Fri, 11 Apr 2014 10:40:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=PHMlFoMPGmXIVdlvckgQt0u3hP4+LKEwkaHPBP5SNuM=; b=dpFxXRzWP335YtU1l3qLGNqXXMpF0mHhbucMQQgR5N/6pmRqRUEs4zqyn6Yn6E4NSC aqIckVZ0rFJ2irJj+3rfcIvvg+5b9zFVA0aMALT1TOaBfoAr2R/krwDuPSYjwKR79K8c ZcQskflSlzu2biwil/Qbhd4HmS8ipM/5o+e590ap3SHCWlKuGBOE+NocNCcqXl0XPYUk 1swvxHflhOlNGO58llmYN+fdd444rWLO26/fSW5/WtBUk9827a2I9IlAr/F8t9EXxCl+ Pai3YZmZL3S+EnviZosSik/mfsWca+uOGV7N12HSMxiJb+FG3CcJqcp50Od0m053H3W/ U23Q==
X-Gm-Message-State: ALoCoQl/uPlH2HVNRTgkBUQ7kE3ndoCmA3c7974WuZOKGiqSUVCz1L2pGmD+EIyQdNePChOGkfpc
MIME-Version: 1.0
X-Received: by 10.182.28.195 with SMTP id d3mr20724198obh.19.1397238053014; Fri, 11 Apr 2014 10:40:53 -0700 (PDT)
Received: by 10.60.136.231 with HTTP; Fri, 11 Apr 2014 10:40:52 -0700 (PDT)
Date: Fri, 11 Apr 2014 13:40:52 -0400
Message-ID: <CAL02cgRsQ_fnN5pHqPRoUBJybcVZKPrSj9J32DUd_QAndkA+pg@mail.gmail.com>
From: Richard Barnes <rlb@ipv.sx>
To: draft-ietf-straw-b2bua-loop-detection@tools.ietf.org, straw@ietf.org
Content-Type: multipart/alternative; boundary="001a11c2cd18d1243a04f6c7d540"
Archived-At: http://mailarchive.ietf.org/arch/msg/straw/9amh0LcH1L6pp-30elOdF3oCndg
Subject: [straw] AD review of draft-ietf-straw-b2bua-loop-detection-04
X-BeenThere: straw@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Sip Traversal Required for Applications to Work \(STRAW\) working group discussion list" <straw.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/straw>, <mailto:straw-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/straw/>
List-Post: <mailto:straw@ietf.org>
List-Help: <mailto:straw-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/straw>, <mailto:straw-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Apr 2014 17:40:55 -0000

I have reviewed this document in preparation for IETF LC.  Overall, it
looks good to me; I have requested LC.  One editorial nit and one comment
below.

Thanks,
--Richard

In Section 5, the antecedent of "which SHOULD be 70" appears to be the
generated Max-Forwards header, so this doesn't really parse.  "The value
for this header field SHOULD be 70..."

In the security considerations, you mention resetting the Max-* headers. Is
there a way this could be done that is compatible with the goals of this
doc?  E.g., setting any random value for Max-Forwards, as long as it's
lower than what came in?  Allowing something like this could bring more
proxies into conformance with the overall objective of this document.