RE: [tcpm] Re: draft-ietf-tcpm-tcp-uto-05

"Anantha Ramaiah \(ananth\)" <ananth@cisco.com> Wed, 30 May 2007 19:02 UTC

Return-path: <tcpm-bounces@ietf.org>
Received: from [127.0.0.1] (helo=stiedprmman1.va.neustar.com) by megatron.ietf.org with esmtp (Exim 4.43) id 1HtTQu-0001pO-Bf; Wed, 30 May 2007 15:02:08 -0400
Received: from [10.91.34.44] (helo=ietf-mx.ietf.org) by megatron.ietf.org with esmtp (Exim 4.43) id 1HtTQs-0001pJ-Tr for tcpm@ietf.org; Wed, 30 May 2007 15:02:06 -0400
Received: from sj-iport-6.cisco.com ([171.71.176.117]) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1HtTQs-0001AC-G6 for tcpm@ietf.org; Wed, 30 May 2007 15:02:06 -0400
Received: from sj-dkim-2.cisco.com ([171.71.179.186]) by sj-iport-6.cisco.com with ESMTP; 30 May 2007 12:02:06 -0700
X-IronPort-AV: i="4.14,594,1170662400"; d="scan'208"; a="156501578:sNHT73823823"
Received: from sj-core-5.cisco.com (sj-core-5.cisco.com [171.71.177.238]) by sj-dkim-2.cisco.com (8.12.11/8.12.11) with ESMTP id l4UJ25xE009204; Wed, 30 May 2007 12:02:05 -0700
Received: from xbh-sjc-221.amer.cisco.com (xbh-sjc-221.cisco.com [128.107.191.63]) by sj-core-5.cisco.com (8.12.10/8.12.6) with ESMTP id l4UJ25tV016260; Wed, 30 May 2007 19:02:05 GMT
Received: from xmb-sjc-21c.amer.cisco.com ([171.70.151.176]) by xbh-sjc-221.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Wed, 30 May 2007 12:02:05 -0700
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [tcpm] Re: draft-ietf-tcpm-tcp-uto-05
Date: Wed, 30 May 2007 12:02:02 -0700
Message-ID: <0C53DCFB700D144284A584F54711EC58036BF0B6@xmb-sjc-21c.amer.cisco.com>
In-Reply-To: <8F01E60D-5498-4A5A-A23C-03C615EC2A17@nokia.com>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: [tcpm] Re: draft-ietf-tcpm-tcp-uto-05
Thread-Index: AceijNNKDAfTg4o3SpeqTAltJJPoSgAVkbzQ
From: "Anantha Ramaiah (ananth)" <ananth@cisco.com>
To: Lars Eggert <lars.eggert@nokia.com>, ext Alfred HÎnes <ah@tr-sys.de>
X-OriginalArrivalTime: 30 May 2007 19:02:05.0450 (UTC) FILETIME=[03969EA0:01C7A2ED]
DKIM-Signature: v=0.5; a=rsa-sha256; q=dns/txt; l=4219; t=1180551725; x=1181415725; c=relaxed/simple; s=sjdkim2002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=ananth@cisco.com; z=From:=20=22Anantha=20Ramaiah=20\(ananth\)=22=20<ananth@cisco.com> |Subject:=20RE=3A=20[tcpm]=20Re=3A=20draft-ietf-tcpm-tcp-uto-05 |Sender:=20; bh=+3Yd9mg00WW4pA8AJCqbJV0TX8VhDW9zvlIgXlnCFG4=; b=iKya3xXfT5e+pMiEFpXa/tKTG+0luDx5I4LtkOllHKCNX957MVARwv37eQ7BJ4T88khAFb5c djThsibArJX6G08S6t/TlguF/rMZMGAn0wKuraiIplPGILVPHxjK216I;
Authentication-Results: sj-dkim-2; header.From=ananth@cisco.com; dkim=pass ( sig from cisco.com/sjdkim2002 verified; );
X-Spam-Score: 0.0 (/)
X-Scan-Signature: 825e642946eda55cd9bc654a36dab8c2
Cc: tcpm@ietf.org, ext Fernando Gont <fernando@gont.com.ar>
X-BeenThere: tcpm@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: TCP Maintenance and Minor Extensions Working Group <tcpm.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=unsubscribe>
List-Post: <mailto:tcpm@ietf.org>
List-Help: <mailto:tcpm-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/tcpm>, <mailto:tcpm-request@ietf.org?subject=subscribe>
Errors-To: tcpm-bounces@ietf.org

 

> -----Original Message-----
> From: Lars Eggert [mailto:lars.eggert@nokia.com] 
> Sent: Wednesday, May 30, 2007 12:32 AM
> To: ext Alfred HÎnes
> Cc: tcpm@ietf.org; ext Fernando Gont
> Subject: [tcpm] Re: draft-ietf-tcpm-tcp-uto-05
> 
> > (1)
> >
> > Yet, as an aid to implementors, I suggest to use more 
> specific names 
> > that can be easily carried over unchanged into 
> implementations and/or 
> > APIs without danger of name collisions; to be constructive, 
> I suggest:
> >
> >    ENABLED     -->  TCP_USE_UTO
> >
> >    CHANGEABLE  -->  TCP_ACCEPT_UTO
> >
> > and, to achieve more generic naming, also:
> >
> >    LOCAL_UTO   -->  TCP_LOCAL_UTO
> >
> > For the same reasons it might be useful to change the names of the 
> > configuration variables in Section 3.1 as well, e.g.:
> >
> >    U_LIMIT    -->   TCP_UTO_MAX
> >
> >    L_LIMIT    -->   TCP_UTO_MIN
> 
> This has been suggested before, but I think it was in an 
> off-list email.

Hmm.. The current email, (I don't see Alfred's original email on the list) is off-list as well :-)

Anyways, I suggested the same thing which Alfred is mentioning above, here is the snippet of the email exchange (actually the last one, which hopefully captures the crux) :-

============================== BEGIN EMAIL EXCH. ===================================
-----Original Message-----
From: Anantha Ramaiah (ananth) 
Sent: Wednesday, May 16, 2007 5:23 PM
To: 'Fernando Gont'; mallman@icir.org
Cc: Lars Eggert; Ted Faber
Subject: RE: UTO draft. 

Fernando,
   No sweat. Just leave it as it is. From what I recall, the variable names weren't that long.. Anyways, I see that when you are writing the equations, it might tend to get split up into 2 lines.
  Also Lar's point about TCP_USER_TIMEOUT is well taken as well.. 
-Anantha  

> -----Original Message-----
> From: Fernando Gont [mailto:fernando@gont.com.ar]
> Sent: Tuesday, May 15, 2007 11:56 PM
> To: mallman@icir.org; Anantha Ramaiah (ananth)
> Cc: Lars Eggert; Ted Faber
> Subject: Re: UTO draft. 
> 
> Hi All,
> 
> One of Anantha's comments suggested to precede all variables with the 
> prefix "UTO_". I was meaning to commit the change.
> But it turns out that it results in the names of the variables being 
> terribly long, the recommended formula spanning more than one row, 
> etc.
> 
> So, unless anybody feels strong about committing this change (please 
> speak up), I will not commit it.
> 
> As pointed out by Lars, implementations are free to do this type of 
> thing internally.  (And, after all, TCP's timeout is not named 
> "TCP_USER_TIMEOUT"... and the same is true for the name of virtually 
> all variables/constants).
> 
> Thanks,
> 
> --
> Fernando Gont

=========================== END EMAIL EXCH. ================================

> 
> Implementors are free to choose whatever variable names they 
> like for their implementation - there is no expectation that 
> these names will be used as-is. For example, RFC2581 and 
> RFC2988 define similar state variables, for which 
> implementations also choose different names.

True.. But the point is to try to use some intuitive names, you don't want to chose something slike X Y Z etc., I am not saying that you have done so, simply trying to be argumentative since, IMO the above argument does seem to make sense. :-) But your other points are well taken.

> 
> For this reason I'm unconvinced that renaming the state 
> variables is necessary. (At the very least, I wouldn't want 
> to add the "TCP_"  
> prefix. If the WG thinks some of the other name changes 
> clarify things, I could be convinced to go with it.)

Sure that is a good plan of action, leave it to the consensus of the WG. Anyways it is a minor thing, so no big deal, really.

-Anantha

_______________________________________________
tcpm mailing list
tcpm@ietf.org
https://www1.ietf.org/mailman/listinfo/tcpm