Re: [tcpm] [GROW] How to reuse the tcp model in the BMP model - asking for suggestions

["Scharf, Michael" <[e-mail]>]

Hi Jeff,

The authors have published version -08 to address feedback from various reviewers, including your one.

As you can see at the page https://www.ietf.org/rfcdiff?url2=draft-ietf-tcpm-yang-tcp-08, we added a typedef for MSS and leafs for MSS and PMTUD. Please review this change and let us know if this works for you.

We have _not_ added further nodes, as the use case is not clear and there has been no specific suggestion how the draft should be updated. As mentioned before, this document does not try to comprehensively model all potential parameters of a TCP stack.

Thanks

Michael


From: Jeffrey Haas <[e-mail]>
Sent: Tuesday, August 23, 2022 9:47 PM
To: Mahesh Jethanandani <[e-mail]>
Cc: Scharf, Michael <[e-mail]>; Camilo Cardona <[e-mail]>; [e-mail]; [e-mail]; [e-mail]; [e-mail]
Subject: Re: [GROW] How to reuse the tcp model in the BMP model - asking for suggestions

Mahesh,


On Aug 23, 2022, at 3:03 PM, Mahesh Jethanandani <[e-mail]<mailto:[e-mail]>> wrote:

In addition, I have now also checked the OpenConfig YANG models, and they also have ways to set the MSS, for instance:

   leaf tcp-mss {
     type uint16;
     description
       "Sets the max segment size for BGP TCP sessions.";
   }

An example above, where a typedef for the uint16 might be helpful.

Not clear on why you would like to see a typedef rather than a definition for MSS node as suggested by Michael. Or did you mean to put a range for the MSS value?

For individual instances implementing the MSS, you'll want a leaf.

The purpose of a typedef is having each of the places where MSS configuration or operational state is used have a consistent type/constraint and perhaps pointer into the TCP specs.

That way, as a theoretical example, you don't define MSS in one model as uint16 and another as uint32 with a range restriction - which might be how someone's implementation does it.

-- Jeff