Re: [Teas] FW: New Version Notification for draft-lee-teas-actn-pm-telemetry-autonomics-12.txt

Hi Tom,

Thanks for your interest in this draft and a good review for it. I really appreciate that. I think most of your comments are valid; please see inline for my response.

Please see the diff file:  https://www6.ietf.org/rfcdiff/?url2=draft-lee-teas-actn-pm-telemetry-autonomics-13  and let us know if there are still missing items.

Thanks & Best regards,

Young

-----Original Message-----

From: tom petch [mailto:ietfa@btconnect.com]

Sent: Friday, April 5, 2019 11:51 AM

To: Leeyoung <leeyoung@huawei.com>; TEAS WG Chairs <teas-chairs@ietf.org>

Cc: TEAS WG <teas@ietf.org>

Subject: Re: [Teas] FW: New Version Notification for draft-lee-teas-actn-pm-telemetry-autonomics-12.txt

----- Original Message -----

From: "Leeyoung" <leeyoung@huawei.com>

Sent: Tuesday, April 02, 2019 10:56 PM

> Hi Lou and Pavan,

>

> Following up the discussion from IETF 104 TEAS WG meeting, please find

the updated version of draft-lee-teas-actn-pm-telemetry-autonomics-12.

(See the attachment diff file).

>

> To recap:

>

> - The draft is "generalized" to be applicable in generic settings.

(See Abstract/Introduction)

> - Changes of modules: from ietf-actn-te-kpi-telemetry model to

ietf-vn-kpi-telemetry model.

> - Section 4 has been added (v.11) to explain what scaling in/out

mechanism is with illustration and a partial YANG tree.

>

> We believe all pending issues/comments have been incorporated in v12

and as such the draft is a good basis for WG adoption. Please let me know if you have any further comments.

Lee

I am confused.  I am looking at

  draft-lee-teas-actn-pm-telemetry-autonomics-12

In IANA Considerations you have

    URI: urn:ietf:params:xml:ns:yang:ietf-kpi-telemetry

when the namespace is

   "urn:ietf:params:xml:ns:yang:ietf-vn-kpi-telemetry";

and the prefix, which must be specified, is missing

In the list of prefix I see

      | te-kpi  | ietf-te-kpi-telemetry        | [This I-D]      |

      | vn-tel  | ietf-vn-kpi-telemetry        | [This I-D]      |

YL>> Thanks for the catch. I Corrected:

OLD: URI: urn:ietf:params:xml:ns:yang:ietf-kpi-telemetry

NEW: URI: urn:ietf:params:xml:ns:yang:ietf-vn-kpi-telemetry

7.1 has

  namespace "urn:ietf:params:xml:ns:yang:ietf-te-kpi-telemetry";

prefix te-tel;

7.2 has

  namespace "urn:ietf:params:xml:ns:yang:ietf-vn-kpi-telemetry";

  prefix actn-tel;

[perm any of 'actn' 'vn' 'te' 'kpi' 'tel' at random!]

YL>> actn -> vn; ‘te’ is te-tunnel so it is clear; kpi is key performance index, so it is clear. I would change actn-tel to vn-tel to be consistent with te-tel.

I do wonder about the choice of prefix. It seems to me that it is about KPI for VN and TE in which case, kpi-th- and kpi-vn seem clearer.  I have yet to see the minutes of the meeting so am not familiar with the discussion

YL>> I think te and vn are the base model to which these kpi modules are extended; thus, I think we would stick to  ietf-te-kpi-telemetry and ietf-vn-kpi-telemetry.

Also,

There are a lot of lines that are too long for an RFC

The YANG Modules lack version statement

YL>> Added version 1.1

The YANG modules lack Copyright statement

YL>> added.

The YANG module lack reference statements

YL>> There is no real external reference in this module.

The import statements lack reference clause

YL>> Added.

There is no reference back from the YANG module to the I-D/RFC to tell users where it came from where to find out more.

YL>> Since there is no real reference in the YANG module, there is no case for this.

Several of the Informative References look Normative e.g.

RFC6020 RFC7950 RFC8341RFC8309 RFC8233 RFC7926etc etc

YL>> Agreed and moved these to Normative except 8233 as it is already in the Normative.

The Security Considerations are out of date lacking RESTCONF, TLS, HTTPS

YL>> Added. Please see the section.

I suggest expanding VN in the Introduction; you do it in the Abstract and that is good but I, and some like me, skip straight to the Introduction.

YL>> Done.

Further on, I think that you need to expand SLA, BER - not sure about CAPEX/OPEX

YL>> Will do that in the next revision.

Tom Petch

p.s. if in doubt, blame your fellow authors:-)

> Thanks.

> Young (on behalf of other co-authors and contributors)

>

>

> -----Original Message-----

> From: internet-drafts@ietf.org [mailto:internet-drafts@ietf.org]

> Sent: Tuesday, April 2, 2019 4:43 PM

> To: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>; Satish

Karunanithi <satish.karunanithi@gmail.com>; Leeyoung <leeyoung@huawei.com>; Dhruv Dhody <dhruv.dhody@huawei.com>; Daniel King <d.king@lancaster.ac.uk>; Ricard Vilata <ricard.vilalta@cttc.es>; Ricard Vilalta <ricard.vilalta@cttc.es>

> Subject: New Version Notification for

draft-lee-teas-actn-pm-telemetry-autonomics-12.txt

>

>

> A new version of I-D,

draft-lee-teas-actn-pm-telemetry-autonomics-12.txt

> has been successfully submitted by Young Lee and posted to the IETF

repository.

>

> Name: draft-lee-teas-actn-pm-telemetry-autonomics

> Revision: 12

> Title: YANG models for VN & TE Performance Monitoring Telemetry and

Scaling Intent Autonomics

> Document date: 2019-04-02

> Group: Individual Submission

> Pages: 25

> URL:

https://www.ietf.org/internet-drafts/draft-lee-teas-actn-pm-telemetry-au

tonomics-12.txt

> Status:

https://datatracker.ietf.org/doc/draft-lee-teas-actn-pm-telemetry-autono

mics/

> Htmlized:

https://tools.ietf.org/html/draft-lee-teas-actn-pm-telemetry-autonomics-

12

> Htmlized:

https://datatracker.ietf.org/doc/html/draft-lee-teas-actn-pm-telemetry-a

utonomics

> Diff:

https://www.ietf.org/rfcdiff?url2=draft-lee-teas-actn-pm-telemetry-auton

omics-12

>

> Abstract:

>    This document provides YANG data models that describe performance

>    monitoring telemetry and scaling intent mechanism for TE-tunnels

and

>    Virtual Networks (VN).

>

>    The models presented in this draft allow customers to subscribe and

>    monitor their key performance data of their interest on the level

of

>    TE-tunnel or VN. The models also provide customers with the ability

>    to program autonomic scaling intent mechanism on the level of TE-

>    tunnel as well as VN.

>

>

>

>

>

>

> Please note that it may take a couple of minutes from the time of

submission until the htmlized version and diff are available at tools.ietf.org.

>

> The IETF Secretariat

>

>

------------------------------------------------------------------------

--------

> _______________________________________________

> Teas mailing list

> Teas@ietf.org

> https://www.ietf.org/mailman/listinfo/teas

>