Re: [Teas] Publication has been requested for draft-ietf-teas-gmpls-signaling-smp-07

Tom, Hi!

Thanks! It is not too late. The authors would have sufficient opportunities
to make improvements as it goes through the IESG processing stage.
The following suggested changes should address the comment on IANA
assignments.

Regards,
-Pavan

----
In Section 4:

**
OLD:
   When a lower priority protecting LSP is preempted, the intermediate
   node that performed preemption MUST send a Notify message with a new
   sub-code "Shared resources unavailable" under "Notify Error" code
   (see [RFC4872]) to the end nodes of that protecting LSP.

NEW:
   When a lower priority protecting LSP is preempted, the intermediate
   node that performed preemption MUST send a Notify message with error
   code "Notify Error" (25) (see [RFC4872]) and error sub-code "Shared
   resources unavailable" (TBA1) to the end nodes of that protecting LSP.

**

OLD:
   When the shared resources become available, a Notify message with a
   new sub-code "Shared resources available" under "Notify Error" code
   MUST be generated by the intermediate node.

NEW:
   When the shared resources become available, a Notify message with
   error code "Notify Error" (25) and error sub-code "Shared resources
   available" (TBA2) MUST be generated by the intermediate node.

**

In Section 6:

OLD:
   This document requests IANA to define two new sub-code values under
   "Notify Error" code in Resource Reservation Protocol (RSVP)
   parameters.

      Value        Description              Reference
      ----- ---------------------------- ---------------
      TBD1  Shared resources unavailable (this document)
      TBD2  Shared resources available   (this document)

NEW:
   IANA maintains a registry called "Resource Reservation Protocol
   (RSVP) Parameters" with a subregistry called "Error Codes and
   Globally-Defined Error Value Sub-Codes".  Within this subregistry
   there is a definition of the "Notify Error" error code (25).
   The definition lists a number of error value sub-codes that may be
   used with this error code.  IANA is requested to allocate further
   error value sub-codes for use with this error code as described in
   this document.

      Value        Description              Reference
      ----- ---------------------------- ---------------
      TBA1  Shared resources unavailable (this document)
      TBA2  Shared resources available   (this document)
**

On Fri, Jun 18, 2021 at 10:48 AM tom petch <ietfa@btconnect.com> wrote:

> From: Teas <teas-bounces@ietf.org> on behalf of Vishnu Beeram via
> Datatracker <noreply@ietf.org>
> Sent: 17 June 2021 06:55
>
> Vishnu Beeram has requested publication of
> draft-ietf-teas-gmpls-signaling-smp-07 as Proposed Standard on behalf of
> the TEAS working group.
>
> Please verify the document's state at
> https://datatracker.ietf.org/doc/draft-ietf-teas-gmpls-signaling-smp/
>
> <tp>
> Sigh late again or perhaps an early IETF Last Call comment.
>
> IANA allocates TBD1 and TBD2 which never appear in the body of the
> document.  There are references to new sub-codes which is where I think
> that TBD should also appear, for clarity.
>
> Also, they will not be new for long so I would drop the 'new' in that part
> of the text.
>
> And to remove all doubt I would spell out in IANA Considerations that the
> new allocations are for Sub-code 25 (Notify Error)  of the Error Code
> registry. (Or if not, then spell out where they are)!
>
> And, since the IETF has abolished the page number, I would suggest the use
> of subsections to break this up into referencable  parts of less than a
> page, as in
> the current section 4 which in my format is 2 1/2 pages long.
>
> Tom Petch
> _______________________________________________
> Teas mailing list
> Teas@ietf.org
> https://www.ietf.org/mailman/listinfo/teas
>
> _______________________________________________
> Teas mailing list
> Teas@ietf.org
> https://www.ietf.org/mailman/listinfo/teas
>