Re: [Teas] Secdir last call review of draft-ietf-teas-rfc3272bis-24

Adrian Farrel <adrian@olddog.co.uk> Sun, 09 July 2023 09:51 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: teas@ietfa.amsl.com
Delivered-To: teas@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2873C15198B; Sun, 9 Jul 2023 02:51:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.797
X-Spam-Level:
X-Spam-Status: No, score=-2.797 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=olddog.co.uk
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MTURYnaNvPv5; Sun, 9 Jul 2023 02:51:11 -0700 (PDT)
Received: from mta5.iomartmail.com (mta5.iomartmail.com [62.128.193.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ACC4DC151988; Sun, 9 Jul 2023 02:51:06 -0700 (PDT)
Received: from vs4.iomartmail.com (vs4.iomartmail.com [10.12.10.122]) by mta5.iomartmail.com (8.14.7/8.14.7) with ESMTP id 3699p4bo017528; Sun, 9 Jul 2023 10:51:04 +0100
Received: from vs4.iomartmail.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 00ACC4604A; Sun, 9 Jul 2023 10:51:04 +0100 (BST)
Received: from vs4.iomartmail.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E81A146043; Sun, 9 Jul 2023 10:51:03 +0100 (BST)
Received: from asmtp1.iomartmail.com (unknown [10.12.10.248]) by vs4.iomartmail.com (Postfix) with ESMTPS; Sun, 9 Jul 2023 10:51:03 +0100 (BST)
Received: from LAPTOPK7AS653V (82-69-109-75.dsl.in-addr.zen.co.uk [82.69.109.75]) (authenticated bits=0) by asmtp1.iomartmail.com (8.14.7/8.14.7) with ESMTP id 3699p36C028798 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 9 Jul 2023 10:51:03 +0100
Reply-To: adrian@olddog.co.uk
From: Adrian Farrel <adrian@olddog.co.uk>
To: 'Shawn Emery' <shawn.emery@gmail.com>, secdir@ietf.org
Cc: draft-ietf-teas-rfc3272bis.all@ietf.org, last-call@ietf.org, teas@ietf.org
References: <168888103088.52836.7750865099878917689@ietfa.amsl.com>
In-Reply-To: <168888103088.52836.7750865099878917689@ietfa.amsl.com>
Date: Sun, 09 Jul 2023 10:51:03 +0100
Organization: Old Dog Consulting
Message-ID: <075301d9b24a$dfe2b140$9fa813c0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQEuB6ijCb4x8Qrx1G5cF/ELZVTqQ7EIhWYg
Content-Language: en-gb
X-Originating-IP: 82.69.109.75
X-Thinkmail-Auth: adrian@olddog.co.uk
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=olddog.co.uk; h=reply-to :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type:content-transfer-encoding; s= 20221128; bh=Fmk9nTVmJ/cQBcrvN+RBIESdykibgiJk0VojKIEMHMI=; b=kzN 6RkdbA2+mpQDmhr7AtMLjpR3HHaFry9Q7pQCgENeT+mvakw+jQTsKwKIS7cvC6qx 6jBwqqW6YOTFAZbCoPArtZh8OUAWcUnt5La7x7v95ab+wvI+zIK4IIFbjKo+NDDN OlwFTgHRsFAHh7AFty1DNE39l+9FM1wOVSQdQay4pe5OBzXPAjNkclAAHqs+tLku GcZJVI9UQWi+NJ8YM6c0EDfmxrl/J/jzXv5JqSzbLgGSSPhY2G7munQXZWpu6zAd qsbXiCPMHr4N4QQMH/0I5bf3ItP6+R0E+YvPFrIcZQNtkC+6FKTSQJjLDrrCq7xD SWWJ2cYUJLHsg3WOsCg==
X-TM-AS-GCONF: 00
X-TM-AS-Product-Ver: IMSVA-9.1.0.2090-9.0.0.1002-27740.006
X-TM-AS-Result: No--15.083-10.0-31-10
X-imss-scan-details: No--15.083-10.0-31-10
X-TMASE-Version: IMSVA-9.1.0.2090-9.0.1002-27740.006
X-TMASE-Result: 10--15.083000-10.000000
X-TMASE-MatchedRID: UuaOI1zLN1jxIbpQ8BhdbIdlc1JaOB1TkYC3rjkUXRLDZ+9HI5nLbKgn 3iJRLHFOrpyextBSI2uIjav40gPMxfKFri4StE39QQ5+hY6u+47g8xL52+Q8269HqKgFlQDKY87 NwWBxSvjELD1QURUZjW8ZIPivHHwUZap8N+M9om/cgUVP3Cp+vVr2hZxjCLzqt9gi5mw5DSy+M3 06Ro3W2vx32uhhRuTVCZ8We40Uz+MDestCeTmeYnTzPL3sqyAmvhf/zJ92tsMDBQ+XBh4YJfOUx yLn8gXtd47oGPR9ibzHZ8+jv0CzYDLX4GFiNk2Rx7L94BGnWsTUoMiU4Mi75ZgPdbangN6pF/BD 5ICudJB7vlrY0EY85Ib7KsdfmhP2XHEPHmpuRH2DGx/OQ1GV8is3zPQeiEbe+gtHj7OwNO0CpgE TeT0ynA==
X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0
Archived-At: <https://mailarchive.ietf.org/arch/msg/teas/k-oBTty7A6FaT52qi3SRvyYsBNw>
Subject: Re: [Teas] Secdir last call review of draft-ietf-teas-rfc3272bis-24
X-BeenThere: teas@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Traffic Engineering Architecture and Signaling working group discussion list <teas.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/teas>, <mailto:teas-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/teas/>
List-Post: <mailto:teas@ietf.org>
List-Help: <mailto:teas-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/teas>, <mailto:teas-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Jul 2023 09:51:15 -0000

Many thanks, Shawn.

I have the nits fixed in my buffered copy.

Cheers,
Adrian

-----Original Message-----
From: Shawn Emery via Datatracker <noreply@ietf.org> 
Sent: 09 July 2023 06:37
To: secdir@ietf.org
Cc: draft-ietf-teas-rfc3272bis.all@ietf.org; last-call@ietf.org; teas@ietf.org
Subject: Secdir last call review of draft-ietf-teas-rfc3272bis-24

Reviewer: Shawn Emery
Review result: Has Nits

This informational track draft provides an up-to-date description of common
Internet traffic engineering concepts from the original RFC which was published
in 2002.

The security considerations section does exit and states that this draft
doesn't introduce any new security issues, which I agree.  The section
discusses the implications of when an attacker does compromise the control and
management protocols of TE networks.  This could lead to the adversary
diverting traffic to nodes controlled by the attacker, in which case the
privacy of the transmitted data can be compromised.  The traffic could also be
sent to the wrong place or slower network in order to perform a DoS of the
affected traffic.  The document doesn't prescribe mitigating steps for said
attacks.  I find this appropriate given the intent of this draft, which is to
describe a compilation of protocols.

General comments:

A well written and comprehensive document, however I mainly focused on the
changes from RFC 3272 to this draft.  Thank you for Appendix A.

Editorial comments:

s/example operating/example of operating/
s/Exampls/Examples/
s/netrok/network/
s/conforma/conforms/
s/determination of/determined by/
s/is conformed with for/conforms with/
s/enters a/enters/