IETF Logo Mail Archive

[TICTOC] Comments about draft-jlx-tictoc-1588v2-yang-02

Tal Mizrahi <talmi@marvell.com> Mon, 02 November 2015 09:47 UTC

Return-Path: <talmi@marvell.com>
X-Original-To: tictoc@ietfa.amsl.com
Delivered-To: tictoc@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 56DA31A0271; Mon, 2 Nov 2015 01:47:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.266
X-Spam-Level:
X-Spam-Status: No, score=-2.266 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, IP_NOT_FRIENDLY=0.334, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EyOjnFPLJcaG; Mon, 2 Nov 2015 01:47:43 -0800 (PST)
Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 292501A026C; Mon, 2 Nov 2015 01:47:40 -0800 (PST)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tA29iXQr010756; Mon, 2 Nov 2015 01:47:39 -0800
Received: from il-exch02.marvell.com ([199.203.130.102]) by mx0a-0016f401.pphosted.com with ESMTP id 1xwh0hj13x-6 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 02 Nov 2015 01:47:39 -0800
Received: from IL-EXCH01.marvell.com (10.4.102.220) by IL-EXCH02.marvell.com (10.4.102.221) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 2 Nov 2015 11:47:37 +0200
Received: from IL-EXCH01.marvell.com ([fe80::41:1c9f:8611:3a4a]) by IL-EXCH01.marvell.com ([fe80::41:1c9f:8611:3a4a%20]) with mapi id 15.00.1044.021; Mon, 2 Nov 2015 11:47:37 +0200
From: Tal Mizrahi <talmi@marvell.com>
To: "draft-jlx-tictoc-1588v2-yang@ietf.org" <draft-jlx-tictoc-1588v2-yang@ietf.org>, "'tictoc@ietf.org'" <tictoc@ietf.org>
Thread-Topic: Comments about draft-jlx-tictoc-1588v2-yang-02
Thread-Index: AdEVU1nCpzXIUBSeSiCAf2YY9J9ySA==
Date: Mon, 02 Nov 2015 09:47:32 +0000
Message-ID: <f6dd10752faa42d78948803a21e1d9a2@IL-EXCH01.marvell.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [199.203.130.14]
Content-Type: multipart/alternative; boundary="_000_f6dd10752faa42d78948803a21e1d9a2ILEXCH01marvellcom_"
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2015-11-02_05:, , signatures=0
X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1511020175
Archived-At: <http://mailarchive.ietf.org/arch/msg/tictoc/pwoqmyrxEmcH-myXcOzX9nLKZrA>
Subject: [TICTOC] Comments about draft-jlx-tictoc-1588v2-yang-02
X-BeenThere: tictoc@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Timing over IP Connection and Transfer of Clock BOF <tictoc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tictoc>, <mailto:tictoc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tictoc/>
List-Post: <mailto:tictoc@ietf.org>
List-Help: <mailto:tictoc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tictoc>, <mailto:tictoc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 09:47:44 -0000

Hi,

A few minor comments:


1.       Please add at the beginning of Section 5:
  <CODE BEGINS> file "ietf-yang-ptp-dataset@2015-10-15.yang"

2.       Please add at the end of Section 5:
  <CODE ENDS>

3.       There seems to be a problem with how "leaf parent-port-identity" is defined.
I guess you meant to define parent-port-identity as a container with "clock-identity" and "port-number". Currently the type of parent-port-identity is not defined.

Thanks,
Tal.

v2.23.0 | Report a Bug | By Email