Re: [Tsv-art] [Last-Call] Tsvart last call review of draft-ietf-netconf-tcp-client-server-21

Kent Watsen <kent+ietf@watsen.net> Mon, 12 February 2024 20:03 UTC

Return-Path: <0100018d9eeace8b-f182e99e-c65e-4b12-84cd-05830aa4fb82-000000@amazonses.watsen.net>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E599EC15152B; Mon, 12 Feb 2024 12:03:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=amazonses.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IX6Cve2U3OJS; Mon, 12 Feb 2024 12:03:29 -0800 (PST)
Received: from a48-93.smtp-out.amazonses.com (a48-93.smtp-out.amazonses.com [54.240.48.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E6F1C15108C; Mon, 12 Feb 2024 12:03:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1707768205; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:Feedback-ID; bh=YlLi5eSwP+6SF0wHmCjXrRYHzwjvsMtJnB13Cb4u9uk=; b=ZmxeR6WR98uIgMCLAFVZhbiN8hfdTRSY5MNZwfwpVhAW/2DcKFIf8p21LQhPoNJy mfjS90wmd3PEXq5MKo4pHm4Mf7Yvzw4tcC0wpoG5xXlOcsBjjUtp+TKIpr7J3Kq5V8V D2aWfm169Ty8lZjRwSsPiFw39Wzi5cwRd5WyjMTg=
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
From: Kent Watsen <kent+ietf@watsen.net>
In-Reply-To: <170773777422.36812.2729106686921670819@ietfa.amsl.com>
Date: Mon, 12 Feb 2024 20:03:24 +0000
Cc: tsv-art@ietf.org, draft-ietf-netconf-tcp-client-server.all@ietf.org, last-call@ietf.org, "netconf@ietf.org" <netconf@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-ID: <0100018d9eeace8b-f182e99e-c65e-4b12-84cd-05830aa4fb82-000000@email.amazonses.com>
References: <170773777422.36812.2729106686921670819@ietfa.amsl.com>
To: Michael Tüxen <tuexen@fh-muenster.de>
X-Mailer: Apple Mail (2.3731.600.7)
Feedback-ID: 1.us-east-1.DKmIRZFhhsBhtmFMNikgwZUWVrODEw9qVcPhqJEI2DA=:AmazonSES
X-SES-Outgoing: 2024.02.12-54.240.48.93
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/9K5rxrI3D_Z3VDeNIsyLMYCqsiU>
Subject: Re: [Tsv-art] [Last-Call] Tsvart last call review of draft-ietf-netconf-tcp-client-server-21
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Feb 2024 20:03:31 -0000

Hi Michael,

Thank you for your review,
Responses  below.

Kent


> On Feb 12, 2024, at 6:36 AM, Michael Tüxen via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Michael Tüxen
> Review result: Ready with Nits
> 
> This document has been reviewed as part of the transport area review team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the document's
> authors and WG to allow them to address any issues raised and also to the IETF
> discussion list for information.
> 
> When done at the time of IETF Last Call, the authors should consider this
> review as part of the last-call comments they receive. Please always CC
> tsv-art@ietf.org if you reply to or forward this review.
> 
> The document is well written, I only have the following two nits:
> 
> * 2.1.5. Guidelines for Configuring TCP Keep-Alives
>  It seems that the item list at the end of the subsection provides
>  information related to "idle-time", "max-probes", and "probe-interval".
>  One item for one leaf, in the given order.
>  What confuses me is that the first item contains:
>  "but keep-alive messages SHOULD NOT be transmitted more frequently than
>  once every 15 seconds"
>  For me, this applies to not only to "idle-time" but also to "probe-interval".
>  However, for "probe-interval" you provide lower values.
>  Using
>  "A lower value MAY be configured, but idle intervals SHOULD NOT be smaller
>  than 15 seconds. Longer idle intervals SHOULD be used when possible."
>  would have avoided this confusion.

I updated the document to use your text.  Thanks for the suggestion!


> * Acknowledgements
>  The authors would like to thank for following for lively discussions
>  should possibly read
>  The authors would like to thank the following for lively discussions

Fixed (in all nine drafts)


> Best regards
> Michael Tüxen


Thanks again,
Kent