[Tsv-art] Tsvart last call review of draft-ietf-netconf-tcp-client-server-21

Michael Tüxen via Datatracker <noreply@ietf.org> Mon, 12 February 2024 11:36 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 39D4BC151553; Mon, 12 Feb 2024 03:36:14 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Michael Tüxen via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-netconf-tcp-client-server.all@ietf.org, last-call@ietf.org, netconf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.5.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170773777422.36812.2729106686921670819@ietfa.amsl.com>
Reply-To: Michael Tüxen <tuexen@fh-muenster.de>
Date: Mon, 12 Feb 2024 03:36:14 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/eYeU6g3lm_1I4rH3ZZrm3skHNpQ>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-netconf-tcp-client-server-21
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Feb 2024 11:36:14 -0000

Reviewer: Michael Tüxen
Review result: Ready with Nits

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

The document is well written, I only have the following two nits:

* 2.1.5. Guidelines for Configuring TCP Keep-Alives
  It seems that the item list at the end of the subsection provides
  information related to "idle-time", "max-probes", and "probe-interval".
  One item for one leaf, in the given order.
  What confuses me is that the first item contains:
  "but keep-alive messages SHOULD NOT be transmitted more frequently than
  once every 15 seconds"
  For me, this applies to not only to "idle-time" but also to "probe-interval".
  However, for "probe-interval" you provide lower values.
  Using
  "A lower value MAY be configured, but idle intervals SHOULD NOT be smaller
  than 15 seconds. Longer idle intervals SHOULD be used when possible."
  would have avoided this confusion.

* Acknowledgements
  The authors would like to thank for following for lively discussions
  should possibly read
  The authors would like to thank the following for lively discussions

Best regards
Michael Tüxen