Re: [Tsv-art] Tsvart last call review of draft-ietf-lsr-isis-fast-flooding-07

I just updated my review but I don’t think it generated another email. This is what I added:

Update: Even though the last review was meant to be an "early" it was only
requested right before IETF LC. I understand that the feedback provided is
therefore rather late in the process and therefore I don't think should block
publication of the draft.

> On 29. Feb 2024, at 15:40, Mirja Kühlewind via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Mirja Kühlewind
> Review result: On the Right Track
> 
> This document has been reviewed as part of the transport area review team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the document's
> authors and WG to allow them to address any issues raised and also to the IETF
> discussion list for information.
> 
> When done at the time of IETF Last Call, the authors should consider this
> review as part of the last-call comments they receive. Please always CC
> tsv-art@ietf.org if you reply to or forward this review.
> 
> I did an early TSV review a few weeks ago and the current version addresses a
> lot of the comments and is an improvement.
> 
> On the high level I still think the document can be further improves by
> recommending and discussion appropriate default values or values ranges to
> ensure safe operation as implementors often reply on default value and if no
> recommendation is given or discussed this can lead easy to a selection of too
> high values that would overload the other end.
> 
> Also the congestion control part seems rather complex for a point-to-point
> connection. I understand that the proposed mechanism was experimented with and
> showed improvements in case of overload of the internal switch. However,
> congestion control usually also aims to fully utilise the available resources
> which is not a goal here and therefore a simpler solution like a circuit
> breaker would probably be sufficient.
> 
> 
> _______________________________________________
> Tsv-art mailing list
> Tsv-art@ietf.org
> https://www.ietf.org/mailman/listinfo/tsv-art