[Tsv-art] Tsvart last call review of draft-ietf-detnet-data-plane-framework-04

Yoshifumi Nishida via Datatracker <noreply@ietf.org> Tue, 07 April 2020 08:57 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: tsv-art@ietf.org
Delivered-To: tsv-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id D93AC3A194E; Tue, 7 Apr 2020 01:57:41 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Yoshifumi Nishida via Datatracker <noreply@ietf.org>
To: <tsv-art@ietf.org>
Cc: last-call@ietf.org, detnet@ietf.org, draft-ietf-detnet-data-plane-framework.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.124.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <158624986177.7879.15272885885261397703@ietfa.amsl.com>
Reply-To: Yoshifumi Nishida <nsd.ietf@gmail.com>
Date: Tue, 07 Apr 2020 01:57:41 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/SWgGvdUc06urTaF0MqHRLIMwaEY>
Subject: [Tsv-art] Tsvart last call review of draft-ietf-detnet-data-plane-framework-04
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2020 08:57:42 -0000

Reviewer: Yoshifumi Nishida
Review result: Ready with Nits

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

Summary: Ready with Nits.

This document is well-written as an informational RFC. I don't see any
technical issues related to transport, but it might be better to clarify the
following minor point.

The draft allows DetNet data plane to carry flow ID and sequence number as
metadata. But, aren't there any potential risks for the conflict of the flow ID
or wrap-around of the sequence number? (especially for explicit case) It might
be better to state which module should care if it's out of scope for the draft
or to clarify there is no risk against them.