[Tsv-art] TSV-ART review of draft-ietf-netmod-acl-model-19

Allison Mankin <allison.mankin@gmail.com> Mon, 09 July 2018 19:43 UTC

Return-Path: <allison.mankin@gmail.com>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ADEDA130E8F; Mon, 9 Jul 2018 12:43:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dSYlpmDJGXqv; Mon, 9 Jul 2018 12:43:08 -0700 (PDT)
Received: from mail-pl0-x235.google.com (mail-pl0-x235.google.com [IPv6:2607:f8b0:400e:c01::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2D6E5130E35; Mon, 9 Jul 2018 12:43:08 -0700 (PDT)
Received: by mail-pl0-x235.google.com with SMTP id w8-v6so6491964ply.8; Mon, 09 Jul 2018 12:43:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=c3K4x0DcYNQ+OzmxE/m/SDilAbAtBfg78XYvJ8ITMRk=; b=bl+m3irG3Uz6fEe8gFEg4etElrfCCDQqD34k8sNEbtGUmqiMH7pva6+dJCo2Z/KPez lortUvjk0nhAnvmGH1Elf3HhpRqfPgEHxhBHkiGAtOLmZ1mo370hKYqR7g/AEYa0ZRs7 0A0KxVgtfLdP72iwc3oblXdoSm+gl2vCXAKF7b6y0sHmGgy3ggEu8UGt+pO15+POI8D8 Dqap4E0Z66Pial/xeSSKyjkMPsICcw3sru76cD3VA/vz4mvUm45y8sw7MYoBymcZJ0Di xzl0Ap5RFczBu/Sobx7pnYDD+SY2vuRK5bFlDBHZlFPynPYqRunL0c0nQWi8csZ6dovn 7U4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=c3K4x0DcYNQ+OzmxE/m/SDilAbAtBfg78XYvJ8ITMRk=; b=udfioG8sMHNMVffDttA8QdMrOfrtmT74C4z5/Lg1tqoBP4esK+wL4dyg7vcVAcY+bW 5Kp9mYIMIQMmrOk9JFkfhanbaQQwxG2Nu14fmuHK+apSwk1aIAsZ0awrVJgsCoq0AmAh ELnz5uvJyRUR/B39ZjCNnkF37kHvEeyXdnmKynyfV7RAPnFVKvSYD5nZ3q3+HF6HrzhB U672txe7dKslFKoLmq1Y+hvw6PMXFMjmjv24Hl2EE0NNYVzPPaKhdeFMpcXP2I+n+Zhp T8mnhzfamfrbDcxgAmtsPjSyThIOqTBnSGQTAw8SsdzAm24ubK04uXtBtfEp1gxQqJwd +txA==
X-Gm-Message-State: APt69E1Tk4W9xJ5GT1yrEABmEnYClDyzP1UW9EENPQ2LF4LEp+jicbnL 1ktKLTTX9yekUcdg5UiC7Ziuqh/9vFe/6oQm0CNjsQ==
X-Google-Smtp-Source: AAOMgpdTnr7C5iwQLjDh9X4OD6qKie1u/zEsqQwhO40uTzN2L06drb6Z3gy0ILCbprCqGtA1POPcOufu4EMYVSdmHoQ=
X-Received: by 2002:a17:902:7202:: with SMTP id ba2-v6mr21368967plb.119.1531165387390; Mon, 09 Jul 2018 12:43:07 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a17:90a:ac18:0:0:0:0 with HTTP; Mon, 9 Jul 2018 12:43:06 -0700 (PDT)
From: Allison Mankin <allison.mankin@gmail.com>
Date: Mon, 9 Jul 2018 15:43:06 -0400
Message-ID: <CAP8yD=ur9Swpz92sRrJOp0r5ARp16Zhwmse7Q67sg+2okLEYOA@mail.gmail.com>
To: Transport Area Review Team <tsv-art@ietf.org>, netmod@ietf.org
Content-Type: multipart/alternative; boundary="00000000000002026905709639c1"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/lpeT9VH6bGxhPp38XPxuQiLSn5A>
Subject: [Tsv-art] TSV-ART review of draft-ietf-netmod-acl-model-19
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jul 2018 19:43:10 -0000

I've reviewed this document as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the
document's authors for their information and to allow them to address any
issues raised. When done at the time of IETF Last Call, the authors should
consider this review together with any other last-call comments they
receive. Please always CC tsv-art@… if you reply to or forward this review..

Summary:
Almost Ready (but I do have a question)

Technicals:
I reviewed that the details about TCP, UDP, ECN, and DSCP are consistent
with the specifications, and that the specifications are accurate.  The
model is accurate for these.


Question:
 What is the use case for ACLs referencing TCP PSH and URG flags, and
sequence numbers?  These are not very predictable and I would think not
very useful for the work that ACLs do, but I'm willing to be informed.