Re: [Tsv-art] Tsvart last call review of draft-ietf-ipwave-ipv6-over-80211ocb-46

Nabil Benamar <n.benamar@est.umi.ac.ma> Wed, 03 July 2019 18:12 UTC

Return-Path: <n.benamar@est.umi.ac.ma>
X-Original-To: tsv-art@ietfa.amsl.com
Delivered-To: tsv-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 973E712043C for <tsv-art@ietfa.amsl.com>; Wed, 3 Jul 2019 11:12:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=est-umi-ac-ma.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EbVvDzmfobfU for <tsv-art@ietfa.amsl.com>; Wed, 3 Jul 2019 11:12:12 -0700 (PDT)
Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BAD4B120449 for <tsv-art@ietf.org>; Wed, 3 Jul 2019 11:12:08 -0700 (PDT)
Received: by mail-io1-xd2a.google.com with SMTP id k8so7074375iot.1 for <tsv-art@ietf.org>; Wed, 03 Jul 2019 11:12:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=est-umi-ac-ma.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zfWBaymx3Gm3O369YzPzjggKhK2LM9ARvvc7gCwjQKY=; b=MeU1Ay1Ha/CYaFARLDuBPO9slP7bUBs2hWQQcuapU1IBMT8bdyRybZctSlQjecse46 teMpFYO4Gj+VHtdIvhfpCY7uMP1ePQAQDO/mEBRX9HmJPzgpNbGeIItB9EEzaAYYYbYz rqVODawOfemAVO4nLZKGUQOhJHmbQYsafAD9tTr2JNNsl+Tl/yZXWRINOHblRbW8GVLO JSD1wX4uVLLINEBjL7A/FWTfP8ZLIddWyKbonpGIp60yjrlHOUnKM5N0PBuFFsalV6V9 4aR6td/z3s50zB6nHUSieZImAK5PxNUrre3TbF2/fWm+NbFX4RLzEz+zNd1MdMzrFeQs /3dw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zfWBaymx3Gm3O369YzPzjggKhK2LM9ARvvc7gCwjQKY=; b=BJqSIITyZItt9yyxV5GeXP8MqeBS9mBDPALITkX4uJYa+yh1zpX29tnMg9yHjFRfbH lpsPWEsUReQRxpJjhyQKHlBFYpg5w8KOg47zK0WZ7uEQtIFYwhiwWtsE28NT/yxdggBn rFk7scTI8zaJR95IDxXdgCoTEU9JtRXnKa5Tl+pKGLeDLZFShAIXBcwePrweqMDpFhco YYlo2m7EUkT9o/FXdcXZEtWtsX9j3MtJ+pQpdhtHWBwqzTzieY1BdSD1O0KB/1IX+DSq TXoI5+MYC/h/ae4O6/Yu8UqF6OLxCjrOZOGhBgpW6f8vQ54mTVKLOOu+jpPgjUm6hD4/ ZJuA==
X-Gm-Message-State: APjAAAWa6ZToftBYmd+ET+GlfeBUAz9o9wmA3+85BA8wDJqRnto/KAka +MTEJDYRGq2cUX+GniMAtQp3b+8l+Bspeirzhc7zVg==
X-Google-Smtp-Source: APXvYqxsZ4WL1dzdJOUaB6GlP6kawNQwFgHr0n8dUPA/lsHanyfHg45bEqGvdcXDC7OOnhAcCLD8byVjmggiqiPue2M=
X-Received: by 2002:a02:8787:: with SMTP id t7mr44158603jai.29.1562177526668; Wed, 03 Jul 2019 11:12:06 -0700 (PDT)
MIME-Version: 1.0
References: <156165351682.21357.6959207590092474225@ietfa.amsl.com>
In-Reply-To: <156165351682.21357.6959207590092474225@ietfa.amsl.com>
From: Nabil Benamar <n.benamar@est.umi.ac.ma>
Date: Wed, 03 Jul 2019 19:11:55 +0100
Message-ID: <CAD8vqFcP6DtCY_v1tkew+wYr6VeyEgbAvG9RLOT1g=s7BS67pQ@mail.gmail.com>
To: Joerg Ott <jo@acm.org>
Cc: tsv-art@ietf.org, IETF Discussion <ietf@ietf.org>, its@ietf.org, draft-ietf-ipwave-ipv6-over-80211ocb.all@ietf.org, CARLOS JESUS BERNARDOS CANO <cjbc@it.uc3m.es>, Russ Housley <housley@vigilsec.com>
Content-Type: multipart/alternative; boundary="0000000000008db7a6058ccacce0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsv-art/xhYrDdRH5j6s7lAH6EIebQnzIyc>
Subject: Re: [Tsv-art] Tsvart last call review of draft-ietf-ipwave-ipv6-over-80211ocb-46
X-BeenThere: tsv-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Review Team <tsv-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsv-art/>
List-Post: <mailto:tsv-art@ietf.org>
List-Help: <mailto:tsv-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsv-art>, <mailto:tsv-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jul 2019 18:12:15 -0000

Dear reviewer,

Thank you for your comments.

Kindly, see my answers in-line below.



On Thu, Jun 27, 2019 at 5:38 PM Joerg Ott via Datatracker <noreply@ietf.org>
wrote:

> Reviewer: Joerg Ott
> Review result: On the Right Track
>
> This document has been reviewed as part of the transport area review team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the
> document's
> authors and WG to allow them to address any issues raised and also to the
> IETF
> discussion list for information.
>
> When done at the time of IETF Last Call, the authors should consider this
> review as part of the last-call comments they receive. Please always CC
> tsv-art@ietf.org if you reply to or forward this review.
>
> The draft discusses the most basic operation of IPv6 over IEEE 802.11-OCB,
> i.e., a flavour of ad-hoc networks specifically for vehicular connectivity
> (formerly
>  known as IEEE 802.11p). The document mainly covers question of mapping
> IPv6
> packets to the MAC layer frames, discusses aspects of address assignment
> and
> subnets, and neighbour discovery. The core document is rather short but has
> extensive appendices.
>
> There are no clear transport issues in this document. The main relevant
> aspect would
> be MTU size, which is in line with standard IPv6. But the document
> discusses (section 4.2)
> that all IPv6 packets should be mapped to the same class of service. So,
> there is no
> service differentiation expected (diffserv, for example)?
>

We have not treated this detail in the current document.



>
> However, I do not consider the document to be really ready because of
> structure
> and writing clarity. This is surprising for version -46! There is a need
> for improvement
> to make the document properly understandable by the reader. I am actually
> wondering
> why this document is sent out for last call given the state the text is in.
>

The document will be proofred once again before  becoming an RFC.

>
> Detailed comments:
>
> In several places, the text reminds of patent jargon. Should I worry?
> There doesn't appear
> to be any IPR disclosure.
>
> p5, 1st line: packet->packets
>

Are you referring to page 5 or paragraph 5?

>
> The use of RFC 2026 language needs improvement.
>

I didn't get your point. Would you please clarify on how we can tackle this
issue, if any?

>
> sect. 4.4: transition time is not defined
>

The IP-OBUs that are based on embedded platforms can only use the former
(MAC-based) whereas more powerful platforms (native x86) can use RFC8064. The
majority of IP-OBUs are embedded platforms.  I'm not sure whether they can
use RFC8064.


> "no generic meaning" -- means what?
>

No generic meaning' - means that the bits in the Interface Identifiers are
'opaque'.  Earlier, the u/g bits in IID had a significance (it meant
'unique/global'). A concept updated by RFC7136.



> This section is confusing. Please describe a concrete sequence of actions.


Would you show us how we can improve this section?

>
>
> sect. 4.5: external references for standards are surely the right way. But
> the reader may benefit from some informal self-contained description.
>
> sect. 4.5.2: anythings needs to be said about multicast reception?
>
> sect 4.6: Clarify "A subnet may be formed over 802.11-OCB interfaces of
> vehicles that are in close range (not by their in-vehicle interfaces)."
> further.
>
> sect. 5: explain briefly how certificates are supposed to work with
> variable addresses.
>
> App. E: why would high mobility affect encapsulation"?
>
> App. G: Ok to show complete packet formats. But then maybe also give
> specific examples?
> And why do you describe this as capturing what is received rather than how
> to construct
> something to sent out?
>
> App. I: reliable multicast used incorrectly
> "TBD TBD TBD"
>
> Nits: "mode.A", "; The", "on another hand", "At application layer"
> "attacker can therefore just sit in the near range of vehicles"
> "perform attacks without needing to physically break any wall."
> "embarking an"
> "outdoors public environments"
> "attacker sniffers"
> "indoor settings"
> "eventual conflicts"
> "internet"
> expand all acronyms, also in the appendices
>
> Why has sect. 5.3 bullets?
>
>

-- 

Best Regards

Nabil Benamar
Associate Professor
Department of Computer Sciences
School of Technology
Moulay Ismail University
Meknes. Morocco