Re: [tsvwg] Mirja Kühlewind's No Objection on draft-ietf-tsvwg-tinymt32-02: (with COMMENT)

Vincent Roca <vincent.roca@inria.fr> Mon, 27 May 2019 09:21 UTC

Return-Path: <vincent.roca@inria.fr>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A07A612007C; Mon, 27 May 2019 02:21:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.899
X-Spam-Level:
X-Spam-Status: No, score=-6.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2RmVXzrvz6mg; Mon, 27 May 2019 02:21:34 -0700 (PDT)
Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F09212004B; Mon, 27 May 2019 02:21:33 -0700 (PDT)
X-IronPort-AV: E=Sophos;i="5.60,518,1549926000"; d="scan'208,217";a="307297554"
Received: from moucherotte.inrialpes.fr ([194.199.28.14]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2019 11:21:07 +0200
From: Vincent Roca <vincent.roca@inria.fr>
Message-Id: <C1E16B17-C587-435A-9A84-7817ECD23394@inria.fr>
Content-Type: multipart/alternative; boundary="Apple-Mail=_B4DBAF7B-0EE2-4326-83F7-BC597C78CE75"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Mon, 27 May 2019 11:21:06 +0200
In-Reply-To: <155837452785.12813.9131632142006892445.idtracker@ietfa.amsl.com>
Cc: Vincent Roca <vincent.roca@inria.fr>, The IESG <iesg@ietf.org>, draft-ietf-tsvwg-tinymt32@ietf.org, Wesley Eddy <wes@mti-systems.com>, tsvwg-chairs@ietf.org, tsvwg@ietf.org
To: =?utf-8?Q?Mirja_K=C3=BChlewind?= <ietf@kuehlewind.net>, =?utf-8?Q?=C3=89ric_Vyncke_via_Datatracker?= <noreply@ietf.org>
References: <155837452785.12813.9131632142006892445.idtracker@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/JrW20Ij990WasE7Y2hKvRvPSgQ8>
Subject: Re: [tsvwg] =?utf-8?q?Mirja_K=C3=BChlewind=27s_No_Objection_on_draft?= =?utf-8?q?-ietf-tsvwg-tinymt32-02=3A_=28with_COMMENT=29?=
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 May 2019 09:21:38 -0000

Dear Mirja and Eric

Thanks a lot for your comments.
I hereafter answer both of your comments since they are close to one another:


> Le 20 mai 2019 à 19:48, Mirja Kühlewind via Datatracker <noreply@ietf.org> a écrit :
> 
> Mirja Kühlewind has entered the following ballot position for
> draft-ietf-tsvwg-tinymt32-02: No Objection

> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> I agree with Eric that a reference to MT would be really good.

[VR] We added the seminal MT scientific publication.
There’s unfortunately nothing similar for the TinyMT variant.


> As mentioned in the intro, "neither TinyMT nor MT are meant to be used for
> cryptographic applications". Please add this also to the security
> considerations section and maybe further explain risks.

[VR] Done.

> Similar as the feedback originally provided (by other ADs) for
> draft-ietf-tsvwg-rlc-fec-scheme, I would prefer to have the algorithm specified
> in text and not only as code.

[VR] Sure, but in that case it is too risky (risk of introducing an error in the textual 
representation) and we left it as is.


—

> Le 18 mai 2019 à 18:41, Éric Vyncke via Datatracker <noreply@ietf.org> a écrit :
> 
> Éric Vyncke has entered the following ballot position for
> draft-ietf-tsvwg-tinymt32-02: No Objection
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thanks for the work everyone has put into this document (and I understand that
> this -02 is coming out of another older document). While the mathematical
> aspects of the document are above my head, I took the liberty to put 3 comments
> and 1 nit in the hope to improve the quality of the document.
> 
> == COMMENTS ==
> 
> -- Introduction  --
> 
> Why not using the usual format for informative references in this chapter?

[VR] Good point, it’s now implemented.

NEW:
   [TinyMT-dev]
              Saito, M. and M. Matsumoto, "Tiny Mersenne Twister
              (TinyMT) github site", <https://github.com/
              MersenneTwister-Lab/TinyMT>.

   [TinyMT-params]
              Rikitake, K., "TinyMT pre-calculated parameter list github
              site", <https://github.com/jj1bdx/tinymtdc-longbatch/>.

   [TinyMT-web]
              Saito, M. and M. Matsumoto, "Tiny Mersenne Twister
              (TinyMT) web site",
              <http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/TINYMT/>.

> The Mersenne Twister is part of the sentence but there are no reference to any
> paper. Please add a reference for the seminal piece of work.

[VR] Done with the brand new [MT98] reference;

> 
> "...TinyMT32 represents a major improvement ..." can we have more information
> about this improvment? On which aspect ?

[VR] Yes, we clarified it (already in version -02). 

NEW:
   According to statistical tests (BigCrush in
   TestU01 and AdaptiveCrush), the quality of the outputs of TinyMT
   seems pretty good in terms of randomnes (in particular the uniformity
   of generated numbers), taking the small size of the internal state
   into consideration (see [TinyMT-web]).


We also added references to explain why Park-Miller PRNG should not be used.

NEW:
   Miler Linear Congruential PRNG (e.g., as specified in [RFC5170]) that
   suffers several known limitations (see for instance [PTVF92], section
   7.1, p. 279, and [RLC-ID], Appendix B).


> 
> == NITS ==
> 
> -- Abstract  --
> 
> I find it a little surprizing that two authors are cited in the abstract.

[VR] Yes, and we removed their names, adding only a reference to the academic
publication.

NEW:
   This PRNG is a
   small-sized variant of Mersenne Twister (MT) PRNG [MT98].



Cheers,

  Vincent, on behalf of the authors