Re: [Webpush] Message update PR

[Martin Thomson <[e-mail]>]

On 12 January 2016 at 04:00, Costin Manolache <[e-mail]> wrote:
> - +1 in general
>
> - Doubts about the name "Topic" - many pubsub users will be confused, it is
> not really a topic,
> just a key

I'm happy to take suggestions on the name, it's just a name :)

>From my perspective however, the pubsub use fits almost perfectly with
this use, so I think that the name is a bit of an advantage.

> -  We may relax the '4 collapse keys' limit for GCM, shouldn't be a problem
> for webpush.

That would be awesome (I hear that collapse keys are very heavily used
by some big sites, I wonder if you aren't already feeling the pressure
there).

> Can we change a bit the wording to allow some optimizations we do: a message
> with topic (collapse
> key) may be optimized for 'sync usage' - i.e. even if the device is online,
> if push service detects
> frequent messages in a topic (for example user receives lots of email) it
> may delay and collapse
> messages. I.e. not only " If the user agent is offline".

That should always be possible.  If the text implies otherwise, then
we should correct that.

> Also I would prefer (for implementation purpose) a simpler ID syntax instead
> of quoted string.
> It's going to be a database key, short an unambiguous seems better. URI path
> component would
> be nice.

Would the base64(url) alphabet suit you well enough?  I didn't add
that restriction.

What about a length restriction?  I think that Ben and I discussed
just rejecting push messages with ridiculously long topic names.

> Finally, a more generic approach would be to allow the sender to specify a
> MessageID - than
> multiple messages with the same ID could override each other ( identical
> with topic ), but the main
> benefit is that senders will avoid a lookup and mapping push-service IDs to
> their internal IDs in
> acks. Push service can internally combine the subscription ID with the
> sender-provided message ID.

Maybe I'm not understanding you here, but isn't that exactly what this
change does?