Re: [Wish] Secdir last call review of draft-ietf-wish-whip-13

Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com> Mon, 18 March 2024 09:41 UTC

Return-Path: <sergio.garcia.murillo@gmail.com>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 05797C1519A2; Mon, 18 Mar 2024 02:41:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GJEP9fjDdGqI; Mon, 18 Mar 2024 02:41:38 -0700 (PDT)
Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71853C14F69E; Mon, 18 Mar 2024 02:40:51 -0700 (PDT)
Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a46d0a8399aso1701766b.1; Mon, 18 Mar 2024 02:40:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710754849; x=1711359649; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yXJ5lrmI4K0uel6evhGBi0NKzNJ+PIeVLBLVu1YhX0w=; b=mowDPra1cmc0HYDKhydpBOLMK+5JHMkziu564JZPUBsRXDv+QPs6CGNbuJ2CxchhM1 LsqDaAToOYat2l5dySQbYdhcjHRbFL7NLVo2uOBhuOKZ2LwPFFq9szalu9aUomifzcck w8+F/0Lw3Itt/H3BLt0ZT6X+eqNjb4QXAVWAFLzDBaQ0J6aowtgbxTR1kmTW+KZeBdJk 4lUXdCbiLBeXtJCJ5NaKnKHLM8k1H6bsC7CZYxIkGKV/ptKkinDQG0ywgeI6AgTezmoW 2gzY+fy7MMDXTJPOVQEASUmLTJQyORoyEOzzEjwZ3drp34VmlPvJCave3kNawVCCKnRE Dq8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710754849; x=1711359649; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yXJ5lrmI4K0uel6evhGBi0NKzNJ+PIeVLBLVu1YhX0w=; b=HGll0r/TImdKiaXf7bcKsFKWnoKrSER6fKPeV5QIFnftBaGCTnJWvmrD0Aq0A0nCG2 NYm06NmOQya52YDmScKAh/g1Rap+o8vuhPDuOG9OpJYCdjpY5hs0RRCuh30mzufLbYqa Nugb9+AhpMgov/c3xgTr6JAhSfdTSDeGGQD9E17JPSK1WAk2Mh5nQJ+RFpF0KXOzFf+S tlO0P6ow9/ikm2tn6vmnmtn0QE9DBdyy65pm1m08UF5eGCo7Cz584h59o8mWRP08qagz K18ylbrt6oVqs1AkwBmNzzoJQeVbWDFMPgTicGeTyOfgFFAgAPOgfO65sAwOcrwV+YsP PDIA==
X-Forwarded-Encrypted: i=1; AJvYcCUGfmUktgDGiY3CD38/0tb/OmDy6xEht13aGXExSuby7yFqlQfWR96AxyWtjbPI9mzf3ShIl+zK6xTTbjRmFc5bMpeRUaoYTqMP33ORSPEd3a4a8zgKzCvGoM4aRw6AvBqHs+XqHkInCiujPJJIGESjwvvwLA==
X-Gm-Message-State: AOJu0YztAbGKXGzTue9B9FQXOug75lqV+5SiYudB1jUHioj/fjL8HirD B+ivkY/il9zTLvsVYTa1JA/lzx2Hq3bKL8mrjXpq1nxhHHD3IP098f0DTXnaBAG1vGOnVbpkGb8 UpIoUAigIF8IGpWSo4CKr5vTwGw6to5pg/5c=
X-Google-Smtp-Source: AGHT+IF4gQs2lJIgiDQS3omZ9kSdGYjczuIoJdak06wEu4u0JdC17k5ygaHMP4SHKePEjNIt1DFx+lbQNIkDyXisEYM=
X-Received: by 2002:a17:906:9c8f:b0:a45:b506:11ca with SMTP id fj15-20020a1709069c8f00b00a45b50611camr13031749ejc.7.1710754849158; Mon, 18 Mar 2024 02:40:49 -0700 (PDT)
MIME-Version: 1.0
References: <171046071273.19170.9115939465212766474@ietfa.amsl.com>
In-Reply-To: <171046071273.19170.9115939465212766474@ietfa.amsl.com>
From: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
Date: Mon, 18 Mar 2024 10:40:39 +0100
Message-ID: <CA+ag07bq6V40sq+uv+6DTj_d88G9Biovh3BDD7ONu66uQZdiaQ@mail.gmail.com>
To: Russ Housley <housley@vigilsec.com>
Cc: secdir@ietf.org, draft-ietf-wish-whip.all@ietf.org, last-call@ietf.org, wish@ietf.org
Content-Type: multipart/alternative; boundary="0000000000001501310613ec271f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/5LbG02YZJZtx3weOrnK5vyuKNhg>
Subject: Re: [Wish] Secdir last call review of draft-ietf-wish-whip-13
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Mar 2024 09:41:39 -0000

Thank you Russ for your review, comments inline.

On Fri, Mar 15, 2024 at 12:59 AM Russ Housley via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Russ Housley
> Review result: Has Issues
>
> Minor Concerns:
>
> Figures 2, 3, and 4 are not referenced from body of the document.  It is
> best to include a reference in the body that offers some description of
> what
> the reader is expected to learn from the figure.  When I as a Security AD,
> the other Security AD was blind.  The text-to-audio system that he used was
> surprisingly good, but it could not handle ASCII art.  The discussion of
> the figures was vital to him being able to understand a document.  Please
> help readers that depend on such tools.
>

I was not aware of this, thank you very much for pointing it out, seems
something important to be addressed.

Do you have any guideline or example about how to best make the change so
it works properly with screen readers?


>
> Section 4.2 says:
>
>    In order to reduce the complexity of implementing WHIP in both
>    clients and Media Servers, WHIP imposes the following restrictions
>    regarding WebRTC usage:
>
> I think it would be more clear to say that each of the following
> subsections
> discuss restrictions for WebRTC usage.
>
>
 I think that is clear with the current text, but it doesn't hurt to add
more explicit wording if you feel so.

How would be the best way of doing these changes? I would prefer not to
have to submit a new draft for these editorial changes and have to start
again a WGLC & IESG review.

Best regards
Sergio