Re: [yang-doctors] [Anima] Yangdoctors early review of draft-ietf-anima-brski-async-enroll-03

"Fries, Steffen" <steffen.fries@siemens.com> Wed, 18 August 2021 11:46 UTC

Return-Path: <steffen.fries@siemens.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 205503A15B3; Wed, 18 Aug 2021 04:46:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AYuedd2NGMZq; Wed, 18 Aug 2021 04:46:31 -0700 (PDT)
Received: from gw-eagle1.siemens.com (gw-eagle1.siemens.com [194.138.20.72]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B2053A1596; Wed, 18 Aug 2021 04:46:30 -0700 (PDT)
Received: from mail3.dc4ca.siemens.de (mail3.dc4ca.siemens.de [139.23.14.198]) by gw-eagle1.siemens.com (Postfix) with ESMTPS id 5A87D4F0607; Wed, 18 Aug 2021 13:46:27 +0200 (CEST)
Received: from DEMCHDC8A0A.ad011.siemens.net (demchdc8a0a.ad011.siemens.net [139.25.226.106]) by mail3.dc4ca.siemens.de (Postfix) with ESMTPS id 6BC8C3258439; Wed, 18 Aug 2021 13:46:25 +0200 (CEST)
Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 18 Aug 2021 13:46:24 +0200
Received: from DEMCHDC89XA.ad011.siemens.net ([139.25.226.103]) by DEMCHDC89XA.ad011.siemens.net ([139.25.226.103]) with mapi id 15.01.2308.014; Wed, 18 Aug 2021 13:46:24 +0200
From: "Fries, Steffen" <steffen.fries@siemens.com>
To: Michael Richardson <mcr+ietf@sandelman.ca>, Reshad Rahman <reshad@yahoo.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-anima-brski-async-enroll.all@ietf.org" <draft-ietf-anima-brski-async-enroll.all@ietf.org>, "anima@ietf.org" <anima@ietf.org>
Thread-Topic: [Anima] Yangdoctors early review of draft-ietf-anima-brski-async-enroll-03
Thread-Index: AQHXkelzDqFg97dAx0et2SZP+hLKfat479MQgAASqwCAACWR4A==
Date: Wed, 18 Aug 2021 11:46:24 +0000
Message-ID: <fa3a22a2c836453fb8a8a4c449293c37@siemens.com>
References: <162904097601.26892.13230706221222180793@ietfa.amsl.com> <ed4b0aca6c8743529875c5af956b4d63@siemens.com> <20228.1629286004@localhost>
In-Reply-To: <20228.1629286004@localhost>
Accept-Language: en-US, de-DE
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2021-08-18T11:46:23Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=465117bf-0e90-4cbb-b24b-017624f7c5f5; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0
document_confidentiality: Restricted
x-originating-ip: [144.145.220.67]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/5YZV5X6puaxFbPA5T7HTSO-uiG0>
Subject: Re: [yang-doctors] [Anima] Yangdoctors early review of draft-ietf-anima-brski-async-enroll-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2021 11:46:51 -0000

Hi Michael, 

> -----Original Message-----
> From: Michael Richardson <mcr+ietf@sandelman.ca>
> Sent: Mittwoch, 18. August 2021 13:27
> 
>     reshad> Other comments: - rc:yang-data (RFC8040) is used. While this
>     reshad> seems to be fine, if the voucher- request-async-artifact template
>     reshad> needs to be extended in the future, my understanding is that it
>     reshad> is not possible with yang-data. However, you could use
>     reshad> "structure" and (eventually) "augment-structure" from RFC8791 for
>     reshad> this.
> 
> I am probably the guilty party that wrote the YANG.
> I guess I missed your email (seeing Steffen's reply only), and I'll go back to the
> list to find it to understand.
I saw that the constraint voucher follows the same approach.

> We do want to mix and match the various extensions.
> It is not clear to me how to do that.
Maybe related to this, would it be better to augment the voucher than as requested by Reshad or the voucher-request as we currently do it. I also had a look into the constraint voucher as there are also enhancements defined. So I guess I should go with the augmented voucher?


>     > We will discuss this point. Currently there is no explicit need for
>     > enhancements.
> 
>     reshad> - Prefix "ivr" is used for ietf-voucher-request although RFC8995 has
>     reshad> "vcr". While this is valid, I am curious why.
> 
> I didn't think the prefix had relevance outside of the module, but I don't know a
> lot here.
I meanwhile changed it to vcr. If it has no relevance outside the module, it should not be a problem

Regards
Steffen 

> 
> --
> ]               Never tell me the odds!                 | ipv6 mesh networks [
> ]   Michael Richardson, Sandelman Software Works        |    IoT architect   [
> ]     mcr@sandelman.ca  http://www.sandelman.ca/        |   ruby on rails    [