Re: [yang-doctors] [Anima] Yangdoctors early review of draft-ietf-anima-brski-async-enroll-03

"Fries, Steffen" <steffen.fries@siemens.com> Thu, 19 August 2021 06:15 UTC

Return-Path: <steffen.fries@siemens.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D689A3A03EE; Wed, 18 Aug 2021 23:15:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6jqAfzXiZqrG; Wed, 18 Aug 2021 23:15:37 -0700 (PDT)
Received: from gw-eagle1.siemens.com (gw-eagle1.siemens.com [194.138.20.72]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 76CF03A03EB; Wed, 18 Aug 2021 23:15:37 -0700 (PDT)
Received: from mail4.dc4ca.siemens.de (mail4.dc4ca.siemens.de [139.23.14.214]) by gw-eagle1.siemens.com (Postfix) with ESMTPS id 3A5E14F0005; Thu, 19 Aug 2021 08:15:34 +0200 (CEST)
Received: from DEMCHDC8A0A.ad011.siemens.net (demchdc8a0a.ad011.siemens.net [139.25.226.106]) by mail4.dc4ca.siemens.de (Postfix) with ESMTPS id 74CA232939A4; Thu, 19 Aug 2021 08:15:34 +0200 (CEST)
Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 19 Aug 2021 08:15:34 +0200
Received: from DEMCHDC89XA.ad011.siemens.net ([139.25.226.103]) by DEMCHDC89XA.ad011.siemens.net ([139.25.226.103]) with mapi id 15.01.2308.014; Thu, 19 Aug 2021 08:15:34 +0200
From: "Fries, Steffen" <steffen.fries@siemens.com>
To: Reshad Rahman <reshad@yahoo.com>, Michael Richardson <mcr+ietf@sandelman.ca>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-anima-brski-async-enroll.all@ietf.org" <draft-ietf-anima-brski-async-enroll.all@ietf.org>, "anima@ietf.org" <anima@ietf.org>
Thread-Topic: [Anima] Yangdoctors early review of draft-ietf-anima-brski-async-enroll-03
Thread-Index: AQHXkelzDqFg97dAx0et2SZP+hLKfat479MQgAASqwCAACWR4IAAfMmAgAC5gDA=
Date: Thu, 19 Aug 2021 06:15:34 +0000
Message-ID: <63bc02bfef2348edb1b4766d1cc554ef@siemens.com>
References: <162904097601.26892.13230706221222180793@ietfa.amsl.com> <ed4b0aca6c8743529875c5af956b4d63@siemens.com> <20228.1629286004@localhost> <fa3a22a2c836453fb8a8a4c449293c37@siemens.com> <365104595.1185979.1629320869837@mail.yahoo.com>
In-Reply-To: <365104595.1185979.1629320869837@mail.yahoo.com>
Accept-Language: en-US, de-DE
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Enabled=true; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SetDate=2021-08-19T06:15:32Z; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Method=Standard; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_Name=restricted-default; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ActionId=26dae7a6-dee7-418e-a8f0-e88db8fc90a6; MSIP_Label_a59b6cd5-d141-4a33-8bf1-0ca04484304f_ContentBits=0
document_confidentiality: Restricted
x-originating-ip: [144.145.220.67]
Content-Type: multipart/alternative; boundary="_000_63bc02bfef2348edb1b4766d1cc554efsiemenscom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/HgRWkuodSeLSLk8JLTGsXdGHCSE>
Subject: Re: [yang-doctors] [Anima] Yangdoctors early review of draft-ietf-anima-brski-async-enroll-03
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Aug 2021 06:15:43 -0000

Hi Reshad,

From: Reshad Rahman <reshad@yahoo.com>
Sent: Mittwoch, 18. August 2021 23:08

>    reshad> Other comments: - rc:yang-data (RFC8040) is used. While this
>    reshad> seems to be fine, if the voucher- request-async-artifact template
>    reshad> needs to be extended in the future, my understanding is that it
>    reshad> is not possible with yang-data. However, you could use
>    reshad> "structure" and (eventually) "augment-structure" from RFC8791 for
>    reshad> this.
>
> I am probably the guilty party that wrote the YANG.
> I guess I missed your email (seeing Steffen's reply only), and I'll go back to the
> list to find it to understand.
<RR> And I didn't receive Michael's response to Steffen. Not in my Junk folder either.....
[stf] Michael also just received my response to your email. ANIMA WG was in cc so I’m not sure what happened.


I saw that the constraint voucher follows the same approach.
<RR> Where is the constraint voucher defined?
[stf] https://datatracker.ietf.org/doc/draft-ietf-anima-constrained-voucher/

> We do want to mix and match the various extensions.
> It is not clear to me how to do that.
Maybe related to this, would it be better to augment the voucher than as requested by Reshad or the voucher-request as we currently do it. I also had a look into the constraint voucher as there are also enhancements defined. So I guess I should go with the augmented voucher?
<RR> I didn't see a voucher-request node but I'm probably looking for the wrong thing.
[stf] You answered this already with your hint in the previous email. We cant augment the yang-data is what I understood as it does not allow augmentation.


Best regards
Steffen

>    > We will discuss this point. Currently there is no explicit need for
>    > enhancements.
>
>    reshad> - Prefix "ivr" is used for ietf-voucher-request although RFC8995 has
>    reshad> "vcr". While this is valid, I am curious why.
>
> I didn't think the prefix had relevance outside of the module, but I don't know a
> lot here.
<RR> It doesn't. It's just usually people use the same prefix as defined in the module. No big deal if you want to use a different one, I was just curious why.

Regards,
Reshad.

I meanwhile changed it to vcr. If it has no relevance outside the module, it should not be a problem

Regards
Steffen

>
> --
> ]              Never tell me the odds!                | ipv6 mesh networks [
> ]  Michael Richardson, Sandelman Software Works        |    IoT architect  [
> ]    mcr@sandelman.ca<mailto:mcr@sandelman.ca>  http://www.sandelman.ca/ <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.sandelman.ca%2F&data=04%7C01%7Ccef9763c-149c-4881-b9c2-5fedc277663a%40ad011.siemens.com%7Cb2b4f58606d1406a886b08d9628c4028%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637649176775498908%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=UD3E8EaOSYSCy8yqbocjCgtjCZgYXQlOis4fXLSe4iE%3D&reserved=0>       |  ruby on rails    [