IETF Logo Mail Archive

Re: [yang-doctors] [Lsr] Yangdoctors last call review of draft-ietf-isis-sr-yang-19

Reshad Rahman <reshad@yahoo.com> Mon, 22 January 2024 14:07 UTC

Return-Path: <reshad@yahoo.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E2754C14CF0C for <yang-doctors@ietfa.amsl.com>; Mon, 22 Jan 2024 06:07:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.108
X-Spam-Level:
X-Spam-Status: No, score=-2.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tvye15Cyubxm for <yang-doctors@ietfa.amsl.com>; Mon, 22 Jan 2024 06:07:12 -0800 (PST)
Received: from sonic321-26.consmr.mail.bf2.yahoo.com (sonic321-26.consmr.mail.bf2.yahoo.com [74.6.133.81]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 46C36C14CEF9 for <yang-doctors@ietf.org>; Mon, 22 Jan 2024 06:07:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1705932431; bh=xPpiXFSd8gPhyv+WXL+ev0+sNyIMqFg6tHsbLgtk4Pw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=c3ATcC0YwSdonOo9tthuOLXlFxXqZNXKqkA3XLJE19Stt5R2neCB4B+Sdqp87QE7zMSwk88l1JsmqSxCoCjr4JEO5e41iOkX4YcSG2+tK9E1iWbXSkuIxvhurxq98TsA7Pd/q9PygBX9RL8rDLWgV14PIubLkf7MnkOT2CCc9rLzc12H6gct22m3UZTneSySwG/RfcSZUD8AcpMdOfy+j/O6BAihwlvctMgRkNq6O0ifHbXeAIT8Og6L/LvdWavjiJFy77dls9QDuEI1chxVekgIVPePe0uCW0RItWg4EWhLeKQyWtvqKHW+oX71UmI9vMNAR4SfjXlpdzyKWyIrUQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1705932431; bh=m7czvAVBhW8gdouaNqEonPRGgIyRlUGPwFRAQULaAsf=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=fHCm5+55smHAA8kWQfAzDKhvi3vskxgBgDD0ri7t46Yx2Z4dDqJxtjWrDKilEnAsGXTCP1LsnPMohp15FAdYE0zszt2cPbZeQspLTZpROa7a+vhE8lsxh9KbY5ug96kyiacF85peaFETwy7QoF64Wfh+bK2I/TGbYh9k9LhPMhDSJFbl9EnwYmvxhlUUfH4FD7/6hxuyipM1TwOmJTn3mqLD6FAZV8Y9hkJqEbIF3Nqbdzsx36ruHDyGxuIoh+Bmhv0rc1/6wlB8XrQHYhF2c1EgIgLi5H8g5pug/hE7QO2SQ2qmFrMEQLeNX/OtlSyzoaAl/c+Njvd6NHyWkoEKYA==
X-YMail-OSG: dWjXUxoVM1n_RIsXExn68dQT5TQBpTMPWWslczmxrz4G8qsyp8AUGHRVaqfsuq_ 7Zu9v25obipmApxlnd4CHx3hng4YUXZ0lWaeIGgFhtOMUXYqdN8EPqkmyBSqizkFzuxe3SjyiKuP 7cXLRLAsaRLeMx.haUDXF4VFoDzmb9T1QSF46R6THx.ENbIGIOptmv2r6vIgxag7HZ0DT0p42Ulc M6Xx1dsdiR_WQ6CjcgGP830VGoVzHLC843WwmHy9TcsDuKq6uMtjLcJK7ACvHL3VAVaEkN5gCklB d3yxki6LeY2nPTfaT8jSw3UtjiQJUlyptJW.oGZ2ddo9teLX1bH8odVgyX61k_P7xSgvfavS.vF9 lghw8SEgMJCL9_qfk_AcO36I1aarMnlpal5GeYYgKtwuaOBx0xrjdvMvmozelNcGKB8UbPFk0TEb o_rx1DgdeEcd2kBLUBVfBUgDRObciC3xFN8kzzpEGNl5lhwMQheHY_M4AucJqwmRf7qpD5zuJNlB 07LWNGyBGZWfxNrRPrWIpDfA1M_XJUVeMcTVH6E6G7.r33sGoCYI6GkFV_5zAvAb.OcaKe9827GD OHgBu3jBmG5SwGewayava9VbAkpWQv1rezMGgKo97ImiMmbtS43NgDdm3_08Z6cZ2uDbsXqqkuja GvlmStI9pU6cUBtR6d00l8I7mgpgokmQar.n_deJnvjh9OlOjEdLJJyO1.2fTmW4G1G1HKsTNtY8 RNeuFD0C4WXB_ilcHM1aLI.sS9FvwFlC9KE._9aduGiI.LfB1PUxn67O_6MRPtDXRrPJDepcaHyq IbJnBtD6JSvLIAtcnJDG.U5XFw7BAPK3RMnjpT3DrOXh0j3N8tzTzv8LTlX0iO_BCZp0cPGKfrAI 3gvneDwE.6YJBYzadpsmRrpqKehJ20CCxXSuUV8HB9n5U130OFPImJ.csSb6Zqfcel9PfSXQIWkL OJ9XKwDbS0XSd5aPyybdKqasbq_i8VCNztWvk29JcC4b65KvNQ95PSn5IXNWRdhEhu70TSho8kxu qASJrUy7dIncJJ31R8jO1zOlYSJd2I0WW5uK.eEmUXgfKOt.p8iWqNThPAImBb8Fpw2EAuRKA0gq pSV8QVGbdI0Kjf4s.TbveU8wet5EbNg8E6JQdqGvAR3vq8HywEvqqQzSKKPsogvBYUPjmxaRaBXX K.hX.0SoS601RMB6VmHBlnIEFZ9ZgYlkt.BRcGDwTMwo0VPrXGSHbyQeK4V1f3nweQruIKkhLRuW WTTl2cajfwSK_Q1UnkCQIIra69mboyymLyhcy8PprS1DXe9RhcgxNQEu4GZULibNQSblUmx.9jlG m9.pBFD5_YVTiWeY4yeN.jNNQ9x1Q_G6xWoifXLeh5mYo0ITuuYLqMa0v70AQHPXX1sqN.slW4bW LCeEEEEjPSttWFxJlp8xYfz5_KBxocP_lDN4F.Ni8ydHaiK3svowbA4IIAxvq55pFu0eVBGWBDDR ZeLxFijPe6i3TBgiBDgUis6_i8zzx2LUth___Yf09tTbX4wj_x7OAbeemePq425zCeVDvUDwDi7L wEdhQHw1foOjx6wrxGitq14Nysp57IPAV49m61ZTBv45lsg1T_yRFARxfndCF2LwRy8HowBwt9uR 8.XuMEnSls1L8NEGmzWll67b70Reks_jIuZ5LiGir9zPnvFhddDLJus5t9GCxkvYWHKUKLEnLbEx dRT4YzyUwfZ6WFnrxd57mHGGB6Uj3L9obWxzrc_WiZP02GUaP80RZ.IFAzAVQoKJlyQaxNzZFr8l MZn8tkuFwTaN6X4_qpFmuN2apu9cmylKk_0QdRJjJORvbXUOLrDJPmX4n4WcUDIUmNdphYimnGpQ SaPfBapVATOgzStJEmNr5g9Apw4X9Fd3eQSizlPl2FXnk4agL40ZtZznngey4UCKw3GZC7LuG7M0 TJIJPYC4nBYiaFdcCFQKBI40elQTwitFNzdMi7xJnUEDXJbqsLjM0Nqw50dDaphuXzzfmOVi_e.H ffGhhdps5QHxfm.l_6wMcLIwZ72829hoiObU8Jpl0spTsumE0vOLOQy5AYvus_ZjA_zxW599Y4Ic fVBEgtu2SfxpaSmmz7RConobJCi1ONLo9E0EyZLV43v2txUAFYW5SeaG8v8UqrE1ZKgfU14Pp9XS jK9YBTALIjhzB1dqxonax05kIPi_oBNZEPAU6zqNgdp6s3mV4m9VY6aCk5.kVKOYg.TwjBknqxxc Cgyd_wxnWQEIVPJ4RAlAWDHiRnyx_D35H4TA5oTXHljhR5nBSc0ON4V0aoazCocD6tbxmbR5yhqd Z_sdS3Gq6S3UIWy9W.wx80RyNMJ5ig5.DP..p7uimkTc0vw46SqHj
X-Sonic-MF: <reshad@yahoo.com>
X-Sonic-ID: feb48f6c-ec3f-4e93-8e2f-0d5e7707d451
Received: from sonic.gate.mail.ne1.yahoo.com by sonic321.consmr.mail.bf2.yahoo.com with HTTP; Mon, 22 Jan 2024 14:07:11 +0000
Date: Mon, 22 Jan 2024 14:07:06 +0000
From: Reshad Rahman <reshad@yahoo.com>
Reply-To: Reshad Rahman <reshad@yahoo.com>
To: Yingzhen Qu <yingzhen.ietf@gmail.com>
Cc: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-isis-sr-yang.all@ietf.org" <draft-ietf-isis-sr-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Message-ID: <1578607120.745334.1705932427000@mail.yahoo.com>
In-Reply-To: <457672390.513436.1705794832190@mail.yahoo.com>
References: <170519187203.2829.6087985821024655929@ietfa.amsl.com> <CABY-gOPzVTaCxfV=AWQwnitxyvMZUZozJP1mERZKn-8WDGeerA@mail.gmail.com> <457672390.513436.1705794832190@mail.yahoo.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_Part_745333_1541158559.1705932426999"
X-Mailer: WebService/1.1.22027 YMailNorrin
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/_dMR644X-JXK3JbFNe9_DQ6ozXc>
Subject: Re: [yang-doctors] [Lsr] Yangdoctors last call review of draft-ietf-isis-sr-yang-19
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2024 14:07:13 -0000

 Hi,
Typically we have a container (plural) including a list (singular). In -20 it was done the other way round. Since this is read-only, IIRC we don't need the container including a list as we do for read-write. Is the container there for convenience?
Regards,Reshad.

  augment /rt:routing/rt:control-plane-protocols
          /rt:control-plane-protocol/isis:isis/isis:database
          /isis:levels/isis:lsp:
    +--ro sid-binding-tlvs* []
    |  +--ro sid-binding-tlv
    |     +--ro prefix?                inet:ip-prefix
    |     +--ro range?                 uint16
    |     +--ro sid-binding-flags
    |     |  +--ro flags*   identityref
    |     +--ro prefix-sid-sub-tlvs* []
    |     |  +--ro prefix-sid-sub-tlvs
    |     |     +--ro prefix-sid-sub-tlv* [sid]
    |     |        +--ro prefix-sid-flags
    |     |        |  +--ro flags*   identityref
    |     |        +--ro algorithm?          identityref
    |     |        +--ro sid                 uint32
    |     +--ro sid-sub-tlvs* []
    |     |  +--ro sid-sub-tlv
    |     |     +--ro length?   uint8
    |     |     +--ro sid?      uint32
    |     +--ro unknown-tlvs
    |        +--ro unknown-tlv* []
    |           +--ro type?     uint16
    |           +--ro length?   uint16
    |           +--ro value?    yang:hex-string
    +--ro mt-sid-binding-tlvs* []
       +--ro mt-sid-binding-tlvs
          +--ro prefix?                inet:ip-prefix
          +--ro range?                 uint16
          +--ro sid-binding-flags
          |  +--ro flags*   identityref
          +--ro prefix-sid-sub-tlvs* []
          |  +--ro prefix-sid-sub-tlvs
          |     +--ro prefix-sid-sub-tlv* [sid]
          |        +--ro prefix-sid-flags
          |        |  +--ro flags*   identityref
          |        +--ro algorithm?          identityref
          |        +--ro sid                 uint32
          +--ro sid-sub-tlvs* []
          |  +--ro sid-sub-tlv
          |     +--ro length?   uint8
          |     +--ro sid?      uint32
          +--ro unknown-tlvs
          |  +--ro unknown-tlv* []
          |     +--ro type?     uint16
          |     +--ro length?   uint16
          |     +--ro value?    yang:hex-string
          +--ro mt-id?                 uint16    On Saturday, January 20, 2024, 06:53:52 PM EST, Reshad Rahman <reshad@yahoo.com> wrote:  


[Yingzhen]: Thanks for catching this. I've updated the description.<Reshad> I looked at the changes in -20. That grouping is now gone and the (mt-)sid-binding-tlvs lists have no key, is that the intent?Also container mt-sid-binding-tlvs should be renamed to mt-sid-binding-tlv.

v2.23.0 | Report a Bug | By Email