Re: [yang-doctors] [Lsr] Yangdoctors last call review of draft-ietf-isis-sr-yang-19
Reshad Rahman <reshad@yahoo.com> Mon, 22 January 2024 19:52 UTC
Return-Path: <reshad@yahoo.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B4DE8C151990 for <yang-doctors@ietfa.amsl.com>; Mon, 22 Jan 2024 11:52:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.108
X-Spam-Level:
X-Spam-Status: No, score=-7.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 97MzanVMMKkP for <yang-doctors@ietfa.amsl.com>; Mon, 22 Jan 2024 11:52:39 -0800 (PST)
Received: from sonic320-23.consmr.mail.bf2.yahoo.com (sonic320-23.consmr.mail.bf2.yahoo.com [74.6.128.204]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A4ACBC151536 for <yang-doctors@ietf.org>; Mon, 22 Jan 2024 11:52:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1705953158; bh=cARGnmFlG5PnztKXcrEnmjrqpfXf27ZPg8Q0V+pIpFg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=W/vZUyPhHJ4hkgSQ6g3lUtunQpPuwUxmwnQSMyuYkS8OIu2SdKu1q5l2y0GGgoODkiIuKfNCxQVgbbr9fSFRcKQMXqO+1J401dlQaEErVKIrapH065qlYdSkqchDx0MlWTJCDRSI6AONtcvEfoZdGLoZcKLZq04+kECwVHaK7NYNvpWjGzxYRwv56wwosT6q7MClCAuLfkk1Etsycaw4MfgjOs2UQqLiKK8f4HPUq8rtkEOgkZ5iMa1YQ9KeSP2Sd8JzOv7iA+17V7b/ZcekeY7z0+p2ZgAjYvanQMb3oRXxYgTM8fqMqYuXO6rO5LYeBonGuSnL/0pZ5qa4UhPCyQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1705953158; bh=wc1EYySFiemi/KQP/PCs3COYsNwZpNa2qY2Om/pdVgS=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=o7zIlmhnpgGUPS2fF86m8WeiMfwFy7p+TS2mWImW2uzHIQ3c/95O3elc4xqhHh/U+KCF8h7xol83UhDwJy0hF6QKX2JCf20O28a0ixXHH+kYGAF+YnX4EQqyVyEjcX1HrUidXGBSKajbxuVVoVSVYz5es/3yhbHc7ds0C1SiHjFNGg0N0oIHwSmaWTh4OM4LWy7/rDekVBBAN3FNRNfUUCmGNkD2BsINm8VB+U2aV3fjg4lVN6hNULGGjH4BtVgaLGwGN31cMYNeH7nLV1KxXuVLzSb4/DTdw7qA+VhsOq9E1LMfAqB2IJHfAh6XZi5Gz/LZK8kbPE7QR4DoXl4jOA==
X-YMail-OSG: F7_l0MQVM1nt51DjAyNbfMKr9VfDMpDyivRgw451MyyFtIrtZpZeNUwXXeW1.3D ZVpYgjlj8beCLuC9pzsgqzJ692hWHUIUajiPKjcdInhf4B1sXcjeldKrAWS8Wpmjn1v5xOstG4IQ ZTaVorQ5RvskhWD41cylQ.rLeEm6E5tMJ.fJD8ZD70rudRXaU65D2R_mNvnWuFptvx2ZYilRsbYi 6LjiG.Sueerzjvk79cgEs_QAzgIQHhVfbTbb8Szqp_FfDQar3QhNkJDaLRMAynlPsBhVz2QXrp8c tufT2Rg99OPGdb7.0IiPKvrdKiXEJcI8tLnaorrYS9_rb9kYc6x4PYSaf66HPOzO2Go5oQtogaFf EN8PIuNhcc2y.9kZXwraNwWq8osJITVb9KJ8XCYlfO46G_FjdT6STJuxwDztmg5Ht0sq.2IJbFok GZ1BDMRw0MIsDRGuRX7V2S6u_CKVVg8e95ZBuc4P7QnosoVNLkCF2vXpn8Eg3ys8BIIDbziLX5JW jwDX87svD1wPRzFNMm.9GR1opreCodinXmodNrBzn.f8jB7DFB7HvoWJ0WShbAxKuG3lWCNzdTgb eebADRTtoBtTkB_t.M7ITWnJttKDW5sixQ6Lss6c5ZXf2VFaXnfxtzpguU5OgBK3M62Nr9Chn.et rYxNXRjzXn1FXYGpavjlsM2ecP.CXBTIDchl5ALjGSu_PSC2KWbBUM.jfri42fCW9CB8pBjvzO3A H7YKwA5feSV3btbwhrF6q7P02Spt8eoNuSiKNJ_5wa3z9ovCItqoFc4ikJRwkLl5WNMTPTbyUVlg IUTyzH1FLezhxudyvrnKd1T55ptycJYMD_TT5zst13vmIfpNf8JN4utHV5poAw6u_bYHOxnSN0gE Jyf8Wv65MmD5aiGVKqusLbqlZ9sB.F5VssF4cBHpuesHfssLdlLZb1wp5yskNZb4lORuYppgJHBV BYcsa_b0v2LFGWL67ez4AaJydtZaMvwIzv2sH_4F4N40dje2SF5.Q9bllef1irzEdTlkEIlcJ4jd c5T581AhSJh9WVlK0SZYPK0p8ohYLBk3jg.KpvDJZa4VJvdJ.YX6SbSYv2lJZQQFioLdvPR4eVqr OtiQq3dQVZp8uvHKS2s6gq0BrJhkdFWC3ooqNNyZinSDCjy7al3a3EGmztQ.yI6GS1TdWW4gDhZd Me49LK84le3vas35Be3LAWX4OM_smsNA3Rz4nNQugS63aHme9HAq1izlysIbSZ5Rh3n4ujFFBHla 5uHCWP6r7qIyEshnTl2_Gl3ruHo1qDQKMWoY1p1M3HlN6NSqlBJVjGe8uxva5Gs1Z7BiwehaHouE 9445B.g_PJYR8zP_CpxZid941aa0QAvo4VGyy5mwz9FPVGBgodwFBDvxYD3N_PUWA1lUrKtslwpN 5i_mvbCnbS3EzATAJfdAZ3Cp1ebRY0O8Dj.nguFFahcCAparNEMjY2fUyPb80.NMlvWfrc4aQaGn w.QCVCgRNWmw2anKNDmMg2IZFa6SbHFn8DiCEXyCW5MmBeqWClAMFJDBlGFblC.4FRbNb__8gWtV bp6gDiBn5E7kCuezMLCv9tP.tyeruxF_xx.dj3VjUPjf.5xvhp3xhjGhH20o9rNxDOT9b0zPiVWp EmhlenKjcycODchxivjrByuAobVuzU_larL7_nQxylJCpZVRtkJnvz6atZHhmqI2wx5X8s175u4p Kzr924lLHDXuiJwOmKsgMevIQYr8oV5ieU7_xLfnwvTpWmIAbf8CrOhuBKk5JX7FKMd_TRP.bFji 3pmqbF.ACnusegGcBIjZumZttKudyzzvbQ2Nff31P51Zmpl2_XXxYBnmCBpXZasJzyUEhaPSszot hmU0NZZMJqntuiHMVoujhDFX86pokLGwt4JMm8k5HqZN_r.CJrAQLzApi59y1mP6ZTpG.ssg5AH0 1oWmBIRXkycj0yHZuxm7ww67dun.aicv4Ebp5hnYiQwaGwKSOOGVogP6GUTDGg1KL4EmbmB6JHmh pqyRjYakD8p2v6dp65MdRkSCpynFgk86JXBlboXpxvBWtzZwfH.aiZRNxLyWhEi31myaPJHkeBji fds6WNnn9ChAwWBdMFdYoWzkTUviR2Sp1fFW815fwWygZ0JOun133a21r4VdxXVqJuWXvjPVheoB QBptSFHZTspC8pKD4RpBR3Rvb3tHRkD_hPXviXcJW4uBOGKU2qhf_D5Qp.R.bo60etixNYefqq9C YK7ZqFsBgoUPAck_5pAXrjr67UQskdNeF7XKAKWIOlzWJZ.e53XM69AQzADqh1PjKTt7IsJMDZyq uvz5onT.HARk2omrhb_7sPhnk
X-Sonic-MF: <reshad@yahoo.com>
X-Sonic-ID: ab20af6d-803b-4448-a04c-49325357efc1
Received: from sonic.gate.mail.ne1.yahoo.com by sonic320.consmr.mail.bf2.yahoo.com with HTTP; Mon, 22 Jan 2024 19:52:38 +0000
Date: Mon, 22 Jan 2024 19:52:37 +0000
From: Reshad Rahman <reshad@yahoo.com>
Reply-To: Reshad Rahman <reshad@yahoo.com>
To: Yingzhen Qu <yingzhen.ietf@gmail.com>
Cc: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-isis-sr-yang.all@ietf.org" <draft-ietf-isis-sr-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Message-ID: <1810383000.864133.1705953157608@mail.yahoo.com>
In-Reply-To: <CABY-gOO1utYVBes7Uy+oJCnY0k0HntO+bps2-aAGr1PMCSgXEw@mail.gmail.com>
References: <170519187203.2829.6087985821024655929@ietfa.amsl.com> <CABY-gOPzVTaCxfV=AWQwnitxyvMZUZozJP1mERZKn-8WDGeerA@mail.gmail.com> <457672390.513436.1705794832190@mail.yahoo.com> <1578607120.745334.1705932427000@mail.yahoo.com> <CABY-gOO1utYVBes7Uy+oJCnY0k0HntO+bps2-aAGr1PMCSgXEw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_Part_864132_375735983.1705953157606"
X-Mailer: WebService/1.1.22027 YMailNorrin
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/hyTfkZVv_Q5R0lIgkNySQOua0u0>
Subject: Re: [yang-doctors] [Lsr] Yangdoctors last call review of draft-ietf-isis-sr-yang-19
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2024 19:52:41 -0000
Thanks Yingzhen. Yes I am good with that. Regards,Reshad. On Monday, January 22, 2024, 02:39:17 PM EST, Yingzhen Qu <yingzhen.ietf@gmail.com> wrote: Hi Reshad, Thanks for the review. The "sid-binding-tlv" and "mt-sid-binding-tlv" are relatively big with more content, so I thought it might be easier to read with a container. But you're right, it's not following the YANG traditions, how about the following? container sid-binding-tlvs { list sid-binding-tlv { key "prefix"; uses sid-binding-tlv; description "Sid/label binding TLV, type 149."; } description "List of sid/label binding TLVs."; } container mt-sid-binding-tlvs { list mt-sid-binding-tlv { key "prefix mt-id"; uses sid-binding-tlv; leaf mt-id { type uint16; description "A 12-bit field containing the non-zero ID of the topology."; } description "Multi-Topology SID/Label binding TLV, type 150."; reference "RFC 8667 - IS-IS Extensions for Segment Routing, Section 2.5"; } description "List of multi-topology sid/label binding TLVs."; } Thanks,Yingzhen On Mon, Jan 22, 2024 at 6:07 AM Reshad Rahman <reshad@yahoo.com> wrote: Hi, Typically we have a container (plural) including a list (singular). In -20 it was done the other way round. Since this is read-only, IIRC we don't need the container including a list as we do for read-write. Is the container there for convenience? Regards,Reshad. augment /rt:routing/rt:control-plane-protocols /rt:control-plane-protocol/isis:isis/isis:database /isis:levels/isis:lsp: +--ro sid-binding-tlvs* [] | +--ro sid-binding-tlv | +--ro prefix? inet:ip-prefix | +--ro range? uint16 | +--ro sid-binding-flags | | +--ro flags* identityref | +--ro prefix-sid-sub-tlvs* [] | | +--ro prefix-sid-sub-tlvs | | +--ro prefix-sid-sub-tlv* [sid] | | +--ro prefix-sid-flags | | | +--ro flags* identityref | | +--ro algorithm? identityref | | +--ro sid uint32 | +--ro sid-sub-tlvs* [] | | +--ro sid-sub-tlv | | +--ro length? uint8 | | +--ro sid? uint32 | +--ro unknown-tlvs | +--ro unknown-tlv* [] | +--ro type? uint16 | +--ro length? uint16 | +--ro value? yang:hex-string +--ro mt-sid-binding-tlvs* [] +--ro mt-sid-binding-tlvs +--ro prefix? inet:ip-prefix +--ro range? uint16 +--ro sid-binding-flags | +--ro flags* identityref +--ro prefix-sid-sub-tlvs* [] | +--ro prefix-sid-sub-tlvs | +--ro prefix-sid-sub-tlv* [sid] | +--ro prefix-sid-flags | | +--ro flags* identityref | +--ro algorithm? identityref | +--ro sid uint32 +--ro sid-sub-tlvs* [] | +--ro sid-sub-tlv | +--ro length? uint8 | +--ro sid? uint32 +--ro unknown-tlvs | +--ro unknown-tlv* [] | +--ro type? uint16 | +--ro length? uint16 | +--ro value? yang:hex-string +--ro mt-id? uint16 On Saturday, January 20, 2024, 06:53:52 PM EST, Reshad Rahman <reshad@yahoo.com> wrote: [Yingzhen]: Thanks for catching this. I've updated the description.<Reshad> I looked at the changes in -20. That grouping is now gone and the (mt-)sid-binding-tlvs lists have no key, is that the intent?Also container mt-sid-binding-tlvs should be renamed to mt-sid-binding-tlv.
- [yang-doctors] Yangdoctors last call review of dr… Reshad Rahman via Datatracker
- Re: [yang-doctors] Yangdoctors last call review o… Yingzhen Qu
- Re: [yang-doctors] [Lsr] Yangdoctors last call re… Reshad Rahman
- Re: [yang-doctors] [Lsr] Yangdoctors last call re… Reshad Rahman
- Re: [yang-doctors] [Lsr] Yangdoctors last call re… Yingzhen Qu
- Re: [yang-doctors] [Lsr] Yangdoctors last call re… Reshad Rahman
- Re: [yang-doctors] [Lsr] Yangdoctors last call re… Yingzhen Qu