Re: [yang-doctors] Review of draft-wu-l3sm-rfc8049bis?

Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> Thu, 05 October 2017 16:11 UTC

Return-Path: <j.schoenwaelder@jacobs-university.de>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4DF7B133087; Thu, 5 Oct 2017 09:11:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UzYzO3JYlJ7B; Thu, 5 Oct 2017 09:11:53 -0700 (PDT)
Received: from atlas5.jacobs-university.de (atlas5.jacobs-university.de [212.201.44.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 72DF31342CB; Thu, 5 Oct 2017 09:10:41 -0700 (PDT)
Received: from localhost (demetrius5.irc-it.jacobs-university.de [10.70.0.222]) by atlas5.jacobs-university.de (Postfix) with ESMTP id 4EA5034; Thu, 5 Oct 2017 18:10:40 +0200 (CEST)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from atlas5.jacobs-university.de ([10.70.0.217]) by localhost (demetrius5.jacobs-university.de [10.70.0.222]) (amavisd-new, port 10032) with ESMTP id FbATP2F3Cojs; Thu, 5 Oct 2017 18:10:38 +0200 (CEST)
Received: from hermes.jacobs-university.de (hermes.jacobs-university.de [212.201.44.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hermes.jacobs-university.de", Issuer "Jacobs University CA - G01" (verified OK)) by atlas5.jacobs-university.de (Postfix) with ESMTPS; Thu, 5 Oct 2017 18:10:40 +0200 (CEST)
Received: from localhost (demetrius1.jacobs-university.de [212.201.44.46]) by hermes.jacobs-university.de (Postfix) with ESMTP id 244F220107; Thu, 5 Oct 2017 18:10:40 +0200 (CEST)
X-Virus-Scanned: amavisd-new at jacobs-university.de
Received: from hermes.jacobs-university.de ([212.201.44.23]) by localhost (demetrius1.jacobs-university.de [212.201.44.32]) (amavisd-new, port 10024) with ESMTP id Fqu2mNJJ40N0; Thu, 5 Oct 2017 18:10:39 +0200 (CEST)
Received: from elstar.local (elstar.jacobs.jacobs-university.de [10.50.231.133]) by hermes.jacobs-university.de (Postfix) with ESMTP id 5584620105; Thu, 5 Oct 2017 18:10:39 +0200 (CEST)
Received: by elstar.local (Postfix, from userid 501) id 435264121E7C; Thu, 5 Oct 2017 18:10:39 +0200 (CEST)
Date: Thu, 05 Oct 2017 18:10:39 +0200
From: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
To: Adrian Farrel <adrian@olddog.co.uk>
Cc: 'Jan Lindblad' <janl@tail-f.com>, 'Lou Berger' <lberger@labn.net>, 'YANG Doctors' <yang-doctors@ietf.org>, draft-wu-l3sm-rfc8049bis.all@ietf.org
Message-ID: <20171005161039.rgxdyqlzkg7a4pqn@elstar.local>
Reply-To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>
Mail-Followup-To: Adrian Farrel <adrian@olddog.co.uk>, 'Jan Lindblad' <janl@tail-f.com>, 'Lou Berger' <lberger@labn.net>, 'YANG Doctors' <yang-doctors@ietf.org>, draft-wu-l3sm-rfc8049bis.all@ietf.org
References: <262fdd36-5213-f716-016a-02442c427a0a@labn.net> <EA5D631C-818D-4F84-83C9-26B8A2D73A70@tail-f.com> <196ce82f-2bc3-18c5-4232-2a874efb5062@labn.net> <50B59D11-E865-4025-AAFA-7E2505B540B9@tail-f.com> <20171005140709.xdzqbhyanhpzkyzi@elstar.local> <015901d33de8$083822c0$18a86840$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <015901d33de8$083822c0$18a86840$@olddog.co.uk>
User-Agent: NeoMutt/20170714 (1.8.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/jfER5ZzSm8-Ci8mSGSqozSSMTxM>
Subject: Re: [yang-doctors] Review of draft-wu-l3sm-rfc8049bis?
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Oct 2017 16:11:56 -0000

Adrian,

I do not understand the details why RFC 8049 is fundamentally
broken. The abstract of the ID says:

   If approved, this document obsoletes RFC 8049.  The changes are a
   series of small fixes to the YANG module, and some clarifications to
   the text.

This does not read like fundamentally flawed and not implementable.
That said, I did react to Jan's statement that kind of indicated that
these changes are generally OK - which I think they are not.

If this document chooses to not follow the YANG update rules, I think
this should be supported by a clear documentation why this is
considered to be OK, somewhere in the document.

/js

On Thu, Oct 05, 2017 at 03:41:28PM +0100, Adrian Farrel wrote:
> Pardon me for asking for some help getting this straight in my head.
> 
> When we move from one version of an I-D to another, we don't pay any attention
> to backward compatibility.
> 
> When we revise an established module we must be backward compatible to allow the
> new version to be inserted without damaging existing implementations, or we must
> call the module something new to avoid confusion.
> 
> When we have a module that cannot be implemented (because it is broken) and that
> is being fixed through the obsoleting of an RFC, do we *really* care about
> backward compatibility? If we do care, then the answer is simple: we revise the
> module name, etc. If the issue isn't a big deal, we go ahead as written.
> 
> Thanks,
> Adrian
> 
> > -----Original Message-----
> > From: Juergen Schoenwaelder [mailto:j.schoenwaelder@jacobs-university.de]
> > Sent: 05 October 2017 15:07
> > To: Jan Lindblad
> > Cc: Lou Berger; YANG Doctors; draft-wu-l3sm-rfc8049bis.all@ietf.org
> > Subject: Re: [yang-doctors] Review of draft-wu-l3sm-rfc8049bis?
> > 
> > On Thu, Oct 05, 2017 at 03:44:24PM +0200, Jan Lindblad wrote:
> > > Lou,
> > >
> > > > What about the type changes (int32->int64,
> > >
> > > This is a backwards compatible change according to both 6020 and 7950.
> > >
> > > > int->string)?
> > >
> > > Even if a type change int->str might qualify as "backwards compatible"
> > according to 6020 and 7950, the particular change at hand is not because of
> > considerable changes in semantics.
> > 
> > I think both type changes are problematic. RFC 7950 says:
> > 
> >    o  A "type" statement may be replaced with another "type" statement
> >       that does not change the syntax or semantics of the type.  For
> >       example, an inline type definition may be replaced with a typedef,
> >       but an int8 type cannot be replaced by an int16, since the syntax
> >       would change.
> > 
> > /js
> > 
> > >
> > > /jan
> > >
> > >
> > > > On 10/5/2017 9:27 AM, Jan Lindblad wrote:
> > > >> Lou,
> > > >>
> > > >> I have reviewed the updated model from a YANG perspective. The old
> > model contained syntax errors(!), so there was no way to (correctly) implement
> > it. Hence I believe requirements on backwards compatibility should be treated
> > lightly.
> > > >>
> > > >> /jan
> > > >>
> > > >>
> > > >>
> > > >>> Hi,
> > > >>>
> > > >>>    Has there been a review conducted or is there one planned for
> > > >>> draft-wu-l3sm-rfc8049bis?  If not, I think one is needed.  I'm looking
> > > >>> at it now as part of RtgDir review and I believe some non-backwards
> > > >>> compatible changes in the defined yang module.
> > > >>>
> > > >>> Thanks,
> > > >>> Lou
> > > >>>
> > > >>> PS for module diffs see:
> > > >>>
> > > >>> https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-wu-l3sm-
> > rfc8049bis-05.txt&url1=rfc8049
> > > >>>
> > > >>> _______________________________________________
> > > >>> yang-doctors mailing list
> > > >>> yang-doctors@ietf.org
> > > >>> https://www.ietf.org/mailman/listinfo/yang-doctors
> > > >>
> > > >
> > >
> > > _______________________________________________
> > > yang-doctors mailing list
> > > yang-doctors@ietf.org
> > > https://www.ietf.org/mailman/listinfo/yang-doctors
> > 
> > --
> > Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> > Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
> > Fax:   +49 421 200 3103         <http://www.jacobs-university.de/>
> 

-- 
Juergen Schoenwaelder           Jacobs University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
Fax:   +49 421 200 3103         <http://www.jacobs-university.de/>