[Anima] Significant nits in draft-ietf-anima-bootstrapping-keyinfra-41

Brian E Carpenter <brian.e.carpenter@gmail.com> Tue, 28 April 2020 01:44 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: anima@ietfa.amsl.com
Delivered-To: anima@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 574403A0B95; Mon, 27 Apr 2020 18:44:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VYxMJ9hb_ejt; Mon, 27 Apr 2020 18:44:48 -0700 (PDT)
Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 25F393A0B9D; Mon, 27 Apr 2020 18:44:44 -0700 (PDT)
Received: by mail-pj1-x1041.google.com with SMTP id h12so512588pjz.1; Mon, 27 Apr 2020 18:44:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:organization:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=a6DdVDXHrI+fVUBdugDh7CRWfKszYxISmQiEecqgaAE=; b=Zrn/SD/7TluCT9F+0JSwFxG+WI/TgNYs3WieGUXVkDFuQji3WtGUWxHywDim+MExfC rMH3GTChcuYQ72qUzfFRibbazAHh6NOIEj8fMJSBR2eCPyNNzYc0ab1M90NdWpU4/oKg lg66oG3D/bWnXcEerR+sW1SBP3rl6pI7J+LwdCqVr2qM+Iyld3ZXaSSqOADtRpZDxl3e kQwWsz9qyK6t9RjvE7QcCeFv3SR+HLT+5h/53CDd94H1986OWXvPmM8TIzVcSDew7DBj Ta1VD6cFR1jWpXGYOYGPNUVsKc1PqO6u6lOO2gArOo7SWwlSZTUh6nb6AjpGa5wP46XW zHaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:organization:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=a6DdVDXHrI+fVUBdugDh7CRWfKszYxISmQiEecqgaAE=; b=s1AU63qpKT8DSDR/W/zD7je6S6hVPGlJRkV7dpsPIdEPl8O+rMF6yzZ+pARwJwEN9D M4vNPesw6zkFkMSb6RjAwNGb3dQ53lknRb1kEyC5emVFGZLfPR2SBvoEdHwdB2e0QAVt yY8EYQto7onkx8/ImOIErD1/QQmPXWKKNb8uQ8+SlkLmb1sQdPl2ikfHvQ13Rto+RBWE TYzjcQtvFgC34KKt99Y9sKUQJoFK+NebhtWV7x8bjU67whoNEQIMOmuR5rIgvUz0jrZU dn7NKtOsZAMG6k2lRXbnmC9gWl8+Di3ngBq/rY2EU/u+OEgWzNDaTza99gxbhHoS5UjF YYyA==
X-Gm-Message-State: AGi0PubgZZ8K7NssT0vnaSmZ/kdaZh/KGiErDaxg85wHXYBRBw003ACw lSqCe4Ur1vJCj4U1iCONzwYJi4McIvg=
X-Google-Smtp-Source: APiQypJnGAiLw9dOtUg8VxhK0rFMwuobLkWlTti9bRfxNnmVkOazOoY7XtJ0HFfCnwkEoir5Mtj35g==
X-Received: by 2002:a17:90a:aa84:: with SMTP id l4mr1991073pjq.100.1588038283672; Mon, 27 Apr 2020 18:44:43 -0700 (PDT)
Received: from [192.168.178.30] ([165.84.25.143]) by smtp.gmail.com with ESMTPSA id p24sm13523277pff.92.2020.04.27.18.44.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2020 18:44:43 -0700 (PDT)
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
To: Anima WG <anima@ietf.org>, draft-ietf-anima-bootstrapping-keyinfra.all@ietf.org
Organization: University of Auckland
Message-ID: <f18fe6bc-3703-bcad-33ee-696f1b8ecae5@gmail.com>
Date: Tue, 28 Apr 2020 13:44:39 +1200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/anima/XqnpdkPyMnNXPulMovFor5LRR1Q>
Subject: [Anima] Significant nits in draft-ietf-anima-bootstrapping-keyinfra-41
X-BeenThere: anima@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Autonomic Networking Integrated Model and Approach <anima.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/anima>, <mailto:anima-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/anima/>
List-Post: <mailto:anima@ietf.org>
List-Help: <mailto:anima-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/anima>, <mailto:anima-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 01:44:56 -0000

Hi,

Again thanks to Michael Richardson, here are some important nits in the GRASP examples in the BRSKI draft. The CDDL syntax is correct, but the examples need to be corrected as below. The errors are in nesting levels within the flood message, just two pairs of missing [].

I believe these can be corrected editorially, but the authors and shepherd need to take action, since the draft is in the RFC Editor queue.

In Figure 11:

OLD:

   [M_FLOOD, 12340815, h'fe800000000000000000000000000001', 180000,
               ["AN_Proxy", 4, 1, ""],
               [O_IPv6_LOCATOR,
                 h'fe800000000000000000000000000001', IPPROTO_TCP, 4443]]

In Figure 12:

NEW:

   [M_FLOOD, 12340815, h'fe800000000000000000000000000001', 180000,
              [["AN_Proxy", 4, 1, ""],
               [O_IPv6_LOCATOR,
                 h'fe800000000000000000000000000001', IPPROTO_TCP, 4443]]]

In Figure 12:

OLD:

   [M_FLOOD, 12340815, h'fda379a6f6ee00000200000064000001', 180000,
               ["AN_join_registrar", 4, 255, "EST-TLS"],
               [O_IPv6_LOCATOR,
                 h'fda379a6f6ee00000200000064000001', IPPROTO_TCP, 8443]]
        ]

NEW:

   [M_FLOOD, 12340815, h'fda379a6f6ee00000200000064000001', 180000,
              [["AN_join_registrar", 4, 255, "EST-TLS"],
               [O_IPv6_LOCATOR,
                 h'fda379a6f6ee00000200000064000001', IPPROTO_TCP, 8443]]
        ]

Regards
   Brian