Re: [bess] Genart early review of draft-ietf-bess-evpn-unequal-lb-18

Neeraj Malhotra <neeraj.ietf@gmail.com> Mon, 20 November 2023 20:55 UTC

Return-Path: <neeraj.ietf@gmail.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6DD68C1522AF; Mon, 20 Nov 2023 12:55:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OGn_oy5_ivTO; Mon, 20 Nov 2023 12:55:44 -0800 (PST)
Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 930E5C15155C; Mon, 20 Nov 2023 12:55:41 -0800 (PST)
Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-41cc535cd5cso27645051cf.2; Mon, 20 Nov 2023 12:55:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700513740; x=1701118540; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=P48sLmDFK63Fqw6Ggt+LAwottMDM2nHEHf4blylBBQI=; b=FOwXZkQm0QUvkZtMjhhOaYjFAK9vXL+E4alSThJZKKfQckxeGSwEBPHz/nqqduWCzh lfdNGuMAmBtkEIRlGKyi2c0tA/KXmsVMz7XZMWYLnJZlRc2BEUWyUT3mclzAE48IitoN nF5fC2DWHLxS4o0yYJbG2vtlwxtKaR6MCYuXF2egV9ofBO0id6SGoRY1gCIdiiSObiI0 ZZ0viDtyVgEzynrocWbS2fiq07hgk057f098TcX4VOk9WJ1zqXxOnczJTyJ6pLBbZ8C2 tkDuHXnVuv3JWESjpsWaGYBsviqGPKbsabfk5tUiftxboQBKQaWxtQmA35ZGLGdZxX0g D52g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700513740; x=1701118540; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P48sLmDFK63Fqw6Ggt+LAwottMDM2nHEHf4blylBBQI=; b=dq6G0TKZOsBfqx0jOcQv0Lq/gXawfo6zjGVDwyry392QIeYGoSOidlZNsd5BNCupn0 RiF71ltKuJSTzm7ZgdM21KNiKjIhcxFlJYAQpFdQuQptMIFWVGweSPYN+l8zPfSRFy7D GDKkiwFSWViCn1VbiPXL7o9BwLh2WVwXc6jTNtYLYilmPvvVauQ133w9Hb8B3hPAdmRD m1xilts+A7iShngBXQnEw7RFA8v6dTOYUc9uxJ6Nw69hHevGTlihyogI13erQEGa+P2q 8H0oPd0hcIe5fGre9deEKdFEMXKdrdWsqMry7cU/6ypBs4goLRv2DtAAL7AfvO5zpaGO 8jSg==
X-Gm-Message-State: AOJu0Ywpi0Xv9iN16ZwpJg2F4jOhJR+8500gY+vatxgKt5wDpR55Sojx cZOruFhu/KQwx7fxAcJjSnTayprJ0KqWjcx7H4M=
X-Google-Smtp-Source: AGHT+IFfnP2M2AUC8UA8aaoUaQkEBFUQJrjGhOopuBYeurMkAR7WurXllUI4v5o3ixK9GYtks14jCqEF2Xu1fZaYHkM=
X-Received: by 2002:a05:622a:1986:b0:41e:1e0b:a2e7 with SMTP id u6-20020a05622a198600b0041e1e0ba2e7mr12741894qtc.47.1700513740673; Mon, 20 Nov 2023 12:55:40 -0800 (PST)
MIME-Version: 1.0
References: <170015840996.54421.1055029335179226613@ietfa.amsl.com>
In-Reply-To: <170015840996.54421.1055029335179226613@ietfa.amsl.com>
From: Neeraj Malhotra <neeraj.ietf@gmail.com>
Date: Mon, 20 Nov 2023 12:55:29 -0800
Message-ID: <CAF3QiHEs4BALPJDY26Q_iCqo06xGEOgVH6d1N3BiPQ=4jGprBA@mail.gmail.com>
To: Mallory Knodel <mknodel@cdt.org>
Cc: gen-art@ietf.org, bess@ietf.org, draft-ietf-bess-evpn-unequal-lb.all@ietf.org
Content-Type: multipart/alternative; boundary="00000000000072d890060a9bb53e"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/vfewusQFX8Vi0bfhcBS4MiB0VqU>
Subject: Re: [bess] Genart early review of draft-ietf-bess-evpn-unequal-lb-18
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Nov 2023 20:55:48 -0000

Hi Mallory,

Many thanks for the review. Will update the draft and respond by next week.

Thanks,
Neeraj

On Thu, Nov 16, 2023 at 10:13 AM Mallory Knodel via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Mallory Knodel
> Review result: Ready with Issues
>
> I am the assigned Gen-ART reviewer for this draft. Please resolve these
> comments along with any other comments you may receive.
>
> For more information, please see the FAQ at
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
>
> Document: draft-ietf-bess-evpn-unequal-lb
> Reviewer: Mallory Knodel
> Review Date: 16 Nov 2023
>
> Summary: This draft is basically ready for publication, but has nits that
> should be fixed before publication.
>
> Major issues: Section 3 as the Solution Overview seems out of step with the
> remaining sections in that it properly describes the relationships between
> 4, 5
> and 6, but it appears that 7-10 are additional over arching considerations
> that
> might benefit from being extracted from the discussion of direct solutions.
> Suggesting perhaps that 4, 5 and 6 be treated under the solution space,
> whereas
> the remaining substantive sections 7-10 be presented as additional
> considerations and tradeoffs but not direct descriptions of full solutions
> to
> the problems outlined in the introduction.
>
> Minor issues: Not all acronyms are properly expanded in order of their
> first-time use which hinders readability. Seems 12. Operational
> Considerations
> is superfluous and plenty of document dependencies also do not have this
> section.
>
> Nits/editorial comments: The focus of my review did not expose any
> nits/editorial comments though I believe there are some that have persisted
> across the various versions that I compared and I would encourage the
> authors
> to do a full copy edit ahead of IESG submission.
>
>
> _______________________________________________
> BESS mailing list
> BESS@ietf.org
> https://www.ietf.org/mailman/listinfo/bess
>