Re: [bfcpbis] Gen-ART Telechat review of draft-ietf-bfcpbis-rfc4582bis-13.txt
Tom Kristensen <2mkristensen@gmail.com> Thu, 20 August 2015 12:29 UTC
Return-Path: <2mkristensen@gmail.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9CBBB1ACDEF; Thu, 20 Aug 2015 05:29:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2k-GAbnTHQ2z; Thu, 20 Aug 2015 05:29:28 -0700 (PDT)
Received: from mail-la0-x233.google.com (mail-la0-x233.google.com [IPv6:2a00:1450:4010:c03::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E4DEA1A9240; Thu, 20 Aug 2015 05:29:27 -0700 (PDT)
Received: by lalv9 with SMTP id v9so21452247lal.0; Thu, 20 Aug 2015 05:29:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=EKLZkf0RYL+F3RXPvi6Op33S+uib20chLgEr3OSsTKU=; b=P41CcWwH+3RTIUvmQF2twWc2qhcm6s54jusFsS7MAbqtK+rdtxryG8dtkw3ODU3jLn FTDV8rdd+a356rtiKHt5bTFDsbfUoV0e7aZdbRDeN1RcR3GJazHGjo4gYBR4llfMLTOs bO0NZKxZZ8deTdo9rAD+hfKKDoMY7LiVLDF+YoQG40xZrWC2oE94BSqXSeVziF0ugn7r ztHS9sdpK+LWVe1cKndpqQ9HdE5il80ul2rIHuVun1o6pfsvBhuR3jZ0vwfh1gf0Ow2E PxfysT3J4MSZ+hFP4t4hmZ8kP2yznOgi2Usp6w5Gr1hACOSjiZN9sIB1c4qWar7OXhl3 JwEQ==
MIME-Version: 1.0
X-Received: by 10.112.67.65 with SMTP id l1mr2742538lbt.86.1440073766419; Thu, 20 Aug 2015 05:29:26 -0700 (PDT)
Received: by 10.25.85.67 with HTTP; Thu, 20 Aug 2015 05:29:26 -0700 (PDT)
In-Reply-To: <E87B771635882B4BA20096B589152EF628AF7B6F@eusaamb107.ericsson.se>
References: <E87B771635882B4BA20096B589152EF628AF7B6F@eusaamb107.ericsson.se>
Date: Thu, 20 Aug 2015 14:29:26 +0200
Message-ID: <CAFHv=r9CPPDj4tv5HEUc8H6z4sQULfD76rkZADW_AsAmuFDisw@mail.gmail.com>
From: Tom Kristensen <2mkristensen@gmail.com>
To: Suresh Krishnan <suresh.krishnan@ericsson.com>
Content-Type: multipart/alternative; boundary="001a1134800e4c449d051dbd4da4"
Archived-At: <http://mailarchive.ietf.org/arch/msg/bfcpbis/CY2Wc3lvfAOfcxKa5vXgqp4UBXw>
Cc: "draft-ietf-bfcpbis-rfc4582bis.all@tools.ietf.org" <draft-ietf-bfcpbis-rfc4582bis.all@tools.ietf.org>, General Area Review Team <gen-art@ietf.org>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>, Tom Kristensen <tomkrist@cisco.com>
Subject: Re: [bfcpbis] Gen-ART Telechat review of draft-ietf-bfcpbis-rfc4582bis-13.txt
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2015 12:29:30 -0000
Thanks for the Gen-ART review. Response and hopefully a resolution inline below. On 2 March 2015 at 18:19, Suresh Krishnan <suresh.krishnan@ericsson.com> wrote: > I am the assigned Gen-ART reviewer for this draft. For background on > Gen-ART, please see the FAQ at > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> > > Please wait for direction from your document shepherd or AD before > posting a new version of the draft. > > Document: draft-ietf-bfcpbis-rfc4582bis-13.txt > Reviewer: Suresh Krishnan > Review Date: 2015/03/02 > IESG Telechat date: 2015/03/05 > > Summary: This draft has significant issues that needs to be fixed before > it is ready for publication as a Proposed Standard. > > Major: > > * Section 5.1: > > This section mandates the receiver to ignore the F bit if it is set > while running over reliable transport. In my opinion this is not > sufficient as the length of the header is determined by the bit being > set. I strongly believe that this is an error condition and the packet > should not be processed further. At the bare minimum, the draft needs to > specify if the receiver should process the COMMON-HEADER as having 12 > octets or 16 octets in this case. > A problem here as for other fields is coping with senders implementeing the RFC4582 subset only and not the extensions. I can see the problem, but suggest that we keep the text and solution more or less as is. However, I think it is a good idea to tell the receiver to process the received packet as having 12 octets to definitely ignore the F bit in this case. > * Section 6.2.3: > > This section does not explicitly state that each of the fragments needs > to have the COMMON-HEADER included, but it can be inferred since that is > the most logical thing to do. I would prefer that it be explicitly > stated though. > > If my interpretation is correct, then the formula for calculating the > number of fragments is wrong. Instead of > > N=ceil(message size / MTU size) > > it needs to be > > N = ceil( (message size - X) / (MTU size - X) ) > > where X is the size of the COMMON-HEADER with fragment fields (i.e. 16) > if the MTU size is the MTU for UDP. This is needed because the common > header will be repeated on all the fragments. > > e.g. Assume MTU size=1280 and message size=2560 (COMMON-HEADER 16 + 2544 > message) the current formula will yield N=2, while N should in fact be 3 > as the message will not fit in 2 fragments. > Good catch! Yes, we have to adjust the formula and take into the account the added COMMON-HEADER. I'll also add a clarifying text stating that all the fragments indeed need the COMMON-HEADER (of 16 octets length). -- Tom -- # Cisco | http://www.cisco.com/telepresence/ ## tomkrist@cisco.com | http://www.tandberg.com ### | http://folk.uio.no/tomkri/
- [bfcpbis] Gen-ART Telechat review of draft-ietf-b… Suresh Krishnan
- [bfcpbis] Fwd: [Gen-art] Gen-ART Telechat review … Suresh Krishnan
- Re: [bfcpbis] Gen-ART Telechat review of draft-ie… Tom Kristensen
- Re: [bfcpbis] Gen-ART Telechat review of draft-ie… Alissa Cooper