IETF Logo Mail Archive

Re: [bfcpbis] AD Review of draft-ietf-bfcpbis-rfc4583bis-24: role issue - The pull request

Alan Ford <alan.ford@gmail.com> Wed, 19 September 2018 16:45 UTC

Return-Path: <alan.ford@gmail.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 54461130E12 for <bfcpbis@ietfa.amsl.com>; Wed, 19 Sep 2018 09:45:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I0pQv2RpWIYn for <bfcpbis@ietfa.amsl.com>; Wed, 19 Sep 2018 09:45:29 -0700 (PDT)
Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A9BB8130E18 for <bfcpbis@ietf.org>; Wed, 19 Sep 2018 09:45:28 -0700 (PDT)
Received: by mail-wm1-x344.google.com with SMTP id y139-v6so6961709wmc.2 for <bfcpbis@ietf.org>; Wed, 19 Sep 2018 09:45:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=5tRzeQ5OBf/9IsqIaSxa3NJ+vyd512B2YeYsceaM5LQ=; b=V/xznttuhJV4+eDeXYlC2gDTZLi5kP5ze7iyUQgedk1EZtkII09J9ztA37g/y24PJu LJ1lzkHJrYmQOjwzvfXI0za8Zfb/S9HW5J8xg3PWEA860cTjrn/aFJFIkYWtZeqpjTZj PNqhp/OkHoGrktV10+MDCav5qrbQD+eGmzK2fFBfLz/GDorVkjdcrbp2ATm+qwKPxCpd 2iSWTCLgRRmNF32AGDENGsGCB6rs1XPX0jHUtqYlIJ6uMuwsoA45QCr41V+lGSTrCvfY b+S/dIJJy1OYLf59HjRVQTBTgghgL6tpTvhFEvlNJdvfCJmoIekoSZd0sulOAKIaaVqP wmkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=5tRzeQ5OBf/9IsqIaSxa3NJ+vyd512B2YeYsceaM5LQ=; b=QBQNafKU/rmpmAoy8ADNCk9EqsPMha6UK6YM6DtNFWHGPTHmSVaGWgL/D8q4C57fIE S4mgUMSuYvVYha3XmuluZLUnODf0qDroGtkqxoAcv2liLJhKZa+54p1b2wAkKbX6Dvx/ 3EciDLAB2RU6iNH9wV1TZUbg/27yZR7JXF2HwXIUClRDQr0GZ7hJwO6CUSzuckQEsiUH zqXaO0SPYxU3eJJZQTL23IDo1NVMAC11g4WW9o8GYDUsmExvzXVtGtZwddf7G9IQysuT 7T81dnT+tcq9GUD5ZwLp5/LI6O4nL9vDATP5T2Y2Q7LrJaSrePo0omzA2UzKWXGDiMrS CcGA==
X-Gm-Message-State: APzg51BkkpkR7hDnbEQGwKxOq4IMZykwvoxYYGn5fHR5aF8cYcT10ktl wL7Tsgwo77UqBlb8nD7wcn4=
X-Google-Smtp-Source: ANB0VdZQKwDFBsAwtGV2oENza9A9/Qq0uRa1x3BRC9c3JEeBQc5TyL7gtBogVX+uYtYcqyWK/yFDFQ==
X-Received: by 2002:a1c:7c13:: with SMTP id x19-v6mr5313499wmc.27.1537375527127; Wed, 19 Sep 2018 09:45:27 -0700 (PDT)
Received: from [172.20.10.2] (188.29.164.19.threembb.co.uk. [188.29.164.19]) by smtp.gmail.com with ESMTPSA id h10-v6sm7354283wmf.44.2018.09.19.09.45.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Sep 2018 09:45:26 -0700 (PDT)
From: Alan Ford <alan.ford@gmail.com>
Message-Id: <96BA408A-8034-4558-BFEA-2FD2A2FE506C@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_49D7ECE8-9B51-42D3-A1EC-342B00BBD846"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Wed, 19 Sep 2018 17:45:24 +0100
In-Reply-To: <24eb743e07ff4af087ab36f1c4fe050e@ericsson.com>
Cc: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
To: Christer Holmberg <christer.holmberg@ericsson.com>
References: <24eb743e07ff4af087ab36f1c4fe050e@ericsson.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/pSKZG4PM2RHwJL1qPUUpFdwr9Bc>
Subject: Re: [bfcpbis] AD Review of draft-ietf-bfcpbis-rfc4583bis-24: role issue - The pull request
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2018 16:45:31 -0000

Hi Christer, all,

I’ve just added some review comments to the PR. One sentence still needs to be removed, and I think we need to be stronger with the clarification of the deprecation, I propose a paragraph along the lines of:

In RFC4583, there was a third option specified, "c-s", which meant that an endpoint was willing to act as floor control client and floor control server. This feature was not implemented as specified, and the implementations which did signal "c-s" used it to mean that the endpoint is willing to act as floor control client or floor control server. An implementation of BFCPv2 MUST NOT send "c-s" as a floorctl attribute value, but MAY accept "c-s" as equivalent to "c-only s-only".

Regards,
Alan

> On 13 Sep 2018, at 16:43, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
> 
> Hi,
> 
> I have created a pull request for the role issue. 
> 
> https://github.com/cdh4u/draft-bfcp-4583bis/pull/10
> 
> The pull request also updates references but does not address Adam's other issues.
> 
> Regards,
> 
> Christer
> 
> Ps. Note that I do not intend to submit a pull request for 4582bis. If changes are needed, I assume one of the authors will handle that.
> 
> _______________________________________________
> bfcpbis mailing list
> bfcpbis@ietf.org
> https://www.ietf.org/mailman/listinfo/bfcpbis

v2.23.0 | Report a Bug | By Email