Re: [Bier] New Version Notification for draft-chh-bier-bier-yang-01.txt

["Reshad Rahman (rrahman)" <[e-mail]>]

Hi,

Took a look and here are some quick comments:

  *   bitstringlengthenum is defined in a couple of places, instead you should have a typedef and use that typedef for all your bitstringlength leaf nodes. There are also some bitstringlength leaf nodes which are of type uint16, I believe this is incorrect.
  *   Leaf SI, in description spell out the full name “Set identifier”.
  *   Might be good to have a type for BIER base types such as SI, sub-domain ID etc. YANG experts can advise you on this.
  *   For AF, my understanding is that recommendation is to have a list indexed by AF, so you could combine list ipv4 and list ipv6 into 1 list . Please take a look at draft-raza-mpls-ldp-mldp-yang-02 for an example.
  *   For label instead of uint32 you should eventually use mpls-label from ietf-mpls.yang
  *   For bfr-nbr you don’t need to have your own union of  ipv4-address and ipv6-address, use existing ip-address typedef from RFC6021
  *   The BIRT portion needs to be described in section 5, e.g. why that key was chosen etc etc. Not a BIER expert but I am not sure the routing table as modelled is complete/correct.

Regards,
Reshad.

From: "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>
Date: Friday, October 23, 2015 at 2:38 AM
To: Reshad <[e-mail]<mailto:[e-mail]>>
Cc: "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, BIER <[e-mail]<mailto:[e-mail]>>, "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, "Mahesh Sivakumar (masivaku)" <[e-mail]<mailto:[e-mail]>>, "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>
Subject: Re: [Bier] New Version Notification for draft-chh-bier-bier-yang-01.txt

Hi Reshad,
Thank you your comments.
please see inline.Thanks.

Regards,
Ran





发件人:         "Reshad Rahman (rrahman)" <[e-mail]<mailto:[e-mail]>>
收件人:         "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>,
抄送:        "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, "Mahesh Sivakumar \(masivaku\)" <[e-mail]<mailto:[e-mail]>>
日期:         2015/10/22 22:10
主题:        Re: [Bier] New Version Notification for draft-chh-bier-bier-yang-01.txt
发件人:        "BIER" <[e-mail]<mailto:[e-mail]>>
________________________________



Hi,

Repeating the same comments as for 00, the 2 following comments still apply for sure

  *   Please follow RFC6087 guidelines e.g. use of <CODE BEGINS>, <CODE ENDS> etc
  *   <Ran>: OK. we will add it in next version. Thanks
  *   Finally, please use the validator @ http://www.yangvalidator.com/
  *   <Ran>:  Sure, we have used this validator, and have passed.Please see below:

[cid:_1_15E04E2015E0485C002474F548257EE7]

  *

Regards,
Reshad.

From: BIER <[e-mail]<mailto:[e-mail]>> on behalf of "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>
Date: Thursday, October 22, 2015 at 4:59 AM
To: "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>
Cc: "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, "Mahesh Sivakumar (masivaku)" <[e-mail]<mailto:[e-mail]>>, "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>
Subject: [Bier] New Version Notification for draft-chh-bier-bier-yang-01.txt

Hi all，
We have updated draft-chh-bier-bier-yang to 01 version.
The link is：  https://www.ietf.org/internet-drafts/draft-chh-bier-bier-yang-01.txt
Any comments and suggestion are welcome. Thanks.
Regards,
Ran


[e-mail]<mailto:[e-mail]> 写于 2015/10/19 10:27:13:

> 发件人:  [e-mail]<mailto:[e-mail]>
> 收件人:  "Xianxian Dai" <[e-mail]<mailto:[e-mail]>>,
> "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, "Zheng Zhang"
> <[e-mail]<mailto:[e-mail]>>, "fangwei hu" <[e-mail]<mailto:[e-mail]>>,
> "Fangwei Hu" <[e-mail]<mailto:[e-mail]>>, "Ran Chen"
> <[e-mail]<mailto:[e-mail]>>, "Mahesh Sivakumar" <[e-mail]<mailto:[e-mail]>>,
> "Zheng Zhang" <[e-mail]<mailto:[e-mail]>>, "Mahesh Sivakumar"
> <[e-mail]<mailto:[e-mail]>>, "Ran Chen" <[e-mail]<mailto:[e-mail]>>,
> 日期:  2015/10/19 10:27
> 主题: New Version Notification for draft-chh-bier-bier-yang-01.txt
>
>
> A new version of I-D, draft-chh-bier-bier-yang-01.txt
> has been successfully submitted by Ran Chen and posted to the
> IETF repository.
>
> Name:      draft-chh-bier-bier-yang
> Revision:   01
> Title:      YANG Data Model for BIER Protocol
> Document date:   2015-10-16
> Group:      Individual Submission
> Pages:      17
> URL:            https://www.ietf.org/internet-drafts/draft-chh-bier-
> bier-yang-01.txt
> Status:         https://datatracker.ietf.org/doc/draft-chh-bier-bier-yang/
> Htmlized:       https://tools.ietf.org/html/draft-chh-bier-bier-yang-01
> Diff:           https://www.ietf.org/rfcdiff?url2=draft-chh-bier-bier-yang-01
>
> Abstract:
>    This document defines a YANG data model for BIER configuration and
>    operation.
>
>
>
>
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> The IETF Secretariat
>
-----来自 <[e-mail]<mailto:[e-mail]>> 的消息，在 Thu, 23 Jul 2015 20:46:17 +0800 -----
收件人:
        "Reshad Rahman (rrahman)" <[e-mail]<mailto:[e-mail]>>
抄送:
        "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>, BIER <[e-mail]<mailto:[e-mail]>>
主题:
        Re: [Bier] Comments on draft-chh-bier-bier-yang-00

Hi, Rahman,

Thanks for your comments, we will correct it based on your suggestion.

Regards
Fangwei.


"Reshad Rahman (rrahman)" <[e-mail]<mailto:[e-mail]>>
发件人:  "BIER" <[e-mail]<mailto:[e-mail]>>

2015-07-23 19:43

收件人
        "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>,
抄送
        "[e-mail]<mailto:[e-mail]>" <[e-mail]<mailto:[e-mail]>>
主题
        [Bier] Comments on draft-chh-bier-bier-yang-00









Hi authors,

  *   I tried to pyang the model in the draft and ran into quite a few errors. I stopped after the 4 below (these are basic YANG errors, wasn’t even using strict/ietf option)
  *   Once you fix these errors please compile with ―ietf option (sricter rules regarding ordering of statements, requiring description etc etc)
  *   Please follow RFC6087 guidelines e.g. use of <CODE BEGINS>, <CODE ENDS> etc
  *   Finally, please use the validator @ http://www.yangvalidator.com/

Regards,
Reshad.

ERRORS

No “” for the contact
ietf-bier.yang:34: error: unterminated statement definition for keyword "contact", looking at L

Extra “ in "reference "draft-chen-bier-bier-yang-00”;
59: error: unterminated statement definition for keyword "reference", looking at d

Missing ; in key "sub-domain-id"
125: error: unterminated statement definition for keyword "key", looking at l

Missing ; in type if:interface-ref
154: error: unterminated statement definition for keyword "type", looking at }


_______________________________________________
BIER mailing list
[e-mail]<mailto:[e-mail]>
https://www.ietf.org/mailman/listinfo/bier
[附件 "ATT00002.txt" 被 陈然080434/user/zte_ltd 删除]_______________________________________________
BIER mailing list
[e-mail]<mailto:[e-mail]>
https://www.ietf.org/mailman/listinfo/bier