[Bpf] Review of draft-thaler-bpf-isa-01

Watson Ladd <watsonbladd@gmail.com> Tue, 25 July 2023 05:05 UTC

Return-Path: <watsonbladd@gmail.com>
X-Original-To: bpf@ietfa.amsl.com
Delivered-To: bpf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3B4B1C151093 for <bpf@ietfa.amsl.com>; Mon, 24 Jul 2023 22:05:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AfnsL7zq1Dmm for <bpf@ietfa.amsl.com>; Mon, 24 Jul 2023 22:05:05 -0700 (PDT)
Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CAC02C14CE51 for <bpf@ietf.org>; Mon, 24 Jul 2023 22:05:05 -0700 (PDT)
Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5661eb57452so2943624eaf.2 for <bpf@ietf.org>; Mon, 24 Jul 2023 22:05:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690261504; x=1690866304; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=B/xwXppyIbLJPeoOlfM2hAEYUJMKNExGUPkbEqPmmkc=; b=rclDqZY2Y1+l/JvONqMViB53QiO2orLkMg/GvxpsXHfFy4GBAEniGRDM5BUnob+p5n O0sw/FZn7WpcXf/iEpUmYM3EcAFV5zvYt6+RKSjEv4aZddSeh9YsmFr/WFAOC9eN9ojh y2gPwjKPsX/VLqkqL0/gmydQRKLASornw64FeNMvSt926qAAPq5NZX0DLl34RvUwV+8j xE39eZMVTn8zcG4ujckF2nWDYdiBj0TWyYaWK0aHOTiabmW/PJLvDp23sZsySdAUJtRa dzkeuy3qxkzSrsxbhILleYFpB6uq9oHikxqYLw0GH/p8FiNSH5e4qEzhQcHkD7rxvewi xe0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690261504; x=1690866304; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=B/xwXppyIbLJPeoOlfM2hAEYUJMKNExGUPkbEqPmmkc=; b=Bpm8cX7ve+lwOeV+tVwdhiW3l892OTTByKzgXF36V0kwxzYPmY9yhHou0fEDeF7PZM DsWaLqjG1Wv16m/eJ8lgIDrnwlN11pf1ZvPaHhL5LAnIEOx3zX4KkWxXDXdVvincSzZu 2Ifwaxs1xkuUp1mTYnF0K9UED28cP0miKz3qAuMdxyEzUzK1MyACnJn0vjCeo5pq1MBX V7B32r9X2SZnLRF5FrR0rPjVbob7HuWyp6w0e8YtBD2csSPQdi5Vd0Fi/Tpkmr6FCgHk LwvN5TWHiPkWw/mhVhGgUArH5dM+z12n+dhqvkDlD170UTt8o4Q+dPa8KQcIs2tuztd2 VrHw==
X-Gm-Message-State: ABy/qLbmZcmMDoPfXeL5mkz9v7t2asnf9bVe2YApbS+vHJnLWv+xcYVk NcoXQsw9fWDopRQOc0G421qD9ntN+GNcZpUPkC9bDrYC
X-Google-Smtp-Source: APBJJlHaJAO86kQEO7+gxEY3+jvQ2d23Uc7rDljRWq/rZ/12WxXkvyWdw3cFU30KB3BJdmwbUY8gsBiz39rHrp/ZZUI=
X-Received: by 2002:a4a:2449:0:b0:566:f62b:7b91 with SMTP id v9-20020a4a2449000000b00566f62b7b91mr9522606oov.8.1690261504656; Mon, 24 Jul 2023 22:05:04 -0700 (PDT)
MIME-Version: 1.0
From: Watson Ladd <watsonbladd@gmail.com>
Date: Mon, 24 Jul 2023 22:04:55 -0700
Message-ID: <CACsn0ckZO+b5bRgMZhOvx+Jn-sa0g8cBD+ug1CJEdtYxSm_hgA@mail.gmail.com>
To: bpf@ietf.org
Content-Type: multipart/alternative; boundary="000000000000900b78060148ac7b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bpf/8Fkl_dExCX-YbPGOmWbG4SJFBKw>
Subject: [Bpf] Review of draft-thaler-bpf-isa-01
X-BeenThere: bpf@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion of BPF/eBPF standardization efforts within the IETF <bpf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bpf>, <mailto:bpf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bpf/>
List-Post: <mailto:bpf@ietf.org>
List-Help: <mailto:bpf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bpf>, <mailto:bpf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jul 2023 05:05:06 -0000

Dear BPF wg,

I took a look at the draft and think it has some issues, unsurprisingly at
this stage. One is the specification seems to use an underspecified C
pseudo code for operations vs defining them mathematically.

The good news is I think this is very fixable although tedious.

The other thornier issues are memory model etc. But the overall structure
seems good and the document overall makes sense.

Sincerely,
Watson Ladd