Re: [Bpf] Review of draft-thaler-bpf-isa-01

Alexei Starovoitov <alexei.starovoitov@gmail.com> Wed, 02 August 2023 02:29 UTC

MIME-Version: 1.0
References: <CACsn0ckZO+b5bRgMZhOvx+Jn-sa0g8cBD+ug1CJEdtYxSm_hgA@mail.gmail.com> <PH7PR21MB3878D8DCEF24A5F8E52BA59DA303A@PH7PR21MB3878.namprd21.prod.outlook.com> <CAADnVQJ1fKXcsTXdCijwQzf0OVF0md-ATN5RbB3g10geyofNzA@mail.gmail.com> <CACsn0cmf22zEN9AduiRiFnQ7XhY1ABRL=SwAwmmFgxJvVZAOsg@mail.gmail.com> <CADx9qWi+VQ=do+_Bsd8W4Yc-S1LekVq7Hp4bfD3nz0YP47Sqgg@mail.gmail.com> <CAADnVQ+5d8ztfFLraWnZKszAX23Z-12=pHjJfufNbd3qzWVNsQ@mail.gmail.com> <CADx9qWhSqb6xAP=nz5N-vmd2N3+h4TBFtFOGdJUWNfX=LapEBw@mail.gmail.com> <CAADnVQJ4yzDc0qQExLUO1b23ndEiEjnYYPv5qC7JJYmLr4X3ew@mail.gmail.com> <CADx9qWh6ZUKvjkZow6=eB4gvEgP82mBqn+mMZvmDQynCYAfMWw@mail.gmail.com> <CAADnVQKOiwm1UB58=8QcowDyfPQct-wuMD19citS7w5PmadZ6g@mail.gmail.com> <CADx9qWjYChRf2qBr=Pt5D-RLCb665YFKmjDYX8WOQfqMx1-bag@mail.gmail.com> <CAADnVQJDO9MgU2MQQ5NQAE3EwL6PuPp8aAxcV3apf0DHoq8TAw@mail.gmail.com> <CADx9qWjOP4-2K3uKBTRmS4Q5V0gTJtoH65fwN-MhZvn6ukFpBg@mail.gmail.com> <CAADnVQKbpoeMWdnXzYbBaHoDiNsLDbC0JvDUnVGEQbCigjd1Xg@mail.gmail.com> <CADx9qWj4xuYoyz83FphVWU0ZVxy_7Y+SvTWjvChvkMdV290giA@mail.gmail.com> <CAADnVQLWKnGbG6XTVEKSto0kEiqHwFaDTp+UkCYipKpov_btRA@mail.gmail.com> <PH7PR21MB38789504BF4250E37467C484A30BA@PH7PR21MB3878.namprd21.prod.outlook.com>
In-Reply-To: <PH7PR21MB38789504BF4250E37467C484A30BA@PH7PR21MB3878.namprd21.prod.outlook.com>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Tue, 01 Aug 2023 19:29:35 -0700
Message-ID: <CAADnVQLt7S9uwMxB3JaLMYACs5xTVwZ+en9pLYUguZ3gOf=33g@mail.gmail.com>
To: Dave Thaler <dthaler@microsoft.com>
Cc: Will Hawkins <hawkinsw@obs.cr>, Watson Ladd <watsonbladd@gmail.com>, "bpf@ietf.org" <bpf@ietf.org>, bpf <bpf@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/bpf/HhzIS-i3TVJ89gD0oM4myaM9e80>
Subject: Re: [Bpf] Review of draft-thaler-bpf-isa-01
Precedence: list

On Tue, Aug 1, 2023 at 6:55 PM Dave Thaler <dthaler@microsoft.com> wrote:
>
> > -----Original Message-----
> > From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> > Sent: Friday, July 28, 2023 9:52 PM
> > To: Will Hawkins <hawkinsw@obs.cr>
> > Cc: Watson Ladd <watsonbladd@gmail.com>; Dave Thaler
> > <dthaler@microsoft.com>; bpf@ietf.org; bpf <bpf@vger.kernel.org>
> > Subject: Re: [Bpf] Review of draft-thaler-bpf-isa-01
> >
> > On Fri, Jul 28, 2023 at 8:14 PM Will Hawkins <hawkinsw@obs.cr> wrote:
> > >
> > > The Appendix (the opcode table) is not in the kernel repo now and
> > > still has the issues that I outlined above.
>
> Suggestions (especially concrete changes) welcome :)
>
> > Will that make it in to
> > > the kernel?
> [...]
> > I thought it's auto generated, so it should be easy to update.
>
> It's not yet auto generated, and some parts are hard to auto-generated
> because the combinations are just in English text.
>
> > If not, let's certainly bring it in.
>
> At the IETF BPF WG meeting, folks seemed agnostic as to whether it
> was brought into the Linux repo or not.  See recording at
> https://www.youtube.com/watch?v=jTtPbJqfYwI at 1:15:30 - 1:17:30,
> and Christoph was the only one who spoke up, preferring to just keep
> a static copy of the Internet Draft in the kernel repository.  I interpreted
> this as saying no one cared about having the IANA considerations section
> in a separate file there.  But we confirm consensus on the list, so it's fine
> to revisit now if there are good reasons to do so.

I think IANA consideration section is orthogonal to giant opcode table.
They're related, but don't have to be together in one .rst file.
I think it's cleaner to have separate instruction-set-opcode.rst

We also went back and forth during the meeting whether hierarchy
of tables is prefered or one table. Currently you have one table and
it actually looks very readable. My preference would be to keep it this
way and carry over to IANA eventually as one table.

[Bpf] Review of draft-thaler-bpf-isa-01 Watson Ladd
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Dave Thaler
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Dave Thaler
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Watson Ladd
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Will Hawkins
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Will Hawkins
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Will Hawkins
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Will Hawkins
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Will Hawkins
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Will Hawkins
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Dave Thaler
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Watson Ladd
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Alexei Starovoitov
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Dave Thaler
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Dave Thaler
Re: [Bpf] Review of draft-thaler-bpf-isa-01 David Vernet
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Watson Ladd
Re: [Bpf] Review of draft-thaler-bpf-isa-01 Will Hawkins
Re: [Bpf] Review of draft-thaler-bpf-isa-01 David Vernet
Re: [Bpf] Review of draft-thaler-bpf-isa-01 David Vernet