Re: [Bpf] Review of draft-thaler-bpf-isa-01

Dave Thaler <dthaler@microsoft.com> Tue, 25 July 2023 14:00 UTC

Return-Path: <dthaler@microsoft.com>
X-Original-To: bpf@ietfa.amsl.com
Delivered-To: bpf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 29C42C15199B for <bpf@ietfa.amsl.com>; Tue, 25 Jul 2023 07:00:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3Lk419CvARfW for <bpf@ietfa.amsl.com>; Tue, 25 Jul 2023 07:00:21 -0700 (PDT)
Received: from BN3PR00CU001.outbound.protection.outlook.com (mail-eastus2azon11020025.outbound.protection.outlook.com [52.101.56.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6266BC15199C for <bpf@ietf.org>; Tue, 25 Jul 2023 07:00:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FZaSQMtdQUFQYDPX1Q0fmUVQGdUhXfY9jeSBu0xb+RAdNN/TIoLRVr81dL6+A2s4phdsEnDDZfXvxcWTn1eQZ5s3gNvf/03KnYHK6W1dThGtR/MU+nSg2SuVRoRj5yZoXEq0s+EcvdJez4LtXMQO5zlSi7in34YESyUT0NBY77QS/Y25SaNv5Yui4lWXcxjHjnZX9HF+Rrr5Bt+N7/ufa2LSqsGAfZ/AGc9L7/hFCgrRQ0xdJvdM9TzTm6u6h7S2jfrl2kzBww9whJ13xut3B5ERHuaOhGCUq2xR1DwBfHnb/HOd+ifmacISvKbtybdVA3bD9fpdRYi5DHIM1UIZDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZnvLXqnroGA1hxPEtou9lL1NIWjzVng03BeqNky3Q1k=; b=ENsH8EEIpC3NAxuF+VxMztAhvB791Z+EqQGe5Ho/pEJwi+ka0j1NO1rASQE5JyDnYoxDuyUTWTHry+LCNzu1/wbFcyfyAPCMFYIpbSfpEljl5P7yWsV02mh07tikiyJlFzwbM4JisWsEj3Bp7pnRj5B/IPeBubI5ck75pDvy5lJCtc6BFCVWYoXOGKF142WG+92Fe9x2QJMSO7ryCc70g/SUNCIrar2ntcCn+ASH8XK1kalt/r22nEUwg9PlvWtTi0Qd2f6UQUKcI5NjlKNUukptCV7QpD977R/izq375Il5lQZ2cUrJYsiz4oH79jCnmArslRO2nBGnDCgIh+LQPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZnvLXqnroGA1hxPEtou9lL1NIWjzVng03BeqNky3Q1k=; b=VROkNn4rVOUCVMYVSmEc7p/0asNy4XLi100uIdW3KHOr5JwyI+81lNoWxO3BZUPEz5Ho5Ekkw6zeend6G/d49n34lnO7TuspCGzbVZbQpHZiB9R5k+5UMCGH2SPimAHTGbLsPQXGNoLO6q3NiABhApiU5PofkC5qqZwWstSq16A=
Received: from PH7PR21MB3878.namprd21.prod.outlook.com (2603:10b6:510:243::22) by MN0PR21MB3217.namprd21.prod.outlook.com (2603:10b6:208:37a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.5; Tue, 25 Jul 2023 14:00:18 +0000
Received: from PH7PR21MB3878.namprd21.prod.outlook.com ([fe80::3cfe:3743:361a:d95b]) by PH7PR21MB3878.namprd21.prod.outlook.com ([fe80::3cfe:3743:361a:d95b%3]) with mapi id 15.20.6652.002; Tue, 25 Jul 2023 14:00:18 +0000
From: Dave Thaler <dthaler@microsoft.com>
To: Watson Ladd <watsonbladd@gmail.com>, "bpf@ietf.org" <bpf@ietf.org>, bpf <bpf@vger.kernel.org>
Thread-Topic: [Bpf] Review of draft-thaler-bpf-isa-01
Thread-Index: AQHZvrWW9Z2mpBtp0E2+6M55X5/AaK/KgvVw
Date: Tue, 25 Jul 2023 14:00:17 +0000
Message-ID: <PH7PR21MB387892F94D82AA2845845382A303A@PH7PR21MB3878.namprd21.prod.outlook.com>
References: <CACsn0ckZO+b5bRgMZhOvx+Jn-sa0g8cBD+ug1CJEdtYxSm_hgA@mail.gmail.com>
In-Reply-To: <CACsn0ckZO+b5bRgMZhOvx+Jn-sa0g8cBD+ug1CJEdtYxSm_hgA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=4a311dce-492a-41c5-909c-e600815bbf63; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-07-25T13:59:11Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH7PR21MB3878:EE_|MN0PR21MB3217:EE_
x-ms-office365-filtering-correlation-id: 95875576-e7b9-4c80-1b1c-08db8d177a58
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: MB+s/oxxcIfhufX/W5NHWXOsX0fLuZ80FSAnA13TPD2Lm3/rqeWpifSKcUMWffbBqpfK0lMskl9Zu4sQWx7CY8RZJXvZeRML2V5bDh29oHH4qWlddunbGOsLkadTWTZrNHh63Tkst79ZWO+hzBC7knUynSR4t6y/dZbLuyZNUWuqLLQ9cM/cyqi/Hh/UID4COh2tyqNYLh/YcvKHHq7xcNqneQPQb8Z3ne1Z36o9VvKM1NoGavLkx7iVbJjOOGHwkYTbWA5burs6+WxSf6mSwCBjU74zMZxM729QZT3SL++guMo8PuvXNl2r+QhTmEiV97hirip1EZnWBZbuhDJIbRZ9Rryid+f7TbT3s4rMtwPJF/ZL4sevthTrwVyx12LzvyqMivDVSVYsA6CpUzVaIGAF+eMYm/2TVG1bSlI2/helVCFQWTrv+kCRe9Wp+RjwknvPJnGbrXUZJZ72YQbIUESFvNky+jJ6wTqljsDiPJMewgdI7QRWAvSDL6iw/Ommz3y8jT7Udxz6RTkP5jJmTxo57fGKb9lC27dt7za5HrbbGcXEork9IYreMPhSMGlmO+B8/IMOtieSX6/2oV/jZ//afyhKqztRwwPSkNB2raPnuNzEQAMvr4OD6hCrw6p9++VODl95XoPBBdPHFQrDUkmHVEAplm5dD+DoA50gT28=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR21MB3878.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(39860400002)(136003)(346002)(376002)(451199021)(8990500004)(55016003)(52536014)(5660300002)(4744005)(2906002)(478600001)(10290500003)(110136005)(7696005)(71200400001)(316002)(8676002)(41300700001)(8936002)(66946007)(66446008)(64756008)(66556008)(66476007)(76116006)(33656002)(83380400001)(86362001)(38100700002)(122000001)(82950400001)(82960400001)(38070700005)(9686003)(186003)(6506007)(53546011); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: m59XyCoG6MhK215lDu2sVKduAUpWx3W/Pukp5aCfMf+xsvRvk9n9bmhIAFW+V1DSND9BchoKLHxfDlMdINid1mBVOf2ivJzJj84zVB4PEs2nWBWxiEgXQ5/FPWJ7Nrk8DV3BaTjXOBClo+Zt0cn6NVmDSVZN41P0mb5VMdK1mU52UHupNaJP+/sLK8LwukgmQXSkm3FUSYtMA3IeMjBAvKy+9XDuGJssaF4T9P9+Pv0qbDNvYvwPoOebB7MU3zZ48oBaeTjDChD2Bz5Yybcc+u9uMANUvyr42YmzWs6epdNJtlQpqjB7LNXVsAJXuRkOk8ZMMbzG2uPhDQ3VTyjLuNeq3OGKq+TaYEeGUs84h4hFIUE4ZwahmHKkrZwREKLpOM7RRoNZZjV9KMtWxfkS6Dx4XQYvOkxpejLYyO7S3ExxCASylpnY69m9QkSGcUOF96UfA7lDoj5sbdXrqcYLzmb+3veJ/bDwCbWM6lwuqd7+aga47S5ukwlxlVtVyfNpRfWU4+ivBpZs4sCy0Zr26htWyBLZ4mO7UtTSvqwhHeuQmrH/4xam0Kx61ZCVeeqskzNrnO4aD1zlHjGksFNt3+HJTUrX64W+yX4+9a9cf2Y+En2e0QT1EAx7NKr6+QqOXk4N1s5ybkODmTEQUna+Sd/2xvAk05bS5B15xAv35uNjfS2/BPXrwADCyhbqxDxvkBwui1dtBUSR6D/Ss94gs75Yly7otwCcTk/IuSdgd2Gwe4foMmtW2kZ9OaVW+cukY5YLoURdhuhyYt1bmU+eSlViDUYqUKwEUnIPsIpOqN7uj1zECDGuAC9D+CrUOnG0qaHLWpyud/LWhz8q/8AQYBg1OQnLZZil6teloxvd93Zx/ELyskNkIQMHdF4F5ItUO+tVXhBAkZAzb7jyaxRx11tVqT2Zqb+GPd/5GI5VLvrEQHF7DFAPCXAW/p5M3vav2k8anwcQU2p7UK92wbWv+AJqjFMFyDhrqtijy8DNHJZdgds9O3cczPmd5JoeYoiVscfKYy6L3g1k5BhAoWYThdmXmPLSQQHluENgAyV+Pj/cjS/qOkhpqdwOiOByToWxD56doii4b4aIWvNJF2Aibv2xDAgLkAghVfvCh+EdhP0C+g+vQBULyxO4wMh8j5qhhp8IBhbdhjEAMB7E0ezQ0vBCMc4z++qj2qqXoYszvyL+RnOUhQFxvpc5VVTO1aCiASlDcby/0sXPeGu06EgeqSNaK6pItbRkgc6zsnzPWdxaz9jiee311FTlZ+CAGl1HoAgR2jvD4aeM3H+LX07p1K84I9DCMzU8+WWfyWgs7SbplcWq7y2eeOAZrPwhCojlUH9CCeYoVg8Fz/aM36KtPTOzIF6IeauL2LuDtls4PYYrX+IXHxRiteagbOcPF1Q7mpoQnjfs8bivbuQT7ahI5xuZ8QPjM1CjIn2tRRXNClGy4kbuNhXX30Hfoi7JwEItOMSWvEsa3eenUN6ZzH/NXmuCA8LvlzeQCRzVGqpskpfsa/pX4MU9N8pc5h1D0C2iGG/tHBUem//Y9OcdVHPMTuY7D+GBENH+T46vZGzkNA6PsemFiCxymWfA9LqrFtzgtyFBCXXTWeYtHv8shYnxFJFinYAWlQg3+AD6nd43rs77ZBrvh53ZKGEVLPFNSpDOLV0FVYOnMaCQRjRkPUxoIA==
Content-Type: multipart/alternative; boundary="_000_PH7PR21MB387892F94D82AA2845845382A303APH7PR21MB3878namp_"
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3878.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95875576-e7b9-4c80-1b1c-08db8d177a58
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2023 14:00:17.8881 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: U6dlb7iRqgIGfhSvYS5QpDNzWvELDxRpM5cF2c0qgo15CxktnNKegmAewHrU4siyqt8nEA76WGYFxQbYawrJCkEuSVNgkb3xJPXJUu/xcm4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR21MB3217
Archived-At: <https://mailarchive.ietf.org/arch/msg/bpf/ScInXaxk-ZSwI99bGshMdjWvNC0>
Subject: Re: [Bpf] Review of draft-thaler-bpf-isa-01
X-BeenThere: bpf@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion of BPF/eBPF standardization efforts within the IETF <bpf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bpf>, <mailto:bpf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bpf/>
List-Post: <mailto:bpf@ietf.org>
List-Help: <mailto:bpf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bpf>, <mailto:bpf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jul 2023 14:00:22 -0000

I am forwarding the email below to the bpf@vger.kernel.org<mailto:bpf@vger.kernel.org> list
so replies can go to both lists.

Thanks,
Dave
From: Bpf <bpf-bounces@ietf.org> On Behalf Of Watson Ladd
Sent: Monday, July 24, 2023 10:05 PM
To: bpf@ietf.org
Subject: [Bpf] Review of draft-thaler-bpf-isa-01

Dear BPF wg,

I took a look at the draft and think it has some issues, unsurprisingly at this stage. One is the specification seems to use an underspecified C pseudo code for operations vs defining them mathematically.

The good news is I think this is very fixable although tedious.

The other thornier issues are memory model etc. But the overall structure seems good and the document overall makes sense.

Sincerely,
Watson Ladd