Re: [Captive-portals] Martin Duke's No Objection on draft-ietf-capport-api-07: (with COMMENT)

Tommy Pauly <tpauly@apple.com> Mon, 08 June 2020 15:50 UTC

Return-Path: <tpauly@apple.com>
X-Original-To: captive-portals@ietfa.amsl.com
Delivered-To: captive-portals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 798F83A0CD3; Mon, 8 Jun 2020 08:50:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=apple.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n9GeF8PhXkt4; Mon, 8 Jun 2020 08:50:42 -0700 (PDT)
Received: from ma1-aaemail-dr-lapp03.apple.com (ma1-aaemail-dr-lapp03.apple.com [17.171.2.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D61A73A0F80; Mon, 8 Jun 2020 08:50:03 -0700 (PDT)
Received: from pps.filterd (ma1-aaemail-dr-lapp03.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp03.apple.com (8.16.0.42/8.16.0.42) with SMTP id 058FkAcW030420; Mon, 8 Jun 2020 08:50:01 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=f2HL+1z+XZk8IAXRsjuWbXvML/g6GXvgdDg5ygbc8yo=; b=vwg3R61vkDI/QhDS8LNgHgS7xGAAAbBUrFmxvEWk6iOLqSJy1nwicd1kp8VStNAfAONX mWkgbD1rX/60q8x8tW5aLWfIGs5JAyADCYkv0ACHt9EcsHdg+gLFRtzYrdOw+kF80Jp/ x82etFSHNRRDYwdzpabA3vLqnHRYszRaLfysJ5ADhzEAeKnPkQom0WamKz0Yn4BvsTMm 4v2hFgyuorDOzZYF0+BrqgumaMPteeqrDxNAOT8oNn+f9OB2/i0dvHSJ+dRArmLImDco mYufENnwrlGCqcgVB8dlTVlfUf1c5NMrB+cNxbHfjvdcjDv3Hm7WEp+oflEeH4wafFbw jA==
Received: from rn-mailsvcp-mta-lapp03.rno.apple.com (rn-mailsvcp-mta-lapp03.rno.apple.com [10.225.203.151]) by ma1-aaemail-dr-lapp03.apple.com with ESMTP id 31ga4txfsq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 08 Jun 2020 08:50:01 -0700
Received: from rn-mailsvcp-mmp-lapp04.rno.apple.com (rn-mailsvcp-mmp-lapp04.rno.apple.com [17.179.253.17]) by rn-mailsvcp-mta-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QBM00YMT6NCRXB0@rn-mailsvcp-mta-lapp03.rno.apple.com>; Mon, 08 Jun 2020 08:50:00 -0700 (PDT)
Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp04.rno.apple.com by rn-mailsvcp-mmp-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QBM00K006IOKG00@rn-mailsvcp-mmp-lapp04.rno.apple.com>; Mon, 08 Jun 2020 08:50:00 -0700 (PDT)
X-Va-A:
X-Va-T-CD: 45f18851fe00c2da7ad83c72970c512e
X-Va-E-CD: 74b3447f67652cffde5b9e49cf636f14
X-Va-R-CD: 26639f79056bf794ca23050d85183374
X-Va-CD: 0
X-Va-ID: ed82739e-e76c-4f5f-927c-c8469066069f
X-V-A:
X-V-T-CD: 45f18851fe00c2da7ad83c72970c512e
X-V-E-CD: 74b3447f67652cffde5b9e49cf636f14
X-V-R-CD: 26639f79056bf794ca23050d85183374
X-V-CD: 0
X-V-ID: 239386fe-c95a-4d03-8c43-07d4204fd6cb
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-08_14:2020-06-08, 2020-06-08 signatures=0
Received: from [17.234.11.84] (unknown [17.234.11.84]) by rn-mailsvcp-mmp-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QBM00N3U6NB9X00@rn-mailsvcp-mmp-lapp04.rno.apple.com>; Mon, 08 Jun 2020 08:50:00 -0700 (PDT)
From: Tommy Pauly <tpauly@apple.com>
Message-id: <14505C26-96B4-45DA-9A02-88461017D908@apple.com>
Content-type: multipart/alternative; boundary="Apple-Mail=_73A07ED2-6E07-48B0-8DB1-1349FA7E3CC1"
MIME-version: 1.0 (Mac OS X Mail 13.0 \(3645.0.2\))
Date: Mon, 08 Jun 2020 08:49:59 -0700
In-reply-to: <159162892021.27300.417000505596920914@ietfa.amsl.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-capport-api@ietf.org, capport-chairs@ietf.org, captive-portals <captive-portals@ietf.org>, Martin Thomson <mt@lowentropy.net>
To: Martin Duke <martin.h.duke@gmail.com>
References: <159162892021.27300.417000505596920914@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3645.0.2)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-08_14:2020-06-08, 2020-06-08 signatures=0
Archived-At: <https://mailarchive.ietf.org/arch/msg/captive-portals/x1gI7woWV1B53iB0C6X-ztwgoC4>
Subject: Re: [Captive-portals] Martin Duke's No Objection on draft-ietf-capport-api-07: (with COMMENT)
X-BeenThere: captive-portals@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of issues related to captive portals <captive-portals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/captive-portals/>
List-Post: <mailto:captive-portals@ietf.org>
List-Help: <mailto:captive-portals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2020 15:50:45 -0000

Hi Martin,

Thanks for the updated review. I’ve incorporated these comments in our GitHub:

https://github.com/capport-wg/api/commit/daeba897a1d50229b86f6ec23a026aaa725bf672 <https://github.com/capport-wg/api/commit/daeba897a1d50229b86f6ec23a026aaa725bf672>

Thanks,
Tommy

> On Jun 8, 2020, at 8:08 AM, Martin Duke via Datatracker <noreply@ietf.org> wrote:
> 
> Martin Duke has entered the following ballot position for
> draft-ietf-capport-api-07: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-capport-api/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> This document is clearly written. Thanks.
> 
> I am also confused by this sentence at the end of section 4.1 about failed
> authentication: “It may still be possible for the user to access the network by
> being redirected to a web portal.”
> 
> I suggest “...access the network by redirecting a clear text webpage to a web
> portal.”  I was a bit confused by the original wording.
> 
> As I said in the architecture review, the term for the user portal keeps
> changing. Over there it’s called a “Captive Portal Server” and a “web portal
> server”. Here it’s a “user-portal.” The authors of the two docs should get
> together and agree on a term.
> 
> One nit:
> s/extenal/external
> 
> 
>