[Cbor] Robert Wilton's No Objection on draft-ietf-cbor-file-magic-11: (with COMMENT)
Robert Wilton via Datatracker <noreply@ietf.org> Thu, 21 April 2022 16:38 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: cbor@ietf.org
Delivered-To: cbor@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id DC49B3A08E5; Thu, 21 Apr 2022 09:38:56 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Robert Wilton via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-cbor-file-magic@ietf.org, cbor-chairs@ietf.org, cbor@ietf.org, christian@amsuess.com, christian@amsuess.com
X-Test-IDTracker: no
X-IETF-IDTracker: 8.0.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Robert Wilton <rwilton@cisco.com>
Message-ID: <165055913687.10023.13183316329683102967@ietfa.amsl.com>
Date: Thu, 21 Apr 2022 09:38:56 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/CA4GW0IQozmqB5CA9-LDy6pCE_o>
Subject: [Cbor] Robert Wilton's No Objection on draft-ietf-cbor-file-magic-11: (with COMMENT)
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2022 16:38:57 -0000
Robert Wilton has entered the following ballot position for draft-ietf-cbor-file-magic-11: No Objection When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-cbor-file-magic/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- Hi, Apologies for a late review, and there is just one none blocking issue that I wanted to raise: It is further suggested to avoid values that have an embedded zero byte in the four bytes of their binary representation (such as 0x12003456), as these may confuse implementations that treat the magic number as a C string. I was less convinced by this statement because: (1) It seems like C treating this as null terminated string is probably not the right thing to do, I'm not sure that we should be implicitly endorsing that. (2) When translating values from the Content-Format registry means that this issue is presumably unavoidable. I.e., it looks like your example in 2.2.1 violates this guidance. Regards, Rob
- [Cbor] Robert Wilton's No Objection on draft-ietf… Robert Wilton via Datatracker
- Re: [Cbor] Robert Wilton's No Objection on draft-… Carsten Bormann
- Re: [Cbor] Robert Wilton's No Objection on draft-… Rob Wilton (rwilton)
- Re: [Cbor] Robert Wilton's No Objection on draft-… Carsten Bormann
- Re: [Cbor] Robert Wilton's No Objection on draft-… Michael Richardson
- Re: [Cbor] Robert Wilton's No Objection on draft-… Michael Richardson
- Re: [Cbor] Robert Wilton's No Objection on draft-… Rob Wilton (rwilton)
- Re: [Cbor] Robert Wilton's No Objection on draft-… Rob Wilton (rwilton)
- Re: [Cbor] Robert Wilton's No Objection on draft-… Michael Richardson
- Re: [Cbor] Robert Wilton's No Objection on draft-… Rob Wilton (rwilton)
- Re: [Cbor] Robert Wilton's No Objection on draft-… Carsten Bormann