Re: [Cellar] I-D Action: draft-ietf-cellar-ffv1-15.txt

Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com> Thu, 25 June 2020 16:42 UTC

Return-Path: <spencerdawkins.ietf@gmail.com>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 07D713A0C51 for <cellar@ietfa.amsl.com>; Thu, 25 Jun 2020 09:42:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6S6syHE__iaf for <cellar@ietfa.amsl.com>; Thu, 25 Jun 2020 09:42:57 -0700 (PDT)
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE8E63A0C59 for <cellar@ietf.org>; Thu, 25 Jun 2020 09:42:56 -0700 (PDT)
Received: by mail-lj1-x235.google.com with SMTP id 9so7243441ljc.8 for <cellar@ietf.org>; Thu, 25 Jun 2020 09:42:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JfVpV3jyhvksntnEB55C+NdlpR6bD0Wq38h/g849zjo=; b=LNcGYPGp9ZCjrclehkno/FdYjX+eYV/EWIpAvk4o83+f5WUxuh7C2o5QGcfbqidyyi 4WbVgJrUAK8j4pCpxWhEnypPiWua3cvEjGGe3qLEw6nGRPbHG6hJML1wv/EqU22z16oV 6xXnPv/oim+2xx4aCO2n3d9tlAu9agZw5RaojSeuQi+qeryoXVmGnjRtyMbHvegzzRlo 5SRDY+r59Owib+doyHHQPZBUuGHc+u7L7OHnAQIn5sWCDT+EX+jfBops48hhByE2CgQT z/hrT5G40JJVj6yGgoe8UNuQfCtOdSImlhhylETtnn6/EaRjX0TXhq/huqfY6IUuGGCn ceuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JfVpV3jyhvksntnEB55C+NdlpR6bD0Wq38h/g849zjo=; b=Mp8Bw8UAhlbI7tJ2Ypw2Xcb9a5dLz4j5vx2fzFcFm7lUNjQoDwzoJBqZWUsQsdxQSf A/SXUoaarHHgm4UaQR0/dw9wkSf40O888D36cFXeypvwraF8ntBhaLT2WJv5lGagIJv4 nfQXz6wXaAarMJSmU0fHzF/8yRDa/ntnv2NoqLDowEACoB0EfDRIyyertGpquCFz8CE6 YZMft4tPtRAnIfBFz3vKgjUXQ76EesHdiz9lhGpehFG00OoiesVwVBNTqNO3AYQ5TfRR +mDcGuPSGTDXFV+btIoU0ubQWltChtYPlpJM+3pVITE9xbzsth/OkSQuGe1U4QN+1guB +7Sw==
X-Gm-Message-State: AOAM530/lSrbxFVYdF/n2NFxBx9NGkutWlABLsvChzZSVbRMN1UpvAeE uFJqH7ZqfOX336N5f+Ilu6S2JAWT8EPbcl4zp+Jiij2J
X-Google-Smtp-Source: ABdhPJyRtHvZbD5rNfDZHis3paqrd4cfRi3SnkC1Id7I9GrA82VxyczbEdfAJkBwYn3v5KENvln6Tij4A506F9WAwlg=
X-Received: by 2002:a2e:95d6:: with SMTP id y22mr18265903ljh.469.1593103374721; Thu, 25 Jun 2020 09:42:54 -0700 (PDT)
MIME-Version: 1.0
References: <159293956986.23437.659003564832844414@ietfa.amsl.com> <CAKKJt-csgcrjsekG8VDPNPUip3_4T1Nuv-1DSje2WkdsrjfxkA@mail.gmail.com> <CAL0qLwZugn7HZN6-QT6CYjuPV89q8Suz_Jujn92Jya6ez7gG3g@mail.gmail.com>
In-Reply-To: <CAL0qLwZugn7HZN6-QT6CYjuPV89q8Suz_Jujn92Jya6ez7gG3g@mail.gmail.com>
From: Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com>
Date: Thu, 25 Jun 2020 11:42:28 -0500
Message-ID: <CAKKJt-dJ_DCNXjtX7fU+5tsTN5-sW3GLF0Y2FsbXcGTKv-Tz+g@mail.gmail.com>
To: "Murray S. Kucherawy" <superuser@gmail.com>
Cc: Codec Encoding for LossLess Archiving and Realtime transmission <cellar@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000bda7db05a8eb48bc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/UANv86OJ2Sbfc-Yg0bmIH7C5Fo4>
Subject: Re: [Cellar] I-D Action: draft-ietf-cellar-ffv1-15.txt
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2020 16:42:59 -0000

Dear Cellar,

On one point,

On Thu, Jun 25, 2020 at 11:25 AM Murray S. Kucherawy <superuser@gmail.com>
wrote:

> Hi, thanks for this.  I'm looking now only at the diff between -13 (the
> last version I looked at) and this one.
>
> First and foremost, this is mostly better.  Kudos for putting the work in.
>
> Hooray, most of those "type" columns are gone!  But, alas, not all of
> them.  They're still present in Sections 4.1 and below.  I counted at least
> seven of them just in the diff I'm reviewing.  As before, they should also
> be removed, or at least explained.
>
> A minor point: Prior to Section 3.8.2.3, it looks like all of the examples
> are in C.  After that, they switch to pseudo code.  Any reason we can't be
> consistent?
>
> I suggest that the prose below Table 8, which is a mix of pseudocode and
> English, would be better broken apart.
>
> Chairs: RFC 4732 is a downref; please make sure the shepherd calls this
> out in the writeup.
>

This means that RFC 4732 is not a standards-track document, while our draft
is standards-track. That's fine, but we need to point that out when the
document is sent for IETF Last Call, so the shepherd (or one of the working
group chairs) should mention this in the "Other Points" section of
https://datatracker.ietf.org/doc/draft-ietf-cellar-ffv1/shepherdwriteup/.

Best,

Spencer


>
>
> There are a few code expressions that would benefit from being wrapped
> differently.  For example:
>
> (chroma_planes == 1 && (p == 1 || p == 2)) ? ceil(slice_pixel_height
> / (1 << log2_v_chroma_subsample)) : slice_pixel_height
>
> Maybe this?
>
> chroma_planes == 1 && (p == 1 || p == 2)
>   ? ceil(slice_pixel_height / (1 << log2_v_chroma_subsample))
>   : slice_pixel_height
>
> -MSK
>
> On Tue, Jun 23, 2020 at 12:26 PM Spencer Dawkins at IETF <
> spencerdawkins.ietf@gmail.com> wrote:
>
>> Hi, Murray,
>>
>> We just confirmed during the Cellar virtual meeting that -15 IS actually
>> ready for you to check and confirm that we've addressed the AD comments on
>> this draft.
>>
>> Best,
>>
>> Spencer
>>
>> On Tue, Jun 23, 2020 at 2:12 PM <internet-drafts@ietf.org> wrote:
>>
>>>
>>> A New Internet-Draft is available from the on-line Internet-Drafts
>>> directories.
>>> This draft is a work item of the Codec Encoding for LossLess Archiving
>>> and Realtime transmission WG of the IETF.
>>>
>>>         Title           : FFV1 Video Coding Format Version 0, 1, and 3
>>>         Authors         : Michael Niedermayer
>>>                           Dave Rice
>>>                           Jerome Martinez
>>>         Filename        : draft-ietf-cellar-ffv1-15.txt
>>>         Pages           : 53
>>>         Date            : 2020-06-23
>>>
>>> Abstract:
>>>    This document defines FFV1, a lossless intra-frame video encoding
>>>    format.  FFV1 is designed to efficiently compress video data in a
>>>    variety of pixel formats.  Compared to uncompressed video, FFV1
>>>    offers storage compression, frame fixity, and self-description, which
>>>    makes FFV1 useful as a preservation or intermediate video format.
>>>
>>>
>>> The IETF datatracker status page for this draft is:
>>> https://datatracker.ietf.org/doc/draft-ietf-cellar-ffv1/
>>>
>>> There are also htmlized versions available at:
>>> https://tools.ietf.org/html/draft-ietf-cellar-ffv1-15
>>> https://datatracker.ietf.org/doc/html/draft-ietf-cellar-ffv1-15
>>>
>>> A diff from the previous version is available at:
>>> https://www.ietf.org/rfcdiff?url2=draft-ietf-cellar-ffv1-15
>>>
>>>
>>> Please note that it may take a couple of minutes from the time of
>>> submission
>>> until the htmlized version and diff are available at tools.ietf.org.
>>>
>>> Internet-Drafts are also available by anonymous FTP at:
>>> ftp://ftp.ietf.org/internet-drafts/
>>>
>>>
>>> _______________________________________________
>>> Cellar mailing list
>>> Cellar@ietf.org
>>> https://www.ietf.org/mailman/listinfo/cellar
>>>
>>