Re: [codec] Opus codec on Analog Devices SHARC DSPs - patch needed

Jean-Marc Valin <jmvalin@mozilla.com> Tue, 22 November 2011 15:49 UTC

Return-Path: <jmvalin@mozilla.com>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EFE091F0C4D for <codec@ietfa.amsl.com>; Tue, 22 Nov 2011 07:49:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.599
X-Spam-Level:
X-Spam-Status: No, score=-6.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ID+ZhiQWn0B9 for <codec@ietfa.amsl.com>; Tue, 22 Nov 2011 07:49:50 -0800 (PST)
Received: from dm-mail03.mozilla.org (dm-mail03.mozilla.org [63.245.208.213]) by ietfa.amsl.com (Postfix) with ESMTP id 6B9001F0C4F for <codec@ietf.org>; Tue, 22 Nov 2011 07:49:50 -0800 (PST)
Received: from [192.168.1.15] (modemcable239.192-178-173.mc.videotron.ca [173.178.192.239]) (Authenticated sender: jvalin@mozilla.com) by dm-mail03.mozilla.org (Postfix) with ESMTP id E69864AEDC7; Tue, 22 Nov 2011 07:49:48 -0800 (PST)
Message-ID: <4ECBC4DC.10302@mozilla.com>
Date: Tue, 22 Nov 2011 10:50:52 -0500
From: Jean-Marc Valin <jmvalin@mozilla.com>
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0
MIME-Version: 1.0
To: neerlent@gmail.com
References: <CAGPwc8FpSf_r9VcCCKo7_S9-OxTNZ_M1QoMhd5rp9tasG_E7tQ@mail.gmail.com>
In-Reply-To: <CAGPwc8FpSf_r9VcCCKo7_S9-OxTNZ_M1QoMhd5rp9tasG_E7tQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: codec@ietf.org
Subject: Re: [codec] Opus codec on Analog Devices SHARC DSPs - patch needed
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/codec>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Nov 2011 15:49:51 -0000

Sounds like a reasonable (and very low risk) change to make.

Thanks,

	Jean-Marc

On 19/11/11 05:12 PM, neerlent@gmail.com wrote:
> Hello,
> 
> I am currently considering the use of the Opus codec for an audio
> streaming application that would run on an Analog Devices SHARC DSP. 
> Since it is a 32-bit floating-point DSP, I assumed it would be
> relatively easy to get the Opus floating-point code building for the
> SHARC.  I am only interested in the CELT mode of operation, so I created
> a project that included opus_custom_demo.c and all necessary files for
> the demo to build.
> 
> I found one issue that prevents the CELT code from building for the
> SHARC DSP.  The file bands.c contains a variable named "bank", which is
> used in several places in the file.  The SHARC C compiler treats "bank"
> as a reserved keyword for specifying what memory block a piece of data
> should go in. 
> 
> I've attached a patch that renames variables named "bank" to "band" in
> both bands.c and bands.h.  Let me know if you will consider making this
> change.
> 
> Thanks,
> 
> Matt Kotvis
> 
> 
> _______________________________________________
> codec mailing list
> codec@ietf.org
> https://www.ietf.org/mailman/listinfo/codec