Re: [codec] Opus codec on Analog Devices SHARC DSPs - patch needed

Ralph Giles <giles@thaumas.net> Tue, 29 November 2011 22:11 UTC

Return-Path: <giles@thaumas.net>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 655B711E8128 for <codec@ietfa.amsl.com>; Tue, 29 Nov 2011 14:11:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.977
X-Spam-Level:
X-Spam-Status: No, score=-2.977 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id At314Jp5bGYJ for <codec@ietfa.amsl.com>; Tue, 29 Nov 2011 14:11:44 -0800 (PST)
Received: from mail-vx0-f172.google.com (mail-vx0-f172.google.com [209.85.220.172]) by ietfa.amsl.com (Postfix) with ESMTP id 7DB8C11E8126 for <codec@ietf.org>; Tue, 29 Nov 2011 14:11:41 -0800 (PST)
Received: by vcbfy13 with SMTP id fy13so7035113vcb.31 for <codec@ietf.org>; Tue, 29 Nov 2011 14:11:40 -0800 (PST)
MIME-Version: 1.0
Received: by 10.220.87.8 with SMTP id u8mr5547551vcl.5.1322604700863; Tue, 29 Nov 2011 14:11:40 -0800 (PST)
Received: by 10.220.157.9 with HTTP; Tue, 29 Nov 2011 14:11:40 -0800 (PST)
X-Originating-IP: [184.71.166.126]
In-Reply-To: <4ECC09E5.9070707@masque.com>
References: <mailman.79.1321992012.18808.codec@ietf.org> <4ECC09E5.9070707@masque.com>
Date: Tue, 29 Nov 2011 14:11:40 -0800
Message-ID: <CAEW_RktYYnVc3zyy5NrwT_TuWJ+3HSOtkMa5-m-g9i90YS9dZA@mail.gmail.com>
From: Ralph Giles <giles@thaumas.net>
To: John Ridges <jridges@masque.com>
Content-Type: multipart/mixed; boundary="0016364ee59a5f8efc04b2e6e7fd"
Cc: codec@ietf.org
Subject: Re: [codec] Opus codec on Analog Devices SHARC DSPs - patch needed
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/codec>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Nov 2011 22:11:45 -0000

On 22 November 2011 12:45, John Ridges <jridges@masque.com> wrote:

> I realize it's rather late in the game, but I can't help but notice that
> several function in the CELT fork of the code use variable names that are
> formatted as system specific macros (e.g. _C).

Thanks for pointing this out. I've attached a patch which addresses the issue.

 -r