Re: [core] Ben Campbell's Discuss on draft-ietf-core-senml-14: (with DISCUSS and COMMENT)

Carsten Bormann <cabo@tzi.org> Thu, 19 April 2018 12:29 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8DC7512D95C; Thu, 19 Apr 2018 05:29:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UmV7EF504QSI; Thu, 19 Apr 2018 05:29:55 -0700 (PDT)
Received: from mailhost.informatik.uni-bremen.de (mailhost.informatik.uni-bremen.de [IPv6:2001:638:708:30c9::12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1A071271FD; Thu, 19 Apr 2018 05:29:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at informatik.uni-bremen.de
Received: from submithost.informatik.uni-bremen.de (submithost.informatik.uni-bremen.de [IPv6:2001:638:708:30c9::b]) by mailhost.informatik.uni-bremen.de (8.14.5/8.14.5) with ESMTP id w3JCTogv028817; Thu, 19 Apr 2018 14:29:50 +0200 (CEST)
Received: from client-0044.vpn.uni-bremen.de (client-0044.vpn.uni-bremen.de [134.102.107.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by submithost.informatik.uni-bremen.de (Postfix) with ESMTPSA id 40Rdbf1fQZzDX21; Thu, 19 Apr 2018 14:29:50 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <152385571314.20985.5160681583375127961.idtracker@ietfa.amsl.com>
Date: Thu, 19 Apr 2018 14:29:49 +0200
Cc: The IESG <iesg@ietf.org>, draft-ietf-core-senml@ietf.org, Jaime Jimenez <jaime.jimenez@ericsson.com>, core-chairs@ietf.org, core@ietf.org
X-Mao-Original-Outgoing-Id: 545833783.9225889-766ade997f1c709df086f16802abf5c5
Content-Transfer-Encoding: quoted-printable
Message-Id: <C5B8D82A-DC36-4340-B762-35AAFD2B2B11@tzi.org>
References: <152385571314.20985.5160681583375127961.idtracker@ietfa.amsl.com>
To: Ben Campbell <ben@nostrum.com>
X-Mailer: Apple Mail (2.3445.5.20)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/2um8xNkpJJhKlyMvxDg1GKGaDTc>
Subject: Re: [core] Ben Campbell's Discuss on draft-ietf-core-senml-14: (with DISCUSS and COMMENT)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2018 12:29:56 -0000

Here is my knee-jerk reaction to the other Ben’s review.

> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
> 
> Hopefully this is easy to address:
> 
> §4.7  talks about how SenML can also be used to configure parameters and
> controlling actuators. That capability has some rather significant security
> implications, but I failed to find mention of it in the security
> considerations. That needs to be explicitly discussed.

Indeed.
TBD.

> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Substantive:
> 
> §4.4: "If this value is a version number larger than the version which the
>   system understands, the system SHOULD NOT use this object."
> 
> Why not MUST NOT? Are there situations where an implementation might reasonably
> use an object with a higher version number than the implementation understands?

Not really.
Fair point.

> Editorial/Nits:
> 
> The title is misleading. It makes it sound like the document is just
> registering media types; in fact it defines SenML.

Right, it is defining the media types.
(Hmm, if “media types” means “media type names and their registrations”, maybe we do need to change the title.)

> §1, first paragraph: "This format was defined...": The antecedent of "this" is
> unclear, since the fact the document defines SenML has not yet been mentioned.

s/This format/The format established by these media types/

> §4.3, table 1: What do the asterisks mean?

(See my knee-jerk comments on Adam’s COMMENTS.)

> §5.1.2, paragraph starting with "Note that...": I'm surprised to find normative
> requirements buried in a note in an example.

We should decide the whole stream pile before fixing this (which is just a symptom of the less-than-well-definedness of streams).

> §10, first paragraph: “ the an integrated sum...": competing articles.

s/the an/an/

> §14: “Sensor data can range from information with almost no security
> considerations..."
> s/security/privacy

Yep.

Grüße, Carsten