[core] Review of draft-ietf-core-senml-versions-01

Jaime Jiménez <jaime@iki.fi> Fri, 12 February 2021 08:39 UTC

Return-Path: <jaime@iki.fi>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3AC773A141B for <core@ietfa.amsl.com>; Fri, 12 Feb 2021 00:39:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.12
X-Spam-Level:
X-Spam-Status: No, score=-1.12 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_NEUTRAL=0.779, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=messagingengine.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YwOsOaIn1m6n for <core@ietfa.amsl.com>; Fri, 12 Feb 2021 00:39:54 -0800 (PST)
Received: from wforward2-smtp.messagingengine.com (wforward2-smtp.messagingengine.com [64.147.123.31]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC4873A1418 for <core@ietf.org>; Fri, 12 Feb 2021 00:39:54 -0800 (PST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.west.internal (Postfix) with ESMTP id 148749C0; Fri, 12 Feb 2021 03:39:53 -0500 (EST)
Received: from imap3 ([10.202.2.53]) by compute2.internal (MEProxy); Fri, 12 Feb 2021 03:39:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KtKCV+ LAkOmpKimnOPev1u+N0yi9O9Cl99Iw+xQyQV0=; b=LHzfEIk7UkRvUkglFEp9yF mm8xx9nC8Qt8im9N7mvZL0J+yMaBG7mDbvP10tD0Mfps8XNjYEGE6G9kAL67QKe/ yXWl3QJsv+6hgy2pOyiV3+Dbnh7LyQUA+9HwwxsinwKMym2kBI/3IscfeVIgMXoN 4hIGhLixhbWD3UyS9aBjP7AV0107KlTJyfix1rlJhvqYkDkb6sJcOzVipwBlQQ/5 l4Red9SiWOZ7B1sm/NiimgqOPeYzCGTetmkXtPh0yrBJfeNo0PWqcGm3VEG185Fp NV7Is9ns/hOl6Zyl8XREbtWJoRxL77DOK6vx9EqfJGmIbl25uGUXGL2i/qqp9lDg ==
X-ME-Sender: <xms:1z4mYLg17tTKHkUUbCA9G9HMEhAx28kleunJ6Qtu6huUaS0TXZgzZA> <xme:1z4mYIBLRgvJZAFNjbX57dJbURzPF51vyQagqTifbDXYJDOCOQpuXvRTlWpQkpyGx 2dZ_L6vOIe9P14B7Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledriedtgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkfffhvffutgfgsehtqhertderreejnecuhfhrohhmpeflrghimhgv pgflihhmrohnvgiiuceojhgrihhmvgesihhkihdrfhhiqeenucggtffrrghtthgvrhhnpe fggfejkeelgfeiteehfffftddtgeejffehfeevudetteelgfdvheegfeeltdegvdenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjrghimhgvse hikhhirdhfih
X-ME-Proxy: <xmx:1z4mYLF9I4Z-JUSCdL5aRiEP1AOnJob5bhGsY67hp3Q0jm3uNqeIPA> <xmx:1z4mYIT2GKI4-6Y_5dss5gTllEdaUTjfKu6sDt7Dn2MqtZSnkE9ObQ> <xmx:1z4mYIxSD2hJJAy_FRdkkQTmLy94WULhYXIlGJZDAuoYptbBjb0zEA> <xmx:2D4mYFtuOPbNyMGN3DpHFsNZWib7PdXhoAX9dBIKqFN7EseYQ9ZH-aKRZzg>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id B5CCB420067; Fri, 12 Feb 2021 03:39:51 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.5.0-alpha0-141-gf094924a34-fm-20210210.001-gf094924a
Mime-Version: 1.0
Message-Id: <422b8d83-ee97-4a6c-81ec-3cf004f2cd09@www.fastmail.com>
Date: Fri, 12 Feb 2021 10:39:30 +0200
From: =?UTF-8?Q?Jaime_Jim=C3=A9nez?= <jaime@iki.fi>
To: core@ietf.org, "Carsten Bormann" <cabo@tzi.org>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/5cWnixOE8nX4HTIy5w3rE4Whpo8>
Subject: [core] Review of draft-ietf-core-senml-versions-01
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Feb 2021 08:39:59 -0000

Dear authors,

first of all I'd like to apologise for the delay when providing the review.

While I did not find any mistakes, there are few additions to the document that *could* help clarify it for the benefit of the readers:

- Mention somewhere in the text that the maximum amount of features is 53 and that therefore the highest version number is 2**53-1 in decimal notation. Therefore readers should not expect the usual linear semantic versioning for each version (1,2,3,4...) but rather (10, 26, 42, 58...).

- Give an example of the current bitmap -for example in a double or float representation- providing all features that are currently supported for bver=26.

00000000 00000000
00000000 00000000
00000000 00000000
00000000 00011010

- The limitation to 53 versions in total as well as potential feature deprecation was already discussed in various IETFs and neither authors nor the group see that as a limitation. I agree with that providing that expert review is conservative when adding new features. Potentially we could also think about bundling some future features if they are related before publication; but it is very hard to forecast that.

Note that, ahead of the shepherd writeup, it would be good to document existing implementations out there.

Editorial:

"Network Working Group" should be CoRE.

independently selectable "features"
Use of quotes for features seems unnecessary, as those literally are features.                       
   
Ciao!
-- 
Jaime Jiménez