Re: [core] [T2TRG] Review of CoRAL

Klaus Hartke <hartke@projectcool.de> Tue, 06 November 2018 07:03 UTC

Return-Path: <hartke@projectcool.de>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1987D1277C8 for <core@ietfa.amsl.com>; Mon, 5 Nov 2018 23:03:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_FAIL=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 51BEbKwZPfZ1 for <core@ietfa.amsl.com>; Mon, 5 Nov 2018 23:03:44 -0800 (PST)
Received: from wp382.webpack.hosteurope.de (wp382.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8597::]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 579F712777C for <core@ietf.org>; Mon, 5 Nov 2018 23:03:44 -0800 (PST)
Received: from mail-qt1-f170.google.com ([209.85.160.170]); authenticated by wp382.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1gJvOn-0008PP-Rf; Tue, 06 Nov 2018 08:03:41 +0100
Received: by mail-qt1-f170.google.com with SMTP id p35so1496711qtc.4 for <core@ietf.org>; Mon, 05 Nov 2018 23:03:41 -0800 (PST)
X-Gm-Message-State: AGRZ1gIM+HnOBqfwuCzsA1VOEdvV4+/tXHnLLROsP1ypIdEhO1qARwQI +1gj3QWOyJsdtq7nJ9kST2IqimJpa5PO4QEWccY=
X-Google-Smtp-Source: AJdET5fplV+samOa6YuPslAa9+tj4apqiJBKBLXzAJjAFnyDXDe26droenZ9HVDFwmZOLuhT6CzvEK5ftPbrK89yOgw=
X-Received: by 2002:aed:26a3:: with SMTP id q32mr12511654qtd.106.1541487820754; Mon, 05 Nov 2018 23:03:40 -0800 (PST)
MIME-Version: 1.0
References: <20181031164534.GA4995@hephaistos.amsuess.com> <CAAzbHvYPRLMZFh2Yi7jwM8ZzVMXcLmqe20Qeo2LjD9xCu4=9QA@mail.gmail.com> <20181105120109.GC12165@hephaistos.amsuess.com>
In-Reply-To: <20181105120109.GC12165@hephaistos.amsuess.com>
From: Klaus Hartke <hartke@projectcool.de>
Date: Tue, 6 Nov 2018 08:03:04 +0100
X-Gmail-Original-Message-ID: <CAAzbHva9-yyF2Z1MU82f6P70=rLBadQdUtQr4BgcU1Y2wMN5RQ@mail.gmail.com>
Message-ID: <CAAzbHva9-yyF2Z1MU82f6P70=rLBadQdUtQr4BgcU1Y2wMN5RQ@mail.gmail.com>
To: =?UTF-8?Q?Christian_M=2E_Ams=C3=BCss?= <christian@amsuess.com>
Cc: "core@ietf.org WG" <core@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-bounce-key: webpack.hosteurope.de; hartke@projectcool.de; 1541487824; e618af48;
X-HE-SMSGID: 1gJvOn-0008PP-Rf
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/BV-OTzpuBurxon0TuWyJq1A9UWE>
Subject: Re: [core] [T2TRG] Review of CoRAL
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Nov 2018 07:03:46 -0000

Christian Amsüss wrote:
> The grouper version is probably more concise than the note that "the
> Python code expects base and href not to be input in the trivial
> deserialization of a CBOR array, but as a list of (option number, option
> value) pairs" that should otherwise be there.

Right, but it also makes the code slightly less self explanatory. I'll
think about it. Thanks!

> Having read up on them, a "profile" has a no-changes-to-interpretation
> condition:
>
>   A profile MUST NOT change the semantics of the resource representation
>   when processed without profile knowledge, so that clients both with
>   and without knowledge of a profiled resource can safely use the same
>   representation
>
> Given that a client without knowledge of the profile can't process a
> representation, the parameter should probably be called something else.

Good catch! I've changed the parameter name to "registry" in my working copy.

Klaus