Re: [Detnet] Genart last call review of draft-ietf-detnet-ip-over-mpls-05
Balázs Varga A <balazs.a.varga@ericsson.com> Tue, 28 April 2020 09:33 UTC
Return-Path: <balazs.a.varga@ericsson.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7419C3A11E0; Tue, 28 Apr 2020 02:33:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.921
X-Spam-Level:
X-Spam-Status: No, score=-2.921 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.82, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S-WwjuW49uTo; Tue, 28 Apr 2020 02:33:02 -0700 (PDT)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C95F3A11DF; Tue, 28 Apr 2020 02:33:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GIWeynYlAJc0NOrbrZp3vpJ+YeAsT5W32tMNC1foDpHC7dYEjlmr95JsBh/SqeLUeWwhuZe4Y7RLigwieOUYpVWJvTvOkXLT3z9drB1Eq/p0a9zT64Bbm6Q3Aq1vByN3Ubj2jWczn1l273kiyNMpqQQUZJ8FVduMg9VJS/YzIjesFLO1e7wv/DKsxuj5jVfaa759j7ZdtNJsccXrARCGAHcxmEmSXrkg2QRlzF0V0/EODQmG6HXrwRsWG3e71UR6mMwxT0P7CTOD3SJQLIunFEOIdoidC6Q9bQVXmpFZVKI2AhdrE2CIxPoqHXSe5aG4StUmcolqZtseeFLXSbHIqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0DkNgBi2w3yGNdHk+t4lxxcSib3hEsMuRVhgdvhK/Yk=; b=dn7eMcskwaBwE0cEtHFEMTh9dMjdg0Q02KDFC7BSCfFhLdapj1ZjGFzMwbrJxWVejyTYmqOXP0TYBH8cLUW1foAaJWtJj9F43I6p0yPcQqND3MyJSMhNCcl1tnQQK/+Uu33LFsx35q2sEMUYGT39F+gLUk5ddlYlxN1kpGOYwCr6pwwifcRIcsfGRWNZ3cH+GQiOt3rs7wiwVhYaz4OsCFwz55fwQRyc+KUsuJ34UctP0P8Olr3gH4jBe2S1vrUnUeuLWtwYKXwP/nC96nsYyARMCEc8uI6YsCd7n28H3h1eG8PDSiyrXBUU+HgEtRXHaxV72fPFWVwV+4ff6gSt7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0DkNgBi2w3yGNdHk+t4lxxcSib3hEsMuRVhgdvhK/Yk=; b=fezf9oZUN5AO3zpeKbaWpNqTjqhD5ZhEXqTPsC6tsmvHjMOy+va7ZeuAi2W50rjnKsu0IE9MI5Jqn6jC9l5IWtaRW9nL+hc2DyaJEQUJnTYzlWIrYJmD6HsHpdsxH69ejbNAfgSbkJVnKa9vV4/xCnO2dY7DOcntHftbV3MXscg=
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com (2603:10a6:208:22::25) by AM0PR0702MB3780.eurprd07.prod.outlook.com (2603:10a6:208:1f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.9; Tue, 28 Apr 2020 09:32:59 +0000
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::9c11:1589:8e18:5209]) by AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::9c11:1589:8e18:5209%3]) with mapi id 15.20.2958.014; Tue, 28 Apr 2020 09:32:59 +0000
From: Balázs Varga A <balazs.a.varga@ericsson.com>
To: "Tim Evens (tievens)" <tievens@cisco.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-detnet-ip-over-mpls.all@ietf.org" <draft-ietf-detnet-ip-over-mpls.all@ietf.org>, "detnet@ietf.org" <detnet@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-detnet-ip-over-mpls-05
Thread-Index: AQHWF2G3lPyTErHnwEaK8VKryxCv+aiNC53QgACiQoCAAKDyIA==
Date: Tue, 28 Apr 2020 09:32:56 +0000
Message-ID: <AM0PR0702MB3603C422B308C33BE5D9F606ACAC0@AM0PR0702MB3603.eurprd07.prod.outlook.com>
References: <158742114339.19382.10522767782147188556@ietfa.amsl.com> <AM0PR0702MB36033FFDB22B0D9572A85645ACAF0@AM0PR0702MB3603.eurprd07.prod.outlook.com> <E8DF16AB-45C2-4CA5-A5A8-DBAF1C8FED31@cisco.com>
In-Reply-To: <E8DF16AB-45C2-4CA5-A5A8-DBAF1C8FED31@cisco.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [84.236.75.160]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a8202fdb-732b-49e5-1008-08d7eb572440
x-ms-traffictypediagnostic: AM0PR0702MB3780:
x-microsoft-antispam-prvs: <AM0PR0702MB3780759A85177EBE3BF1DE77ACAC0@AM0PR0702MB3780.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0387D64A71
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0702MB3603.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(346002)(39860400002)(376002)(396003)(66946007)(64756008)(66556008)(66476007)(66446008)(53546011)(66574012)(52536014)(55016002)(7696005)(110136005)(54906003)(316002)(9686003)(26005)(478600001)(85182001)(5660300002)(6506007)(186003)(4326008)(76116006)(81156014)(8936002)(85202003)(8676002)(86362001)(71200400001)(33656002)(2906002)(6666004); DIR:OUT; SFP:1101;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QRAX9jGAZWQQVldXP2IIG6HnZiq5P+xm00z6KIbTGYh932OG0MZXeCy+QVI4bMkOw5p8PmqbWm2kW0Ql//dKyoT5pjH0Kf7KvXkq77sSS/9RbMIfy9C/vMPsqZ0xUq+2ZuJK3REKOwCSpvnXBHh84ZohD8utLvHtEAkZEP7Izxbhca9+mtwxOkYuxKS9JO+E+yEuzGhOQGphSfYdqrZ9PNXbv43UDgKngcA8VlL2C7ObLDfVmzEmeGyJX5lMqT1jCMU5daPoOqg1SDRf5V9EGzl3YfMNPUN1sFbeCISaM0+o5/v9IbVgDk2DMDORUBVqyACZihKigPd8RsX7xqE08HcgiSQOSd6ulxGNv4RkXMcrP3TcmPmSeq37cFhbYYqb3XOtujvTkPewE05efnqafzrYbDy7a579Nzw1fGNw9HLybcL8hINk/ZyXMDBGM6YoEtl38/duRmXPt0V8u4u1yrc4gY3h1h+KG/YQ5ahloTDul/64kOxdIJQg+AyfwrTqVXEG0htaLOR2DBVY78wpxg==
x-ms-exchange-antispam-messagedata: M4cIvmmU1rkzS+30P4RRWcI+4/EbX8Lu6hmYL5gtWs2Tm61YPOqJrUiX46DH2RR06H5s/G622kHfKuUKHMBJGJig3r4NpgZroVKaCrTpXv7rWz0zsed/3/piZZ7+ljWAEyiIrh3rJ4j6AVqMnt/CKQXK/1kZCDbRP09EZnm1ZBDetqlENKXdCeu2lFQQ12YjDrzM4HQgPFlezAu6xUZ2IfRUlL3y4dRuQoYNf+zEUBh+8qTfwimAUmpopaaaln6PaNHhXMQ86aRkjwsAOxbd5OpgAQCl9nXmBikG8XG87/VYdJXWXyNUedd3YgXa06xVxwuJEgkHr8Vssy/MrFs4ndoX5rN3O7wfKgG2/KJBhE0T3rEpME4PoLJvKwyLyioH9QmU7b3hij0NV/yuCXeChf4KP+ufe3Xm5AYb5C26PU3BewLeyN5lXlJ+xEWllnmKSX1DohOMxvraeAdSCg1Ip1ulMRpd/mmwTeFn/nIyWXjD3qBgSMUQZsJBnjiLVNps/UwpuXQSUPvG7rtWFE7DgCLf0c9SCfXA+6uuTQLdxtbcekihD3XY7ln4ympW6uojpBahU9Hoq33jsZrpdPw2lUhVJTvVR08uZ3yx8pac9iqc8AXAmGpXGhQfkzPJQZKji0igQq0SF0HOZDKxSk1H9CyQ3WgQ6I1MlalgUIQ4U+rMJq4o6ofWRTdWUbVhmHQckIMVYkQUIySPDNiMmpUbHV/EDQ53yVkprXvZ7oDawITCckvityfvCNt7sI5Mu0T6ZrUqUPu01dS/LrB1v1oou/brrAkK7cZAd/+RLHj4Emc=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8202fdb-732b-49e5-1008-08d7eb572440
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 09:32:58.7851 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j0LnlRmtg3Lb0S6O/Azz7aolpSFOzBcJ89Otbn3+fhnW2gOk2tNth+0lm9oD/3W2THhvLR6bY0XnwBCzsQxfbnu9C+MjAr823DjWFOn2gOo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0702MB3780
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/DS08uboGI4P383nSCIo2DVUpU7I>
Subject: Re: [Detnet] Genart last call review of draft-ietf-detnet-ip-over-mpls-05
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 09:33:05 -0000
Hi Tim, Thanks for the explicit suggestions, I agree that makes text clearer. I will update the draft accordingly in the suggested format. Cheers Bala'zs -----Original Message----- From: Tim Evens (tievens) <tievens@cisco.com> Sent: Tuesday, April 28, 2020 1:48 AM To: Balázs Varga A <balazs.a.varga@ericsson.com>; gen-art@ietf.org Cc: draft-ietf-detnet-ip-over-mpls.all@ietf.org; detnet@ietf.org; last-call@ietf.org Subject: Re: Genart last call review of draft-ietf-detnet-ip-over-mpls-05 Hi Bala'zs, For the most part, great. See comments inline marked [tievens]... On 4/27/20, 7:22 AM, "Balázs Varga A" <mailto:balazs.a.varga@ericsson.com> wrote: Hi Tim, Thanks for the review. Your comments will be incorporated in the next version. Feedbacks are inline below marked with <BV>. Many thanks Bala'zs -----Original Message----- Subject: Genart last call review of draft-ietf-detnet-ip-over-mpls-05 Reviewer: Tim Evens Review result: Ready with Nits ... In Section 4.2: * There is reference to section 5.1.1 and 5.1.2, but those sections do not exist in this draft. Can you clarify which draft/RFC these sections are referring to? <BV> Right, they are referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/". Reference is at the end of the sentence. " ... IP" and "NProto" indicate the fields described in Section 5.1.1. IP Header Information and Section 5.1.2. Other Protocol Header Information in [I-D.ietf-detnet-ip], respectively. [tievens] The reference is assumed instead of being direct, such as "as defined in Section 5.1.1 of [<draft>]" * "Per [I-D.ietf-detnet-mpls], the DetNet MPLS data plane uses a single S-Label to support a single app flow. Section 5.1. DetNet IP Flow Identification Procedures ..." Why is Section 5.1 referenced like this? <BV> Again, this is referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/". [tievens] the callout here is that this type of reference is on the side of being terse, not succinct and clear as to which document this section is belongs. Would it not be more succinct and clear as: "Per Section 5.1 of [I-D.ietf-detnet-mpls], the DetNet MPLS data plane uses a single S-Label to support a single app flow. DetNet IP Flow Identification Procedures in Section 4.4 of [I-D.ietf-detnet-ip] states that a single DetNet flow is identified based on IP, and next level protocol, header information." ? * "DetNet IP Flow Identification Procedures in [I-D.ietf-detnet-ip] states that a single DetNet flow is identified based on IP, and next level protocol, header information. Section 4.4. Aggregation..." It would be more clear to specifically refer to the draft/rfc and section. <BV> Again, this is referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/". [tievens] IMO, this would benefit from being more clear as stated above. It doesn't add much verbosity to add "<section> of [<draft/rfc>].
- [Detnet] Genart last call review of draft-ietf-de… Tim Evens via Datatracker
- Re: [Detnet] Genart last call review of draft-iet… Balázs Varga A
- Re: [Detnet] Genart last call review of draft-iet… Tim Evens (tievens)
- Re: [Detnet] Genart last call review of draft-iet… Balázs Varga A
- Re: [Detnet] Genart last call review of draft-iet… Tim Evens (tievens)
- Re: [Detnet] [Gen-art] Genart last call review of… Alissa Cooper