Re: [Detnet] Genart last call review of draft-ietf-detnet-ip-over-mpls-05

"Tim Evens (tievens)" <tievens@cisco.com> Mon, 27 April 2020 23:48 UTC

Return-Path: <tievens@cisco.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F47F3A0775; Mon, 27 Apr 2020 16:48:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.6
X-Spam-Level:
X-Spam-Status: No, score=-9.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=KFZ0ZzhL; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=OLfhKpbn
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W5bFIY-JFy5X; Mon, 27 Apr 2020 16:48:19 -0700 (PDT)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3A80D3A0772; Mon, 27 Apr 2020 16:48:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3552; q=dns/txt; s=iport; t=1588031299; x=1589240899; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XnE7bk+e2RMoKsLpNwRFy0bitNtPsJL/Ugdxu1KJJKU=; b=KFZ0ZzhLtd0d60XWaAcPUDDwSiKHd3vT6ddztTla2q0soUQsPWwcOnzv +alq6ACCDajh4pCEA3Ogy8WPQ9iH+vYJY6OliCwfGhEudZYxsz+vChPp0 HaATgZupnTXS+DxOhz0GDELgo9q966KC5de0zZWb152ILlx5aWgmF1YwS s=;
IronPort-PHdr: =?us-ascii?q?9a23=3ARPSWKxwLXG3gObvXCy+N+z0EezQntrPoPwUc9p?= =?us-ascii?q?sgjfdUf7+++4j5YhSN/u1j2VnOW4iTq+lJjebbqejBYSQB+t7A1RJKa5lQT1?= =?us-ascii?q?kAgMQSkRYnBZuZCEDlIfjxRyc7B89FElRi+iLzPA=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CnBQCNbqde/5RdJa1mHAEBAQEBBwE?= =?us-ascii?q?BEQEEBAEBPIFHgVRRBWxYIAQLKgqEFYNGA4pygl+YL4JSA1QLAQEBDAEBIwo?= =?us-ascii?q?CBAEBhEQCF4IRJDgTAgMBAQsBAQUBAQECAQUEbYVWDIVxAQEBAQMSEREMAQE?= =?us-ascii?q?3AQsEAgEGAhcDAiMDAgICMBQBCAgCBAENBSKDBAGCSwMuAQ6XPJBnAoE5iGF?= =?us-ascii?q?2gTKDAAEBBYFGQYMiGIIOAwaBDiqCY4laGoFBP4ERJxyCTT6CZwIDAYFhBzE?= =?us-ascii?q?Cglgygi2RO6BrCoJFiA+PcRYHnHuPeolIkz4CBAIEBQIOAQEFgWkigVZwFWU?= =?us-ascii?q?Bgj5QGA2RNINyhRSFQnQCMwIGAQcBAQMJfI0QAYEPAQE?=
X-IronPort-AV: E=Sophos;i="5.73,325,1583193600"; d="scan'208";a="469607587"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 27 Apr 2020 23:48:18 +0000
Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id 03RNmIhS029846 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 27 Apr 2020 23:48:18 GMT
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 27 Apr 2020 18:48:18 -0500
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 27 Apr 2020 19:48:17 -0400
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 27 Apr 2020 19:48:17 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=binYpid9rrddIYDouW/fPK5UQP5A/7hzGOmhe5OVQoFW1QT9aWtoFE2FZlvm+c3aoSfNAV8YXnnvllKcCMR4CMKuPtOTtVd4IRlkbBJ7TjzkEjpgoUwPZaFHgvahVNnGjFGj+siO2v3Hn++2q/2eW2EQmWlSMMESi0UoP9//ziZEI5laVwjd5HAenZYWP4sTSu1fJAKWuwJlGuFVFEqzUQXbfPgdB0g9fN0XJ1LdCR2ih5jzyVuQXWYb2LsVlaXHKOdQGx+efzvDLW14/CePuzQCiqq0ZaKAUcw1XydJmsreBzq6fEbsxexmbUWbGyn92tZlim6CSKVGzzFeJjh8Hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XnE7bk+e2RMoKsLpNwRFy0bitNtPsJL/Ugdxu1KJJKU=; b=EOVM96hrSfwPUl2Ytpqp1PKIbgYC0ELrwesEOCGPD2N47VPmDsHDO+EKDWmzmZtQO6HZird7nXkoqduyvFV5JHwuEfS62KK8PtEIhdiXUB1zvm8BVMibHZ2Z0PowhnB717FWCVe12e1I3TOHp9PVmUZ3joTaSZi6JIOgwFsJ8+9wwTp1UhfoTyN292zEcWwgg1wz2ikvsnwVrnccJkDlXOhP9lcPp/Z9jYhiTJspeUytZeceyUnlPk3kAy5YomvWF15BbS8gdBWj/JOnnIb3N2BbBbf7CsQvih5eSdZRq00hyuZUhB1p/R5avCE2mgFSXdTqdKytM3tqxf0gQnlkvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XnE7bk+e2RMoKsLpNwRFy0bitNtPsJL/Ugdxu1KJJKU=; b=OLfhKpbn8vb74sGUoRkPElqrZKRCyBYJW2HlwZFGvzqMPH5ndzUvwExQabGOEy8P37+hDRRD65VystRZGVCN2/cEWtCrbAhrwVRrdkFgv1HEAHAjc68t9ldLrDZH7RCAtp5TMTTY4VCiCddtds2BhDWEaUmQbEYfPCk4Ii9djQM=
Received: from MW3PR11MB4651.namprd11.prod.outlook.com (2603:10b6:303:2c::21) by MW3PR11MB4732.namprd11.prod.outlook.com (2603:10b6:303:2c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 23:48:16 +0000
Received: from MW3PR11MB4651.namprd11.prod.outlook.com ([fe80::2000:f0e8:ae9f:31a8]) by MW3PR11MB4651.namprd11.prod.outlook.com ([fe80::2000:f0e8:ae9f:31a8%6]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 23:48:15 +0000
From: "Tim Evens (tievens)" <tievens@cisco.com>
To: =?utf-8?B?QmFsw6F6cyBWYXJnYSBB?= <balazs.a.varga@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-detnet-ip-over-mpls.all@ietf.org" <draft-ietf-detnet-ip-over-mpls.all@ietf.org>, "detnet@ietf.org" <detnet@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-detnet-ip-over-mpls-05
Thread-Index: AQHWHJ9IQx9qJN4N80m+hXdjZ3kC2KiNLgwA
Date: Mon, 27 Apr 2020 23:48:15 +0000
Message-ID: <E8DF16AB-45C2-4CA5-A5A8-DBAF1C8FED31@cisco.com>
References: <158742114339.19382.10522767782147188556@ietfa.amsl.com> <AM0PR0702MB36033FFDB22B0D9572A85645ACAF0@AM0PR0702MB3603.eurprd07.prod.outlook.com>
In-Reply-To: <AM0PR0702MB36033FFDB22B0D9572A85645ACAF0@AM0PR0702MB3603.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.36.20041300
authentication-results: spf=none (sender IP is ) smtp.mailfrom=tievens@cisco.com;
x-originating-ip: [128.107.241.171]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 026058ac-8560-4d3a-c696-08d7eb05749a
x-ms-traffictypediagnostic: MW3PR11MB4732:
x-microsoft-antispam-prvs: <MW3PR11MB47324C87A03A6AD44A7ECD45B6AF0@MW3PR11MB4732.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0386B406AA
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4651.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(8936002)(86362001)(91956017)(2906002)(66574012)(66946007)(6512007)(76116006)(36756003)(5660300002)(186003)(4326008)(71200400001)(26005)(33656002)(6486002)(81156014)(478600001)(66476007)(66446008)(8676002)(54906003)(2616005)(66556008)(64756008)(316002)(110136005)(6506007)(53546011); DIR:OUT; SFP:1101;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: uZXeRxOyHJT+yqLvug/g7YYoWWvX0SRUZ9X8LCbzjOrNKPmrn7YiXJQCq/MDYT6HY6Um/Xm5uHOOEWVUI5xoqofZD/9E0GC081PpS/zEyZ/I5dY0VWvrAN76bzT0HQNr9DSKmI22g/G4fZHdG5OsfMlfxICqrYklfRaSCCm1m5JcM3enXW0dSFWWdxG6LydWPlpPb3PXVs5kugERv3MIre4NXyODZtSB5i3WfWW/9tljnbDlMWZ2fhUBw8tVuDUFeWmiDVNmfUlZc3R3Xk2OWzz6A/GXzGUmszns1lENqOanZgStf3ZUNuS+Y/9Kk7WcdBA251D2dN8BemrHU3J9Ixt7Mxu6b3gOhxVrdOqEw46cKkkfDu2i9F06eoYVPov6ZRQqwHRAhJ8vxWWfuboc6XJUltVCJEiL1GhdIHhVNOAX2l5Ak73EmBijoXM55wqXk/z2UnR50L2SUfnF+gT54zhIoml/HemxAe85Kl9mF/iOk3prhEIEbqUNQRGZjS6lzdJ01sUqe1R4RJfjKzGVVg==
x-ms-exchange-antispam-messagedata: X5hLtrVUKESe4gG+H4T+PF/ZmJIu5ivjhIo7CsdXm37j/wHuN0T0Sy3Jy8khsCOqo5RdsT7imFop5O0GfIRV5qSDYhu25U0Dz7jJMNVdQ0YQAHnsR4Ke5WBFU0h0Z/ZZzVUR/jvka3+aKlHH43iQaxlPKemNAWFvdtBNOdbBTvTpTmnUzA3TP6bx9RaKpN0ADAJb2HQ2RH1isNtYGcrK93fnXUzYU28f5a7w478CKgazLiucBEt8kcqEEs5x02fJZ+DuZgfNJkSWtVv+qbjC183A4Os/Zk2lv0BfsQ4mVZ9fYPF7Ejc7wAKZ7UPMaJFv7dca9P+4OLkb/itgyz7RsgxhsG/9LcXl/mZrUXkxvM33C9Y6DxrmI2354Il5tIbNcxcQt04tF8AxOcPCuDyvk8LjzOs/2mP+Y4G6FgcxQfU1q/3hWGqRgJvaRepZyv1MejUU0o9O07pJQQilF3PHkG+fsNviIHS5J94rRNrKGZeaxko+hkCpOUAKTIlQYDX3GzJbakNiu7Ovl6Iws1TFkaoxGodb9SEMBlvfQ+MNnxg8rzSItEMOgnHIc+J+iGPj3z3uP41LUfDJnCmbgr6Uqx58m3mO6q+qtbygt6kxB9NZ7UL42NIS96b1Iywy1AkLnis64OLUAoFyPNa9n0fVfFnqbWr9P+/9iBnS+xOBhZSPVP442QYDTUK7jbtaJ42qCSqelxEjoS+LjLwOGXGaFzDi9xniCGYGUVAh5PHmoXdeL50diD40z3NvS9xeMNCGr/wrS33tdf52EqwltTi+LZ/Po0152QbRkOv5EFxFXZCm0jZZMW0RKSBuITRjbUdo
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <16BB96F3666E6A48AD33B372A1C4A4E5@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 026058ac-8560-4d3a-c696-08d7eb05749a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 23:48:15.8275 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ePvSdwC+6rVJ+7Jz9RbDC7VArHqSo15U4LQWIDkdyNw/R211zdkWFy2edAQ3GyNQNYET+z7Md6dlaaPdo4Y+Bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4732
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.14, xch-aln-004.cisco.com
X-Outbound-Node: rcdn-core-12.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/_EZqb2T2Pv9CJh40SiBb-0Lx9Ac>
Subject: Re: [Detnet] Genart last call review of draft-ietf-detnet-ip-over-mpls-05
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Apr 2020 23:48:22 -0000

Hi Bala'zs, 

For the most part, great.   See comments inline marked [tievens]...


On 4/27/20, 7:22 AM, "Balázs Varga A" <mailto:balazs.a.varga@ericsson.com> wrote:

Hi Tim,
Thanks for the review. Your comments will be incorporated in the next version.
Feedbacks are inline below marked with <BV>.
Many thanks
Bala'zs
 
-----Original Message-----
Subject: Genart last call review of draft-ietf-detnet-ip-over-mpls-05
 
Reviewer: Tim Evens
Review result: Ready with Nits
 
... 

In Section 4.2:
 
* There is reference to section 5.1.1 and 5.1.2, but those sections do not exist in this draft.  Can you clarify which draft/RFC these sections are referring to? 
<BV> Right, they are referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/". Reference is at the end of the sentence. 
  "   ...   IP" and "NProto" indicate the fields described in
   Section 5.1.1.  IP Header Information and Section 5.1.2.  Other
   Protocol Header Information in [I-D.ietf-detnet-ip], respectively.

[tievens] The reference is assumed instead of being direct, such as "as defined in Section 5.1.1 of [<draft>]"
 
* "Per [I-D.ietf-detnet-mpls], the DetNet MPLS data plane uses a single
   S-Label to support a single app flow.  Section 5.1.  DetNet IP Flow
   Identification Procedures ..."  
 
   Why is Section 5.1 referenced like this?
<BV> Again, this is referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/".

[tievens] the callout here is that this type of reference is on the side of being terse, not succinct and clear as to which document this section is belongs. Would it not be more succinct and clear as:

  "Per Section 5.1 of [I-D.ietf-detnet-mpls], the DetNet MPLS data plane uses a single
     S-Label to support a single app flow. DetNet IP Flow
     Identification Procedures in Section 4.4 of [I-D.ietf-detnet-ip] states that a
     single DetNet flow is identified based on IP, and next level
     protocol, header information."
?
 
* "DetNet IP Flow Identification Procedures in [I-D.ietf-detnet-ip] states
   that a single DetNet flow is identified based on IP, and next level
   protocol, header information.  Section 4.4.  Aggregation..."  
   
   It would be more clear to specifically refer to the draft/rfc and section.
<BV> Again, this is referring to "https://datatracker.ietf.org/doc/draft-ietf-detnet-ip/".
 
[tievens] IMO, this would benefit from being more clear as stated above.  It doesn't add much verbosity to add "<section> of [<draft/rfc>].