Re: [dispatch] Two week review: Progressing draft-mohali-dispatch-originating-cdiv-parameter as AD sponsored

worley@ariadne.com (Dale R. Worley) Thu, 12 January 2017 19:56 UTC

Return-Path: <worley@alum.mit.edu>
X-Original-To: dispatch@ietfa.amsl.com
Delivered-To: dispatch@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1283312951E for <dispatch@ietfa.amsl.com>; Thu, 12 Jan 2017 11:56:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.934
X-Spam-Level:
X-Spam-Status: No, score=-1.934 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_SOFTFAIL=0.665] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u4-uMdmz6HzB for <dispatch@ietfa.amsl.com>; Thu, 12 Jan 2017 11:56:20 -0800 (PST)
Received: from resqmta-po-08v.sys.comcast.net (resqmta-po-08v.sys.comcast.net [IPv6:2001:558:fe16:19:96:114:154:167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F1CCE1294F9 for <dispatch@ietf.org>; Thu, 12 Jan 2017 11:56:19 -0800 (PST)
Received: from resomta-po-06v.sys.comcast.net ([96.114.154.230]) by resqmta-po-08v.sys.comcast.net with SMTP id RlSqcSaeJwySVRlTucvaSI; Thu, 12 Jan 2017 19:56:18 +0000
Received: from hobgoblin.ariadne.com ([IPv6:2601:192:4603:9471:222:fbff:fe91:d396]) by resomta-po-06v.sys.comcast.net with SMTP id RlTtc8jiUpJ41RlTuccoQ7; Thu, 12 Jan 2017 19:56:18 +0000
Received: from hobgoblin.ariadne.com (hobgoblin.ariadne.com [127.0.0.1]) by hobgoblin.ariadne.com (8.14.7/8.14.7) with ESMTP id v0CJuHhN018225; Thu, 12 Jan 2017 14:56:17 -0500
Received: (from worley@localhost) by hobgoblin.ariadne.com (8.14.7/8.14.7/Submit) id v0CJuHJa018222; Thu, 12 Jan 2017 14:56:17 -0500
X-Authentication-Warning: hobgoblin.ariadne.com: worley set sender to worley@alum.mit.edu using -f
From: worley@ariadne.com
To: marianne.mohali@orange.com
In-Reply-To: <24870_1484206994_58773392_24870_3860_1_8B970F90C584EA4E97D5BAAC9172DBB81C8AE14B@OPEXCLILMA4.corporate.adroot.infra.ftgroup> (marianne.mohali@orange.com)
Sender: worley@ariadne.com
Date: Thu, 12 Jan 2017 14:56:17 -0500
Message-ID: <87bmvc6oim.fsf@hobgoblin.ariadne.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/dispatch/-_CCF5R2AnLoQ026Mtm_HTInZo8>
Cc: dispatch@ietf.org
Subject: Re: [dispatch] Two week review: Progressing draft-mohali-dispatch-originating-cdiv-parameter as AD sponsored
X-BeenThere: dispatch@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: DISPATCH Working Group Mail List <dispatch.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dispatch>, <mailto:dispatch-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dispatch/>
List-Post: <mailto:dispatch@ietf.org>
List-Help: <mailto:dispatch-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dispatch>, <mailto:dispatch-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2017 19:56:21 -0000

Comments regarding the much-improved
draft-mohali-dispatch-originating-cdiv-parameter-03:

The ABNF in section 4.2 could be clarified and simplified, I think.
There are various nits I could mention, but those matters will be better
handled by the RFC Editor.

4.2.  ABNF

 sessioncase-param        = 1("sescase" EQUAL 1("orig" / "term")/ orig-cdiv)
 registration-state-param = "regstate" EQUAL 1("unreg" / "reg")
 orig-cdiv                = "orig-cdiv"

It seems like you could simplify the BNF by using "orig-cdiv" as a
constant rather than having a nonterminal for it.

The "1" multipliers aren't needed, since that is the default effect of
"(...)".  If the multiplers are removed, the outer parentheses for
"sessioncase-param" aren't needed.  Adding parentheses around the
first alternative of "sessioncase-param" makes the production clearer.
(per RFC 5234 section 3.5, "It is strongly advised that grouping
notation be used, rather than relying on the proper reading of "bare"
alternations, when alternatives consist of multiple rule names or
literals.")

The result of these changes would be

 sessioncase-param        = ("sescase" EQUAL ("orig" / "term")) / "orig-cdiv"
 registration-state-param = "regstate" EQUAL ("unreg" / "reg")

Dale