Re: [dtn] AD review of draft-ietf-dtn-bpsec-default-sc-02

"Birrane, Edward J." <Edward.Birrane@jhuapl.edu> Mon, 12 April 2021 04:55 UTC

Return-Path: <Edward.Birrane@jhuapl.edu>
X-Original-To: dtn@ietfa.amsl.com
Delivered-To: dtn@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 897B03A2E60 for <dtn@ietfa.amsl.com>; Sun, 11 Apr 2021 21:55:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.4
X-Spam-Level:
X-Spam-Status: No, score=-4.4 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=jhuapl.edu
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aisg3Wg5Y30g for <dtn@ietfa.amsl.com>; Sun, 11 Apr 2021 21:55:34 -0700 (PDT)
Received: from aplegw01.jhuapl.edu (aplegw01.jhuapl.edu [128.244.251.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F32533A2E5F for <dtn@ietf.org>; Sun, 11 Apr 2021 21:55:33 -0700 (PDT)
Received: from pps.filterd (aplegw01.jhuapl.edu [127.0.0.1]) by aplegw01.jhuapl.edu (8.16.0.43/8.16.0.43) with SMTP id 13C4tT9U136318; Mon, 12 Apr 2021 00:55:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jhuapl.edu; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=JHUAPLDec2018; bh=ZQ2Bsl0AjCtMuEhf89pQpsBMcuq9DQBBi+4i1FmbPEs=; b=FQp47l581eLKMC4ZJ1IOnDXTVuAcUI2tvszUYYs9Tdn0spaZd5n6OjdsHnT1fx1zfrY8 FKnRajvyn1PaVSpihSE18YEr5tDub4yALX54Q9lz08aF4xLeHzc3VSJh/Ea80kCxegRP d3ea/BWGuBJ8Dw+6uD/956ScWiiwfniP16rXTOTK6qg4UUTtgfHtO9W2XndRPQMegT5G XFvr2wI9DVdjUMy5YaNxUvq+RJLqk3rexQe9DLj0npvvHiYfPHLuxcQCI00bFwM3Em3b hjCZV7Uz0yJkenF+UBiUwKVg8rJVrzJPD8sZU2N9RpLt+dprFeiBoW9Gozhro5rKAiZv Wg==
Received: from aplex06.dom1.jhuapl.edu (aplex06.dom1.jhuapl.edu [128.244.198.140]) by aplegw01.jhuapl.edu with ESMTP id 37u52agunv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 12 Apr 2021 00:55:29 -0400
X-CrossPremisesHeadersFilteredBySendConnector: APLEX06.dom1.jhuapl.edu
Received: from aplex01.dom1.jhuapl.edu (128.244.198.5) by APLEX06.dom1.jhuapl.edu (128.244.198.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Apr 2021 00:55:28 -0400
Received: from aplex01.dom1.jhuapl.edu ([fe80::19f5:dcc5:c696:1a50]) by aplex01.dom1.jhuapl.edu ([fe80::19f5:dcc5:c696:1a50%25]) with mapi id 15.00.1497.012; Mon, 12 Apr 2021 00:55:28 -0400
From: "Birrane, Edward J." <Edward.Birrane@jhuapl.edu>
To: Zaheduzzaman Sarker <zaheduzzaman.sarker@ericsson.com>, "dtn@ietf.org" <dtn@ietf.org>
CC: Magnus Westerlund <magnus.westerlund@ericsson.com>
Thread-Topic: AD review of draft-ietf-dtn-bpsec-default-sc-02
Thread-Index: AQHXH1vax7LWSJVgGEW7LhnHV51gYaqaUmZQgAOJLQCAEEy0kA==
Date: Mon, 12 Apr 2021 04:55:27 +0000
Message-ID: <441c2b556fd645dfa8b520ffea86e27c@aplex01.dom1.jhuapl.edu>
References: <EAF9AEEC-B28E-48AC-BE47-1DAD6FA3609B@ericsson.com> <7b1238eb22fa41cd826548c5a53f2e42@aplex01.dom1.jhuapl.edu> <1663F867-DB26-4B00-B341-EAE4AB84D39B@ericsson.com>
In-Reply-To: <1663F867-DB26-4B00-B341-EAE4AB84D39B@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [128.244.198.168]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OrganizationHeadersPreserved: APLEX06.dom1.jhuapl.edu
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-12_03:2021-04-09, 2021-04-12 signatures=0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dtn/YH-BnQNvqnxxZdi6Db0RE4KVCmw>
Subject: Re: [dtn] AD review of draft-ietf-dtn-bpsec-default-sc-02
X-BeenThere: dtn@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Delay Tolerant Networking \(DTN\) discussion list at the IETF." <dtn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dtn>, <mailto:dtn-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dtn/>
List-Post: <mailto:dtn@ietf.org>
List-Help: <mailto:dtn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dtn>, <mailto:dtn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2021 04:55:39 -0000

Zahed,
  
  I think we are getting close.  I have posted a -04 version of the document. 

  My comments are below and prefaced with [EB].

> In section 4.1 :
> 
> The BCB-AES-GCM security context shall have the security context
> 	   identifier specified in Section 5.1.
> 
> is this "shall" should be a "MUST" as described in Section 3.1?

[EB] Yes! Good catch. This has been updated in the -04 version of the draft.

 
> [ZS] Ok,  is this consensus documented somewhere? Meeting notes or email
> thread or whatever?

[EB] Specific to key communication, the intent from the DTNWG through the last call was to use an approved key wrap algorithm from NIST 800-38F (which really means AES-KW since we do not have keys which require the alternate padding variant). The attempt to leave room for "other key communication techniques" that were not requested by the WG is, on reflection, more likely to hurt interoperability than to provide additional utility. I simplified this language in -04 to state AES-KW as defined in NIST 800-38F.

[EB] The default security context is meant to be a simple context that can be easy to implement with well-understood algorithms - particularly since this security context is required as a normative reference for BPv7 and BPSec. We fully expect other security contexts to be defined over time (one based on COSE is in work now) which can capture more complex behavior. 


>     > * Section 4.3.2 :
>     >      Does this "security policy" refers to local security policy?
> 
>     C15: Yes.  Security policy at the source, verifier, or acceptor is meant to
> imply the local security policy at the node.
> 
> [ZS] Ok, then clearly stating that helps. It was clearly mention in the other
> place(s).

[EB] Agree! Change made.


> [ZS] I don't think removing the fragmentation section from this document to
> some other document actually helps. This is a very important aspect of the
> security context and I think it is better to be decisive about it now. If moved
> to BPSec then other documents , specially security context documentation,
> can just refer to it. The question really is, where does it make more sense put
> there it is in line with the context of the content of the document? Right now
> I see that is BPsec.

[EB] I'm certainly fine with keeping the text in this default security context document, and left it in for the -04 version of the document.

[EB] I would not want to add this to BPSec for two reasons: (1) It is possible that some security contexts may not have these specific fragmentation vulnerabilities, (2) the impact of fragmentation on security is akin to the impact of bundle modification on security (consider malicious fragmentation) and thus covered in BPSec already. 


> [ZS] I see the test vectors related to the applicability of the this document
> hence this need to be considered well. Failing to assure interoperability
> actually undermine the intention of this document, hence any tools to help
> achieving that goal is worth putting effort into. Also we need to make sure
> the test vector is actually usable by more than one implementation.  I would
> be happy if DTN WG comes up with a best way forward here.

[EB] My only concern regarding test vectors was that there is no new algorithm here. But they certainly don't hurt! I can generate some vectors for this document.

-Ed

---
Edward J. Birrane, III, Ph.D.
Embedded Applications Group Supervisor
Space Exploration Sector
Johns Hopkins Applied Physics Laboratory
(W) 443-778-7423 / (F) 443-228-3839