Re: [Ecrit] [Last-Call] Genart last call review of draft-ietf-ecrit-similar-location-17
Russ Housley <housley@vigilsec.com> Tue, 01 February 2022 15:00 UTC
Return-Path: <housley@vigilsec.com>
X-Original-To: ecrit@ietfa.amsl.com
Delivered-To: ecrit@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D14873A1174; Tue, 1 Feb 2022 07:00:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gjftCnCjf30E; Tue, 1 Feb 2022 07:00:13 -0800 (PST)
Received: from mail3.g24.pair.com (mail3.g24.pair.com [66.39.134.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BF8023A117A; Tue, 1 Feb 2022 07:00:13 -0800 (PST)
Received: from mail3.g24.pair.com (localhost [127.0.0.1]) by mail3.g24.pair.com (Postfix) with ESMTP id 070CDD48EF; Tue, 1 Feb 2022 10:00:11 -0500 (EST)
Received: from [192.168.1.161] (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail3.g24.pair.com (Postfix) with ESMTPSA id E181AD4670; Tue, 1 Feb 2022 10:00:10 -0500 (EST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <B2B4054F-C543-4B7D-B77F-5079A72D87EC@coretechnologyconsulting.com>
Date: Tue, 01 Feb 2022 10:00:09 -0500
Cc: last-call@ietf.org, IETF Gen-ART <gen-art@ietf.org>, ecrit@ietf.org, draft-ietf-ecrit-similar-location.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <23AA425C-1B5C-4403-92F2-9E3CC7AA1EA4@vigilsec.com>
References: <164350445633.30531.10572441517907261963@ietfa.amsl.com> <B2B4054F-C543-4B7D-B77F-5079A72D87EC@coretechnologyconsulting.com>
To: Randall Gellens <rg+ietf@coretechnologyconsulting.com>
X-Mailer: Apple Mail (2.3445.104.21)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ecrit/qa1ZPU98upaAt5EBkKck2hN1H4k>
Subject: Re: [Ecrit] [Last-Call] Genart last call review of draft-ietf-ecrit-similar-location-17
X-BeenThere: ecrit@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Emergency Context Resolution with Internet Technologies <ecrit.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ecrit>, <mailto:ecrit-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ecrit/>
List-Post: <mailto:ecrit@ietf.org>
List-Help: <mailto:ecrit-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ecrit>, <mailto:ecrit-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Feb 2022 15:00:18 -0000
Randall: This direction seem fine to me, but I think you misunderstood my suggestion (4). I am just suggesting a change in ordering, State the definition, and then use the defined term. Russ > On Jan 31, 2022, at 5:59 PM, Randall Gellens <rg+ietf@coretechnologyconsulting.com> wrote: > > (1) I'm fine with the Abstract as it is, I don't think it needs to be shortened, but if Russ' suggestion is taken, I'd want his new text "This extension is applicable when the location information in the <findService> request uses the Basic Civic profile as described in RFC 5222" deleted, as the extension can potentially be used with future profiles. > > (2) Regarding the suggestion to either delete the final paragraph of Section 1 or expand it to list all the sections, an alternative is to edit it down to list only what's most useful to a reader, e.g., change: > > The structure of this document includes terminology, Section 2, > followed by a discussion of the basic elements involved in location > validation. The use of these elements, by way of example, is > discussed in an overview section, Section 3, with accompanying > rationale, and a brief discussion of the impacts to LoST, and its > current schema. > > To something such as: > > A discussion of the basic elements involved in location > validation, along with definitions of certain terms used in this > document, is in Section 2. Usage, with examples, accompanying > rationale, and a brief discussion of the impacts to LoST and its > current schema, is in Section 3. > > > (3) Regarding the MUST NOT text in Section 3, I'm fine with Dan's suggestions, but if we are rewording it, I suggest: > > The location profile of Location Information returned by a server > MUST be the same as the profile of the location used to answer > the query. By extension, this means that the profile of Location > Information returned by a server MUST be a location profile used > by the client in the request. > > (4) Regarding the suggestion to add a definition of Valid Location, the document currently defines it; perhaps the suggestion is to define a new term such as "Valid Location Response" or "Valid Location Indication"? At any rate, since the document already defines Valid Location, we can just delete the explanatory: > > i.e., > containing the <locationValidation> element with no elements listed > as invalid, > > This also aligns with Dan's suggested rewording. I'm also fine with leaving the text as is. > > --Randall > > On 29 Jan 2022, at 17:00, Russ Housley via Datatracker wrote: > >> Reviewer: Russ Housley >> Review result: Almost Ready >> >> I am the assigned Gen-ART reviewer for this draft. The General Area >> Review Team (Gen-ART) reviews all IETF documents being processed >> by the IESG for the IETF Chair. Please wait for direction from your >> document shepherd or AD before posting a new version of the draft. >> >> For more information, please see the FAQ at >> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. >> >> Document: draft-ietf-ecrit-similar-location-17 >> Reviewer: Russ Housley >> Review Date: 2022-01-29 >> IETF LC End Date: 2022-02-09 >> IESG Telechat date: unknown >> >> Summary: Almost Ready >> >> >> Major Concerns: None >> >> >> Minor Concerns: >> >> The Abstract could be much shorter. I suggest: >> >> This document describes an extension to the LoST protocol that is >> specified in RFC 5222 that allows additional civic location >> information to be returned in the <locationValidation> element of a >> <findServiceResponse>. This extension supports two use cases. First, >> when the input location is incomplete, the LoST server can provide a >> complete intended unique address. Second, when the input location is >> invalid, the LoST server can identify one or more feasible locations. >> This extension is applicable when the location information in the >> <findService> request uses the Basic Civic profile as described in >> RFC 5222. >> >> Section 1 says: >> >> ... Use of this >> enhancement increases the likelihood that the correct and/or complete >> form of a civic location becomes known in those cases where it is >> incomplete or incorrect. >> >> I think it would be more clear to turn the sentence around: >> >> ... When incomplete or incorrect civic location information >> is provided, use of this enhancement increases the likelihood >> that correct and complete civic location can be learned. >> >> Section 1 ends with a discussion about what the document contains, but >> it is incomplete. Either drop the paragraph, or tell what is coming in >> all of the coming sections. >> >> Section 3 says: >> >> ... A server MUST NOT include Returned Location >> Information using a location profile that differs from the profile of >> the location used to answer the query and, by extension, MUST NOT >> include Returned Location Information using a location profile that >> was not used by the client in the request. >> >> Can this be turned into a simple MUST statement? Perhaps: >> >> ... A server MUST include only Returned Location >> Information using a location profile that was used by the >> client in the request. >> >> Section 3 says: >> >> In a LoST <findServiceResponse> indicating a Valid Location i.e., >> containing the <locationValidation> element with no elements listed >> as invalid, the LoST server can use this extension to include >> additional location information in a <locationValidation> element. >> >> I think this would be more clear if it defined a Valid Location, and >> then use this definition: >> >> A Valid Location contains a <locationValidation> element without any >> elements listed as invalid. In a LoST <findServiceResponse> >> indicating a Valid Location, the LoST server can use this extension >> to include additional location information in a <locationValidation> >> element. >> >> >> Nits: >> >> Section 2: s/here. ./here./ >> >> Section 2: Some definitions end with a period, but one does not. >> Please add the missing period. >> >> Section 3: s/end-user/end user/ >> >> Section 3: s/intended by the user/intended by the end user/ >> >> Section 4: s/defined in RFC5222/defined in [RFC5222]/ >> >> Section 7: s/new threat/new security concern/ > > -- > last-call mailing list > last-call@ietf.org > https://www.ietf.org/mailman/listinfo/last-call
- [Ecrit] Genart last call review of draft-ietf-ecr… Russ Housley via Datatracker
- Re: [Ecrit] Genart last call review of draft-ietf… Dan Banks
- Re: [Ecrit] Genart last call review of draft-ietf… Randall Gellens
- Re: [Ecrit] [Last-Call] Genart last call review o… Russ Housley
- Re: [Ecrit] [Last-Call] Genart last call review o… Lars Eggert