[Gen-art] Gen-ART last call review of draft-ietf-marf-authfailure-report-09
Alexey Melnikov <alexey.melnikov@isode.com> Sat, 14 January 2012 17:22 UTC
Return-Path: <alexey.melnikov@isode.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B5C8F21F857F; Sat, 14 Jan 2012 09:22:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AaX5YlwPQUSA; Sat, 14 Jan 2012 09:22:56 -0800 (PST)
Received: from rufus.isode.com (rufus.isode.com [62.3.217.251]) by ietfa.amsl.com (Postfix) with ESMTP id E23F721F84FA; Sat, 14 Jan 2012 09:22:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1326561651; d=isode.com; s=selector; i=@isode.com; bh=R0mV63shGlhNR+15YVSMIn3BY93mrkb1jkpPP6yOzB4=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=RbfKUyaiO/zmU9xFD3wN5V5tAgEFYlz1TjHh9+q1QNDMnmvNQ9sEpjDsNAg3J4wycDHw43 Us1Qnox7DFIaccL2aCfhHwx67H63v09ruyNwnblxdmN4ClCBouvwJ21LYvSPlYF9o+fWxj BY7qFa1dvM3YJ/iFt5ZXLSLG6XWdxUg=;
Received: from [188.29.80.177] (188.29.80.177.threembb.co.uk [188.29.80.177]) by rufus.isode.com (submission channel) via TCP with ESMTPSA id <TxG5cQAV503R@rufus.isode.com>; Sat, 14 Jan 2012 17:20:51 +0000
Message-ID: <4F11B97D.30705@isode.com>
Date: Sat, 14 Jan 2012 17:21:01 +0000
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0) Gecko/20111105 Thunderbird/8.0
To: "Hilda L. Fontana" <hilda@hfontana.com>, "Murray S. Kucherawy" <msk@cloudmark.com>, Pete Resnick <presnick@qualcomm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-transfer-encoding: quoted-printable
Cc: gen-art@ietf.org, The IESG <iesg@ietf.org>
Subject: [Gen-art] Gen-ART last call review of draft-ietf-marf-authfailure-report-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2012 17:22:56 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please resolve these comments along with any other Last Call comments you may receive. Document: draft-ietf-marf-authfailure-report-09 Reviewer: Alexey Melnikov Review Date: 2012ā01ā14 IETF LC End Date: 2012-01-18 IESG Telechat date: 2012-01-19 Summary: This draft is ready for publication as a standard RFC, but a couple of minor issues remain. Major issues: None Minor issues: 2.2. Base 64 Sorry for missing this earlier, but RFC 4648, Section 4 is a better reference for base64. (Don't forget the section reference, because RFC 4648 has 2 base64 alphabets.) In Section 4: > spf-dns = "SPF-DNS:" : { "txt" / "spf" } [CFWS] ":" [CFWS] > domain [CFWS] ":" [CFWS] quoted-string CRLF I think you are still missing [CFWS] before "txt" and another one before CRLF. Also, you should use "(" and ")" instead of "{" and "}", as the two latter are not valid according to ABNF syntax. To summarize, I think you should use: spf-dns = "SPF-DNS:" : [CFWS] ( "txt" / "spf" ) [CFWS] ":" [CFWS] domain [CFWS] ":" [CFWS] quoted-string [CFWS] CRLF Nits/editorial comments: None
- [Gen-art] Gen-ART last call review of draft-ietf-ā¦ Alexey Melnikov
- Re: [Gen-art] Gen-ART last call review of draft-iā¦ Murray S. Kucherawy