Re: [Gen-art] Genart last call review of draft-ietf-detnet-mpls-over-tsn-05

Balázs Varga A <balazs.a.varga@ericsson.com> Mon, 08 February 2021 20:46 UTC

Return-Path: <balazs.a.varga@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 348B33A17B7; Mon, 8 Feb 2021 12:46:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.351
X-Spam-Level:
X-Spam-Status: No, score=-2.351 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fDIzj9YUZtoC; Mon, 8 Feb 2021 12:46:29 -0800 (PST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 693943A17B3; Mon, 8 Feb 2021 12:46:05 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TrQ4ZQryCEY2Af04gA07BzMsrQaj5Vdeg8ZPGgMNL0v+7VhWN2PvS2qYPoeFMNjXcfaBqF9GvsdEz0oGOTKfXfZ5nzGKH7I3rL5JgjVdf6BgRMNYXUeE3g+I2DpAnBotFXzyZFwSio+4flkTBAmHXil0Fez4A3dPbyITyAqhI0kOtWLqqb3b3duJ+FZ5OLhfqHKIn10Hm24UQANlYGiNHHNuwNOC2gdbG/90mZZW3ddR8hQL0LWPXgDplUkQ+ysgxeTb3vJ08Zj4KRFFobMorKuLpHTaJACRrkVnZ9zMRuT3cyEIaLezDiwtKJ9GWkFuKwC7NnDfXy+JkE1On2Squg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bbde9gFVI79Es/fiVmJEVBf/E1MOGdLohe6ygBnFKcY=; b=Kx77Yedl2ZIYFkpH+yqYT4m6HrKGo2kXgKC/5wVGQv//6SkmWmUSPs+xKXwXgzrovRbbfv8LvkwAhW5tboEZEqwi5BkrcxCxvCn8pUFw0uDZIlkMDm65YaJQuIypluM7kVYSXZNkTXO4eVXG5ZXHaGbzE/fg5VBEdQMwsvAKpOzwGv7cTxnBXsxMpY7mKxMsOvDi7JThqKzX50+n7SF1cd+on2aFLmGKNOECaSA60/h3L1ftlUCtPDaTa0ObVvTa9COQu0ZeWKS5rGc/C+MAOU/4c0gnTOgg1IOsF56nBRQkPAxc9mMr9hmY/Lm0jRyKGI0LiSD312pUPloej3TONw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bbde9gFVI79Es/fiVmJEVBf/E1MOGdLohe6ygBnFKcY=; b=jWlN/tY+cvVFHQuFjHL4LJZQ6n2hpupC1ad6ARf8gAJoRzH3lodBTXpUoBZP/38AVzp0AI6fDHUbf1YMRnyhbqXv1yo7HYn+elQhRRh0ZdI45/T4we4rM/cMn8tL3HXYKixnUIr+IxIp62xW0CkDMHWfvCSLqUIXhhIXfWXfEhg=
Received: from (2603:10a6:208:22::25) by AM9PR07MB7697.eurprd07.prod.outlook.com (2603:10a6:20b:2c2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.20; Mon, 8 Feb 2021 20:46:03 +0000
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::24d3:85ea:df17:ed0b]) by AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::24d3:85ea:df17:ed0b%3]) with mapi id 15.20.3846.024; Mon, 8 Feb 2021 20:46:03 +0000
From: Balázs Varga A <balazs.a.varga@ericsson.com>
To: Ines Robles <mariainesrobles@googlemail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-mpls-over-tsn.all@ietf.org" <draft-ietf-detnet-mpls-over-tsn.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-detnet-mpls-over-tsn-05
Thread-Index: AQHW/BqSqKTy7nkHaEmmeTO+ZdsuzapOqhrA
Date: Mon, 08 Feb 2021 20:46:03 +0000
Message-ID: <AM0PR0702MB360397F9EF91321816EEE052AC8F9@AM0PR0702MB3603.eurprd07.prod.outlook.com>
References: <161256940254.7027.5506274353118325656@ietfa.amsl.com>
In-Reply-To: <161256940254.7027.5506274353118325656@ietfa.amsl.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: googlemail.com; dkim=none (message not signed) header.d=none;googlemail.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [94.21.210.80]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 965a4489-332f-42cd-b50f-08d8cc728cb8
x-ms-traffictypediagnostic: AM9PR07MB7697:
x-microsoft-antispam-prvs: <AM9PR07MB76976D2BE67ABEC1F51F25EEAC8F9@AM9PR07MB7697.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: lQ6bDOqhoZt6rvNtyLkhiyNJZEULWxpVCkWl9wfDwCCuYrDF3JE06iTZcTH50oaOv0exwln2BzvvWBHOsBEUAzo+gkJO4DKlgzz2yP6vIxt2+iLHc1gITwVqaK+/Bxe3BvPW0+5NN8remOpw7G0uULNwD/6cCOJWm6C+iQam817yvlPrlu0BMDPck7P05xtTPeOLZuMCzw/3s3JeXYa9QbVYFiPxikBRvGSW4UuKFH/zreNFpLA06wN65T9su0IB3JzfcRfrMLQq/ZCgPk+PvQDHvvR0m4z/+rvWeuWv4ENlm2MIipOu/7BYXq37uKq1VIL41t+mtCBvX+jfoNSGdQAsLvYDvm1dj7T0pEpxF8h2ygl5TFma+vYeCDLPfAhu5TFZwzPg/YdXgJXc4j+8QqgXHta5SEO1OWEFYGB/6zn/A09RYc5q64h07DwoNTE9b/SER5XcdrU+hU8Ge4YYwyI9eJ3LGv5jP5YR7XZL1kMLA8nXwmF7pH9yHKbKGB1S5o2gaIJBENwpPGeks/uu9uoyZqxbjjWcUuVAj3Al/eua7WJQErMGZGjOaq3n9BXnRCu9LSqhXoBJfZazIGfWeEPoJad4IaapPeRbTIWmWoc=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0702MB3603.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(4326008)(71200400001)(53546011)(33656002)(85202003)(186003)(52536014)(66446008)(64756008)(6506007)(85182001)(86362001)(8936002)(26005)(8676002)(5660300002)(2906002)(7696005)(83380400001)(54906003)(66556008)(110136005)(478600001)(316002)(76116006)(66946007)(66476007)(9686003)(55016002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: fom1EDtYS3LOPoFDs8tYubfgsJAFG/YYBMUUIyUSXlC4lELW0zjes0RkH/CfB4WLisUXAOn1sr0uPgFUz0H/cKVs/aqXTOzuY/7bg12b3gyW4o0jyDjKC5Gt/lhZ4YCD2honuR1QtMoXByHzr96gOYweZSp0gww4mB+J9WOiJhv2j9KdQJMNImnFI/tkQ/ea/MoocUOH9BnC1z2Sneof8CgZ0o3k/Q6IrCWTLwJoAT7KljIxceSMyo4i0rVkJmUpc2BBfLTcrNt2ZsanLibj+CAgxxvTil1mdeOiEClIMGnuBEgFFNkUodR/p96lf9MyoUzoTOEph8EY+ZQ/4LFju940HpdiyBdaUzHF/Ma0CfD261KaSmTIWJpBFT3CLyY7J+QSoqZMNjGPqrt8YUIoTxEmMcGM8yXTC9qHJ174rr49uZoemtfr0IFxYlXkuK8HP9wmisSUOGQe+YPQMsihhEfXHPg2LyZCXdomcxgIVheOmM5+qfBgMjc5cdXTXe8CXfLTo+QCaw2bPbbVXu+61zFhZrkXYRs57I3pJqiFiXFi+bRxCz/eey1rLqUeQi3+3pW3t96GRnK0DXnZbE0qnKUbp3DBAvsLllJXkRIYDKx2lxbPUlP9vl8HD90UU2a7NTqPne5FKlKQXoMdaY7E6wNj6hn2eQMiZn61v8JzWxp1N71D0KuHgqxdH/HS1Bnxhb3bSbRUyuUpu4kHx4JN82XL/xgSzxsnEQf5tfd0+rEuN8B3oW994PlDXgTOu7UmXamIR9EcJIyZjzu7GRRDhvb7luU8+j14NmX6wGeO+Jx/j7vF2Vl27gPg4tDqGAxKQfXCf9RG3YSzkJGt2XBOMrVpqMrT8wkUJ09u5k5yfGZOY20NLrSwKbHbWPf+ZQhRu49QAwCUfXXQg1BeTu90VnFUnsoPAz/BD69hteZLPSoT9AWCq0wQccwbtQF0TwWhlAke6hE9XcZpGe9qnNs1UZOw5ZIuzXtk4BTtb9qsB5XGy7DFWM1fIRWItlHgnGfMferqCa1mKpWRis4B6KnKHVcCOG9ggIs8MQDZixZcp+rLsjutj8bsWD0TuUiB1/bTD6mbYd52i9DS8ZL2EA7tDWqjyjqI8P4XUZOjCxQywoAkmZtNqHY9I3qojFnUF/dzH3yShPJjo2yTqR06qQULhVJBKodoQ7V6Boc7RxCBDgqH2SVv2i1/C/rku34k8BlXsz7L21vfcGKoDQ6qMJy4/WngSTbOLVUbi1mjxUEGjz2440q6g36fp0tHDh6MAset1uleWGBQfsF/0BrcldrV0VWR1k8uVCBFnhVY1gn6ndZRawy2R3tpXG3mek9UDXbV
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0702MB3603.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 965a4489-332f-42cd-b50f-08d8cc728cb8
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2021 20:46:03.1079 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1mlJUGo1uYWtxcu1VkLJextu4++I05jcLvVVPasfMzbkojXnd8lDXEzzNH+6VMzsGA2wqG4p5TbRZ5fXtAIkufXlrDsuufsb7Xuq2fowpTQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR07MB7697
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/zIvBT55m1dlpu-ktv5K3Uvh2Z74>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-detnet-mpls-over-tsn-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Feb 2021 20:46:37 -0000

Hi Ines,
Many thanks for your review. 
See my reactions and proposed updates below.
Thanks
Bala'zs

-----Original Message-----
From: Ines Robles via Datatracker <noreply@ietf.org> 
Sent: Saturday, February 6, 2021 12:57 AM
To: gen-art@ietf.org
Cc: detnet@ietf.org; draft-ietf-detnet-mpls-over-tsn.all@ietf.org; last-call@ietf.org
Subject: Genart last call review of draft-ietf-detnet-mpls-over-tsn-05

Reviewer: Ines Robles
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-detnet-mpls-over-tsn-05
Reviewer: Ines Robles
Review Date: 2021-02-05
IETF LC End Date: 2021-02-05
IESG Telechat date: 2021-02-18

Summary:

This document specifies the Deterministic Networking MPLS data plane when operating over a TSN sub-network.

I have some minor questions to the authors.

Major issues: None

Minor issues: None

Nits/editorial comments:

- Page 5: Could you please describe what the "TSN treatment" comprise?

<Bala'zs> TSN treatment means to execute TSN functionalities during forwarding. I will extend the text
OLD TEXT:
       ... All these functions have to identify flows those 
       require TSN treatment.
NEW TEXT:
       ... All these functions have to identify flows those 
       require TSN treatment (i.e., applying TSN functions
       during forwarding).
END

- Are the security considerations the same for TSN-unaware that are for TSN-aware nodes? - How are the privacy considerations for those? It would be nice to mention explicitly how or where (I-D.ietf-detnet-security???) the privacy considerations are addressed for TSN-unaware and TSN-aware nodes

<Bala'zs> The I-D.ietf-detnet-security contains DetNet specific security considerations. TSN-unaware nodes are out-of-scope in the draft. TSN-aware nodes are part of both the MPLS and the TSN domain, where both domain has its own security considerations, which must be applied. 

Thank you for this document

Ines.